From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C462C282DD for ; Fri, 10 Jan 2020 19:58:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 740B2206ED for ; Fri, 10 Jan 2020 19:58:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="XPcsW5ON" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728585AbgAJT6p (ORCPT ); Fri, 10 Jan 2020 14:58:45 -0500 Received: from mail.skyhub.de ([5.9.137.197]:34950 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727650AbgAJT6p (ORCPT ); Fri, 10 Jan 2020 14:58:45 -0500 Received: from zn.tnic (p200300EC2F0ACA00F8C15324EBC48DF9.dip0.t-ipconnect.de [IPv6:2003:ec:2f0a:ca00:f8c1:5324:ebc4:8df9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id BAE561EC0AB5; Fri, 10 Jan 2020 20:58:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1578686323; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=6Zf4g5IfOki+jdhGV15Erd3yZAnIWoJKHhalmJWvQEg=; b=XPcsW5ON8bdwb6eQ1BUiL3NXPLHQ9MUEhHdnHz3BZ/O+Dq45sCeuiLmkbzg6WOB0079egu mSnz5bc6k6oLWWvtagMQKlfVRHwI754WNIS+l597r4fWVcZcWQuEambYIyxlxIglmvAJcd fCbtHhxI0Yb+ySxSfm4Qap56FFESDic= Date: Fri, 10 Jan 2020 20:58:37 +0100 From: Borislav Petkov To: Changbin Du Cc: Thomas Gleixner , Ingo Molnar , hpa@zytor.com, x86@kernel.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86/nmi: remove the irqwork from long duration nmi handler Message-ID: <20200110195837.GJ19453@zn.tnic> References: <20200101072017.82990-1-changbin.du@gmail.com> <877e20bb8o.fsf@nanos.tec.linutronix.de> <20200109210225.GK5603@zn.tnic> <20200110140549.xqjhrdpxllkvqbuk@mail.google.com> <20200110151329.GF19453@zn.tnic> <20200110173449.rhr5p4lal3aul43g@mail.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200110173449.rhr5p4lal3aul43g@mail.google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 10, 2020 at 05:34:50PM +0000, Changbin Du wrote: > Just to move all the check code together and be a standalone function. > yes, this somewhat does code refining after the irqwork is removed but > I think it is normal. But it makes review harder because your patch is removing irq_work, *nothing* in the commit message is talking about *why* you're doing that additional change. I'd imagine at the end of the commit message something like: "While at it, repurpose the IRQ work callback into a function which concentrates the NMI duration checking." This lets a reader know know why that additional change is done instead of going back'n'forth and having to ask you why you're doing this. Ok? -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette