From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9444AC33C9E for ; Sat, 11 Jan 2020 10:00:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6057420842 for ; Sat, 11 Jan 2020 10:00:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578736850; bh=QuJYVIMTRXk3gq4z/zDyeZrYy+ftsxeaBNQanbXnB+k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=yEhGTEnI7WAMA/ROM0nKymu5WRbmLtZJgKaGKeLhHn0BP+YO88HMyMNxB6Kz4IjgB 7JsE4uV5uzkBBg66alvWhDmKzdkS9fmoH8iT4r9hMcLqWk+h6/E8edVRKiahFFTuTa IfG0DVFR3a4iTNdXukq1Q3jcwHeHSZ8p3Uo3G9QE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729265AbgAKKAt (ORCPT ); Sat, 11 Jan 2020 05:00:49 -0500 Received: from mail.kernel.org ([198.145.29.99]:57394 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729064AbgAKKAq (ORCPT ); Sat, 11 Jan 2020 05:00:46 -0500 Received: from localhost (unknown [62.119.166.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 724B420848; Sat, 11 Jan 2020 10:00:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578736846; bh=QuJYVIMTRXk3gq4z/zDyeZrYy+ftsxeaBNQanbXnB+k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pSswi/nDOTtLK6iKOKbRcAJTnuR513ODUjkyTrYZsWddzSwPtkL0Nerr0x78DRsP7 gBIW+/qT3flF3iDGnbHGDJYxgG1nkknDt0HNDtkVkC9HF2WEWr8qVlRJfke1xSP2es DNyAhi1xO6MOFaxxGtXCQVy9yw2Nm8D+dux8izLU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Zhiqiang Liu , Song Liu , Sasha Levin Subject: [PATCH 4.9 08/91] md: raid1: check rdev before reference in raid1_sync_request func Date: Sat, 11 Jan 2020 10:49:01 +0100 Message-Id: <20200111094846.192840422@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200111094844.748507863@linuxfoundation.org> References: <20200111094844.748507863@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zhiqiang Liu [ Upstream commit 028288df635f5a9addd48ac4677b720192747944 ] In raid1_sync_request func, rdev should be checked before reference. Signed-off-by: Zhiqiang Liu Signed-off-by: Song Liu Signed-off-by: Sasha Levin --- drivers/md/raid1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c index 9892c41de441..8a50da4f148f 100644 --- a/drivers/md/raid1.c +++ b/drivers/md/raid1.c @@ -2633,7 +2633,7 @@ static sector_t raid1_sync_request(struct mddev *mddev, sector_t sector_nr, write_targets++; } } - if (bio->bi_end_io) { + if (rdev && bio->bi_end_io) { atomic_inc(&rdev->nr_pending); bio->bi_iter.bi_sector = sector_nr + rdev->data_offset; bio->bi_bdev = rdev->bdev; -- 2.20.1