All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Taehee Yoo <ap420073@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH net 3/5] netdevsim: avoid debugfs warning message when module is remove
Date: Sun, 12 Jan 2020 06:45:25 -0800	[thread overview]
Message-ID: <20200112064110.43245268@cakuba> (raw)
In-Reply-To: <20200111163723.4260-1-ap420073@gmail.com>

On Sat, 11 Jan 2020 16:37:23 +0000, Taehee Yoo wrote:
> When module is being removed, it couldn't be held by try_module_get().
> debugfs's open function internally tries to hold file_operation->owner
> if .owner is set.
> If holding owner operation is failed, it prints a warning message.

> [  412.227709][ T1720] debugfs file owner did not clean up at exit: ipsec

> In order to avoid the warning message, this patch makes netdevsim module
> does not set .owner. Unsetting .owner is safe because these are protected
> by inode_lock().

So inode_lock will protect from the code getting unloaded/disappearing?
At a quick glance at debugs code it doesn't seem that inode_lock would
do that. Could you explain a little more to a non-fs developer like
myself? :)

Alternatively should we perhaps hold a module reference for each device
created and force user space to clean up the devices? That may require
some fixes to the test which use netdevsim.

> Fixes: 7699353da875 ("netdevsim: add ipsec offload testing")
> Fixes: 31d3ad832948 ("netdevsim: add bpf offload support")
> Signed-off-by: Taehee Yoo <ap420073@gmail.com>

  reply	other threads:[~2020-01-12 14:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-11 16:37 [PATCH net 3/5] netdevsim: avoid debugfs warning message when module is remove Taehee Yoo
2020-01-12 14:45 ` Jakub Kicinski [this message]
2020-01-16 14:54   ` Taehee Yoo
2020-01-19 11:28     ` Taehee Yoo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200112064110.43245268@cakuba \
    --to=kuba@kernel.org \
    --cc=ap420073@gmail.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.