From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Zimmermann Subject: [PATCH v2 0/4] Use no_vblank property for drivers without VBLANK Date: Mon, 13 Jan 2020 11:38:18 +0100 Message-ID: <20200113103822.24473-1-tzimmermann@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" To: airlied@linux.ie, daniel@ffwll.ch, kraxel@redhat.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, hdegoede@redhat.com, david@lechnology.com, noralf@tronnes.org, sean@poorly.run, oleksandr_andrushchenko@epam.com, sam@ravnborg.org, laurent.pinchart@ideasonboard.com, emil.velikov@collabora.com Cc: xen-devel@lists.xenproject.org, dri-devel@lists.freedesktop.or, Thomas Zimmermann , virtualization@lists.linux-foundation.org List-Id: virtualization@lists.linuxfoundation.org Instead of faking VBLANK events by themselves, drivers without VBLANK support can enable drm_crtc_vblank.no_vblank and let DRM do the rest. The patchset makes this official and converts over several drivers. Ast already uses the functionality and just needs a cleanup. Cirrus can be converted easily by setting the field in the check() callback and removing the existing VBLANK code. For most other simple-KMS drivers without enable_vblank() and check(), simple-KMS helpers can enable the faked VBLANK by default. The only exception is Xen, which comes with its own VBLANK logic and should rather to disable no_vblank. v2: * document functionality (Daniel) * cleanup ast (Daniel) * let simple-kms handle no_vblank where possible Thomas Zimmermann (4): drm: Document struct drm_crtc_state.no_vblank for faking VBLANK events drm/ast: Set struct drm_crtc_state.no_vblank in atomic_check() drm/cirrus: Let DRM core send VBLANK events drm/simple-kms: Let DRM core send VBLANK events by default drivers/gpu/drm/ast/ast_mode.c | 4 ++-- drivers/gpu/drm/bochs/bochs_kms.c | 9 --------- drivers/gpu/drm/cirrus/cirrus.c | 10 ++-------- drivers/gpu/drm/drm_atomic_helper.c | 4 +++- drivers/gpu/drm/drm_mipi_dbi.c | 9 --------- drivers/gpu/drm/drm_simple_kms_helper.c | 19 +++++++++++++++---- drivers/gpu/drm/tiny/gm12u320.c | 9 --------- drivers/gpu/drm/tiny/ili9225.c | 9 --------- drivers/gpu/drm/tiny/repaper.c | 9 --------- drivers/gpu/drm/tiny/st7586.c | 9 --------- drivers/gpu/drm/udl/udl_modeset.c | 11 ----------- drivers/gpu/drm/xen/xen_drm_front_kms.c | 13 +++++++++++++ include/drm/drm_crtc.h | 9 +++++++-- include/drm/drm_simple_kms_helper.h | 7 +++++-- 14 files changed, 47 insertions(+), 84 deletions(-) -- 2.24.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89932C33CAD for ; Mon, 13 Jan 2020 10:39:30 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6579A20661 for ; Mon, 13 Jan 2020 10:39:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6579A20661 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iqx7r-0007be-BO; Mon, 13 Jan 2020 10:39:15 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iqx7F-0007ZZ-Hi for xen-devel@lists.xenproject.org; Mon, 13 Jan 2020 10:38:37 +0000 X-Inumbo-ID: d74f4252-35f0-11ea-8249-12813bfff9fa Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d74f4252-35f0-11ea-8249-12813bfff9fa; Mon, 13 Jan 2020 10:38:31 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id BC786B15A; Mon, 13 Jan 2020 10:38:29 +0000 (UTC) From: Thomas Zimmermann To: airlied@linux.ie, daniel@ffwll.ch, kraxel@redhat.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, hdegoede@redhat.com, david@lechnology.com, noralf@tronnes.org, sean@poorly.run, oleksandr_andrushchenko@epam.com, sam@ravnborg.org, laurent.pinchart@ideasonboard.com, emil.velikov@collabora.com Date: Mon, 13 Jan 2020 11:38:18 +0100 Message-Id: <20200113103822.24473-1-tzimmermann@suse.de> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 X-Mailman-Approved-At: Mon, 13 Jan 2020 10:39:14 +0000 Subject: [Xen-devel] [PATCH v2 0/4] Use no_vblank property for drivers without VBLANK X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, dri-devel@lists.freedesktop.or, Thomas Zimmermann , virtualization@lists.linux-foundation.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" SW5zdGVhZCBvZiBmYWtpbmcgVkJMQU5LIGV2ZW50cyBieSB0aGVtc2VsdmVzLCBkcml2ZXJzIHdp dGhvdXQgVkJMQU5LCnN1cHBvcnQgY2FuIGVuYWJsZSBkcm1fY3J0Y192Ymxhbmsubm9fdmJsYW5r IGFuZCBsZXQgRFJNIGRvIHRoZSByZXN0LgpUaGUgcGF0Y2hzZXQgbWFrZXMgdGhpcyBvZmZpY2lh bCBhbmQgY29udmVydHMgb3ZlciBzZXZlcmFsIGRyaXZlcnMuCgpBc3QgYWxyZWFkeSB1c2VzIHRo ZSBmdW5jdGlvbmFsaXR5IGFuZCBqdXN0IG5lZWRzIGEgY2xlYW51cC4gQ2lycnVzIGNhbgpiZSBj b252ZXJ0ZWQgZWFzaWx5IGJ5IHNldHRpbmcgdGhlIGZpZWxkIGluIHRoZSBjaGVjaygpIGNhbGxi YWNrIGFuZApyZW1vdmluZyB0aGUgZXhpc3RpbmcgVkJMQU5LIGNvZGUuIEZvciBtb3N0IG90aGVy IHNpbXBsZS1LTVMgZHJpdmVycwp3aXRob3V0IGVuYWJsZV92YmxhbmsoKSBhbmQgY2hlY2soKSwg c2ltcGxlLUtNUyBoZWxwZXJzIGNhbiBlbmFibGUgdGhlCmZha2VkIFZCTEFOSyBieSBkZWZhdWx0 LiBUaGUgb25seSBleGNlcHRpb24gaXMgWGVuLCB3aGljaCBjb21lcyB3aXRoCml0cyBvd24gVkJM QU5LIGxvZ2ljIGFuZCBzaG91bGQgcmF0aGVyIHRvIGRpc2FibGUgbm9fdmJsYW5rLgoKdjI6Cgkq IGRvY3VtZW50IGZ1bmN0aW9uYWxpdHkgKERhbmllbCkKCSogY2xlYW51cCBhc3QgKERhbmllbCkK CSogbGV0IHNpbXBsZS1rbXMgaGFuZGxlIG5vX3ZibGFuayB3aGVyZSBwb3NzaWJsZQoKVGhvbWFz IFppbW1lcm1hbm4gKDQpOgogIGRybTogRG9jdW1lbnQgc3RydWN0IGRybV9jcnRjX3N0YXRlLm5v X3ZibGFuayBmb3IgZmFraW5nIFZCTEFOSyBldmVudHMKICBkcm0vYXN0OiBTZXQgc3RydWN0IGRy bV9jcnRjX3N0YXRlLm5vX3ZibGFuayBpbiBhdG9taWNfY2hlY2soKQogIGRybS9jaXJydXM6IExl dCBEUk0gY29yZSBzZW5kIFZCTEFOSyBldmVudHMKICBkcm0vc2ltcGxlLWttczogTGV0IERSTSBj b3JlIHNlbmQgVkJMQU5LIGV2ZW50cyBieSBkZWZhdWx0CgogZHJpdmVycy9ncHUvZHJtL2FzdC9h c3RfbW9kZS5jICAgICAgICAgIHwgIDQgKystLQogZHJpdmVycy9ncHUvZHJtL2JvY2hzL2JvY2hz X2ttcy5jICAgICAgIHwgIDkgLS0tLS0tLS0tCiBkcml2ZXJzL2dwdS9kcm0vY2lycnVzL2NpcnJ1 cy5jICAgICAgICAgfCAxMCArKy0tLS0tLS0tCiBkcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19o ZWxwZXIuYyAgICAgfCAgNCArKystCiBkcml2ZXJzL2dwdS9kcm0vZHJtX21pcGlfZGJpLmMgICAg ICAgICAgfCAgOSAtLS0tLS0tLS0KIGRyaXZlcnMvZ3B1L2RybS9kcm1fc2ltcGxlX2ttc19oZWxw ZXIuYyB8IDE5ICsrKysrKysrKysrKysrKy0tLS0KIGRyaXZlcnMvZ3B1L2RybS90aW55L2dtMTJ1 MzIwLmMgICAgICAgICB8ICA5IC0tLS0tLS0tLQogZHJpdmVycy9ncHUvZHJtL3RpbnkvaWxpOTIy NS5jICAgICAgICAgIHwgIDkgLS0tLS0tLS0tCiBkcml2ZXJzL2dwdS9kcm0vdGlueS9yZXBhcGVy LmMgICAgICAgICAgfCAgOSAtLS0tLS0tLS0KIGRyaXZlcnMvZ3B1L2RybS90aW55L3N0NzU4Ni5j ICAgICAgICAgICB8ICA5IC0tLS0tLS0tLQogZHJpdmVycy9ncHUvZHJtL3VkbC91ZGxfbW9kZXNl dC5jICAgICAgIHwgMTEgLS0tLS0tLS0tLS0KIGRyaXZlcnMvZ3B1L2RybS94ZW4veGVuX2RybV9m cm9udF9rbXMuYyB8IDEzICsrKysrKysrKysrKysKIGluY2x1ZGUvZHJtL2RybV9jcnRjLmggICAg ICAgICAgICAgICAgICB8ICA5ICsrKysrKystLQogaW5jbHVkZS9kcm0vZHJtX3NpbXBsZV9rbXNf aGVscGVyLmggICAgIHwgIDcgKysrKystLQogMTQgZmlsZXMgY2hhbmdlZCwgNDcgaW5zZXJ0aW9u cygrKSwgODQgZGVsZXRpb25zKC0pCgotLQoyLjI0LjEKCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZl bEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxt YW4vbGlzdGluZm8veGVuLWRldmVs