From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77D65C33CAD for ; Mon, 13 Jan 2020 11:05:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 48C7E2084D for ; Mon, 13 Jan 2020 11:05:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gR7s3KYu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726878AbgAMLFc (ORCPT ); Mon, 13 Jan 2020 06:05:32 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:23661 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726480AbgAMLFc (ORCPT ); Mon, 13 Jan 2020 06:05:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578913531; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=59lWFDYW3VFdpEox0GkaZ5lVDt5TY88LO0e7WvoKGxc=; b=gR7s3KYuEMfmeiES/c/pqB6HP37LGYmkti9KamMsxPANFWj2Vj02RdUaCFWHi/ZR4jatK6 qFj6BX8M+TX9y8zhA6dFfBq2f9pdmVloKzr2EPHkWN/5Uz+mMAWMaF/d6Cq11hCtKuxfm5 h0Zn8MVkT5EPdhBe4gZvcDICT6Y6E3s= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-11-plPcE48VMBu2XOLWC5sA6w-1; Mon, 13 Jan 2020 06:05:28 -0500 X-MC-Unique: plPcE48VMBu2XOLWC5sA6w-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3BE9A1137853; Mon, 13 Jan 2020 11:05:25 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-116-106.ams2.redhat.com [10.36.116.106]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3FF9687EC6; Mon, 13 Jan 2020 11:05:22 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 4B28531F5E; Mon, 13 Jan 2020 12:05:21 +0100 (CET) Date: Mon, 13 Jan 2020 12:05:21 +0100 From: Gerd Hoffmann To: Dmitry Sepp Cc: spice-devel@lists.freedesktop.org, Keiichi Watanabe , virtio-dev@lists.oasis-open.org, Tomasz Figa , Linux Media Mailing List , Alexandre Courbot , Alex Lau , Daniel Vetter , Dylan Reid , Enrico Granata , Frediano Ziglio , Hans Verkuil , =?utf-8?B?U3TDqXBoYW5l?= Marchesin , Pawel Osciak , David Stevens , uril@redhat.com Subject: Re: [virtio-dev] Re: [PATCH v2 0/1] VirtIO video device specification Message-ID: <20200113110521.5ogc3fcy4zq32yzg@sirius.home.kraxel.org> References: <20191218130214.170703-1-keiichiw@chromium.org> <7740094.NyiUUSuA9g@os-lin-dmo> <20200113095636.blov62o4gbf27om5@sirius.home.kraxel.org> <12433898.dW097sEU6C@os-lin-dmo> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <12433898.dW097sEU6C@os-lin-dmo> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Mon, Jan 13, 2020 at 11:41:45AM +0100, Dmitry Sepp wrote: > Hi Gerd, > > Thanks for reviewing! > > On Montag, 13. Januar 2020 10:56:36 CET Gerd Hoffmann wrote: > > Hi, > > > > > This also means that we cannot have unspec for planes layout. Device > > > either > > > expects planes in separate buffers or in one buffer with some offsets, > > > there cannot be mixed cases. > > > > Hmm. Is it useful to support both? Or maybe support the "one buffer + > > offsets" case only? Splitting one buffer into multiple smaller ones > > internally if needed shouldn't be a problem, and it would simplify the > > interface a bit ... > > > > Ok, let's consider the following case: > - the device expects planes in separate buffers. > - say, Android on the guest side also imports planes in separate buffers into the driver. > - but he driver only supports one buffer + offsets. > > Do you mean the driver then can join the underlying page lists and set offsets then? Yes, > this would probably make sense. Well, no. Tomasz Figa had splitted the devices into three groups: (1) requires single buffer. (2) allows any layout (including the one (1) devices want). (3) requires per-plane buffers. Category (3) devices are apparently rare and old. Both category (1)+(2) devices can handle single buffers just fine. So maybe support only that? Hope it's more clear this time, Gerd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: virtio-dev-return-6650-cohuck=redhat.com@lists.oasis-open.org Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id E5046985CD4 for ; Mon, 13 Jan 2020 11:05:31 +0000 (UTC) Date: Mon, 13 Jan 2020 12:05:21 +0100 From: Gerd Hoffmann Message-ID: <20200113110521.5ogc3fcy4zq32yzg@sirius.home.kraxel.org> References: <20191218130214.170703-1-keiichiw@chromium.org> <7740094.NyiUUSuA9g@os-lin-dmo> <20200113095636.blov62o4gbf27om5@sirius.home.kraxel.org> <12433898.dW097sEU6C@os-lin-dmo> MIME-Version: 1.0 In-Reply-To: <12433898.dW097sEU6C@os-lin-dmo> Subject: Re: [virtio-dev] Re: [PATCH v2 0/1] VirtIO video device specification Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline To: Dmitry Sepp Cc: spice-devel@lists.freedesktop.org, Keiichi Watanabe , virtio-dev@lists.oasis-open.org, Tomasz Figa , Linux Media Mailing List , Alexandre Courbot , Alex Lau , Daniel Vetter , Dylan Reid , Enrico Granata , Frediano Ziglio , Hans Verkuil , =?utf-8?B?U3TDqXBoYW5l?= Marchesin , Pawel Osciak , David Stevens , uril@redhat.com List-ID: On Mon, Jan 13, 2020 at 11:41:45AM +0100, Dmitry Sepp wrote: > Hi Gerd, >=20 > Thanks for reviewing! >=20 > On Montag, 13. Januar 2020 10:56:36 CET Gerd Hoffmann wrote: > > Hi, > >=20 > > > This also means that we cannot have unspec for planes layout. Device > > > either > > > expects planes in separate buffers or in one buffer with some offsets= , > > > there cannot be mixed cases. > >=20 > > Hmm. Is it useful to support both? Or maybe support the "one buffer + > > offsets" case only? Splitting one buffer into multiple smaller ones > > internally if needed shouldn't be a problem, and it would simplify the > > interface a bit ... > >=20 >=20 > Ok, let's consider the following case: > - the device expects planes in separate buffers. > - say, Android on the guest side also imports planes in separate buffers= into the driver. > - but he driver only supports one buffer + offsets. >=20 > Do you mean the driver then can join the underlying page lists and set of= fsets then? Yes,=20 > this would probably make sense. Well, no. Tomasz Figa had splitted the devices into three groups: (1) requires single buffer. (2) allows any layout (including the one (1) devices want). (3) requires per-plane buffers. Category (3) devices are apparently rare and old. Both category (1)+(2) devices can handle single buffers just fine. So maybe support only that? Hope it's more clear this time, Gerd --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org