From: Mark Brown <broonie@kernel.org>
To: Robert Marko <robert.marko@sartura.hr>
Cc: lgirdwood@gmail.com, robh+dt@kernel.org,
linux-kernel@vger.kernel.org, agross@kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: vqmmc-ipq4019-regulator: add binding document
Date: Mon, 13 Jan 2020 14:41:01 +0000 [thread overview]
Message-ID: <20200113144101.GM3897@sirena.org.uk> (raw)
In-Reply-To: <20200112113003.11110-2-robert.marko@sartura.hr>
[-- Attachment #1: Type: text/plain, Size: 901 bytes --]
On Sun, Jan 12, 2020 at 12:30:02PM +0100, Robert Marko wrote:
> + regulator-min-microvolt:
> + description: smallest voltage consumers may set
> +
> + regulator-max-microvolt:
> + description: largest voltage consumers may set
Why are these explicitly specified in this binding?
> + regulator-always-on:
> + description: boolean, regulator should never be disabled
> + type: boolean
If it's not physically possible to disable the regulator then
specifying this property is redundant so...
> +required:
> + - compatible
> + - reg
> + - regulator-name
> + - regulator-min-microvolt
> + - regulator-max-microvolt
> + - regulator-always-on
...requiring it doesn't seem useful. All the other
regulator-specific properties shouldn't be required either,
unless the user specifies a voltage range we won't allow changes
at all which should be safe and the name is purely cosmetic.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-01-13 14:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-12 11:30 [PATCH 1/3] regulator: add IPQ4019 SDHCI VQMMC LDO driver Robert Marko
2020-01-12 11:30 ` [PATCH 2/3] dt-bindings: vqmmc-ipq4019-regulator: add binding document Robert Marko
2020-01-13 14:41 ` Mark Brown [this message]
2020-01-21 10:34 ` Robert Marko
[not found] ` <CA+HBbNFZRd6igqUC6qjBdaPQ-37x_p90zCByTxNFDsJsRpMsGw@mail.gmail.com>
2020-01-21 16:27 ` Mark Brown
2020-01-12 11:30 ` [PATCH 3/3] arm: dts: IPQ4019: add SDHCI VQMMC LDO node Robert Marko
2020-01-13 15:13 ` Applied "regulator: add IPQ4019 SDHCI VQMMC LDO driver" to the regulator tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200113144101.GM3897@sirena.org.uk \
--to=broonie@kernel.org \
--cc=agross@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robert.marko@sartura.hr \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.