From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5524DC33CB8 for ; Mon, 13 Jan 2020 15:37:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 25F0921739 for ; Mon, 13 Jan 2020 15:37:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="HIDZ4epq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728804AbgAMPhy (ORCPT ); Mon, 13 Jan 2020 10:37:54 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:57874 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728797AbgAMPhx (ORCPT ); Mon, 13 Jan 2020 10:37:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=fWczM9DLx1FK48u8XSx4af+h330mJlxpghJsvnVaqrA=; b=HIDZ4epq926UxT06NFoqXP0QdF Ur59vo1stJEQAhFpBPj902qub5AA6aZ7tjmo1T7b4Bcn2M748hVk7zbdKY5MFiDnyCP+EYp83n7c1 mIJcpbWNlLa7w7YYPsTor72vLw7U68oj1pYpktn7LtqKhB4sKnJdMw0h3gxGqpUYaK6bWb5mh6yKK 2SMI4g3AZ8CLnrcxV+gcRnOtTaubpDDvHj6O/oiGqptYxwiI2sBHJao24upsbhSZi9mspf5lxIi0T d+vrwlC5bGgBsGaC9TUwvsYkclacLYkvAufbbyeDvAgDj79k2tTURRn3PVsKZN2y7KebhYvSxpSWy j0iUJV7w==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1ir1mr-00077G-CN; Mon, 13 Jan 2020 15:37:53 +0000 From: Matthew Wilcox To: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Cc: "Matthew Wilcox (Oracle)" , jlayton@kernel.org, hch@infradead.org Subject: [PATCH 8/8] mm: Unify all add_to_page_cache variants Date: Mon, 13 Jan 2020 07:37:46 -0800 Message-Id: <20200113153746.26654-9-willy@infradead.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20200113153746.26654-1-willy@infradead.org> References: <20200113153746.26654-1-willy@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org From: "Matthew Wilcox (Oracle)" We already have various bits of add_to_page_cache() executed conditionally on !PageHuge(page); add the add_to_page_cache_lru() pieces as some more code which isn't executed for huge pages. This lets us remove the old add_to_page_cache() and rename __add_to_page_cache_locked() to add_to_page_cache(). Include a compatibility define so we don't have to change all 20+ callers of add_to_page_cache_lru(). Signed-off-by: Matthew Wilcox (Oracle) --- include/linux/pagemap.h | 5 ++-- mm/filemap.c | 65 ++++++++++++----------------------------- 2 files changed, 21 insertions(+), 49 deletions(-) diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h index 3ce051fb9c73..753e8df6a5b1 100644 --- a/include/linux/pagemap.h +++ b/include/linux/pagemap.h @@ -606,14 +606,15 @@ static inline int fault_in_pages_readable(const char __user *uaddr, int size) int add_to_page_cache(struct page *page, struct address_space *mapping, pgoff_t index, gfp_t gfp); -int add_to_page_cache_lru(struct page *page, struct address_space *mapping, - pgoff_t index, gfp_t gfp_mask); extern void delete_from_page_cache(struct page *page); extern void __delete_from_page_cache(struct page *page, void *shadow); int replace_page_cache_page(struct page *old, struct page *new, gfp_t gfp_mask); void delete_from_page_cache_batch(struct address_space *mapping, struct pagevec *pvec); +#define add_to_page_cache_lru(page, mapping, index, gfp) \ + add_to_page_cache(page, mapping, index, gfp) + static inline unsigned long dir_pages(struct inode *inode) { return (unsigned long)(inode->i_size + PAGE_SIZE - 1) >> diff --git a/mm/filemap.c b/mm/filemap.c index fb87f5fa75e6..83f45f31a00a 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -847,19 +847,18 @@ int replace_page_cache_page(struct page *old, struct page *new, gfp_t gfp_mask) } EXPORT_SYMBOL_GPL(replace_page_cache_page); -static int __add_to_page_cache_locked(struct page *page, - struct address_space *mapping, - pgoff_t offset, gfp_t gfp_mask, - void **shadowp) +int add_to_page_cache(struct page *page, struct address_space *mapping, + pgoff_t offset, gfp_t gfp_mask) { XA_STATE(xas, &mapping->i_pages, offset); int huge = PageHuge(page); struct mem_cgroup *memcg; int error; - void *old; + void *old, *shadow = NULL; VM_BUG_ON_PAGE(!PageLocked(page), page); VM_BUG_ON_PAGE(PageSwapBacked(page), page); + __SetPageLocked(page); mapping_set_update(&xas, mapping); if (!huge) { @@ -884,8 +883,7 @@ static int __add_to_page_cache_locked(struct page *page, if (xa_is_value(old)) { mapping->nrexceptional--; - if (shadowp) - *shadowp = old; + shadow = old; } mapping->nrpages++; @@ -899,45 +897,8 @@ static int __add_to_page_cache_locked(struct page *page, if (xas_error(&xas)) goto error; - if (!huge) + if (!huge) { mem_cgroup_commit_charge(page, memcg, false, false); - trace_mm_filemap_add_to_page_cache(page); - return 0; -error: - page->mapping = NULL; - /* Leave page->index set: truncation relies upon it */ - if (!huge) - mem_cgroup_cancel_charge(page, memcg, false); - put_page(page); - return xas_error(&xas); -} -ALLOW_ERROR_INJECTION(__add_to_page_cache_locked, ERRNO); - -int add_to_page_cache(struct page *page, struct address_space *mapping, - pgoff_t offset, gfp_t gfp_mask) -{ - int err; - - __SetPageLocked(page); - err = __add_to_page_cache_locked(page, mapping, offset, - gfp_mask, NULL); - if (unlikely(err)) - __ClearPageLocked(page); - return err; -} - -int add_to_page_cache_lru(struct page *page, struct address_space *mapping, - pgoff_t offset, gfp_t gfp_mask) -{ - void *shadow = NULL; - int ret; - - __SetPageLocked(page); - ret = __add_to_page_cache_locked(page, mapping, offset, - gfp_mask, &shadow); - if (unlikely(ret)) - __ClearPageLocked(page); - else { /* * The page might have been evicted from cache only * recently, in which case it should be activated like @@ -951,9 +912,19 @@ int add_to_page_cache_lru(struct page *page, struct address_space *mapping, workingset_refault(page, shadow); lru_cache_add(page); } - return ret; + trace_mm_filemap_add_to_page_cache(page); + return 0; +error: + page->mapping = NULL; + /* Leave page->index set: truncation relies upon it */ + if (!huge) + mem_cgroup_cancel_charge(page, memcg, false); + put_page(page); + __ClearPageLocked(page); + return xas_error(&xas); } -EXPORT_SYMBOL_GPL(add_to_page_cache_lru); +ALLOW_ERROR_INJECTION(add_to_page_cache, ERRNO); +EXPORT_SYMBOL_GPL(add_to_page_cache); #ifdef CONFIG_NUMA struct page *__page_cache_alloc(gfp_t gfp) -- 2.24.1