* [PATCH 0/2] soundwire: cadence: remove warnings
@ 2020-01-13 21:10 ` Pierre-Louis Bossart
0 siblings, 0 replies; 8+ messages in thread
From: Pierre-Louis Bossart @ 2020-01-13 21:10 UTC (permalink / raw)
To: alsa-devel
Cc: linux-kernel, tiwai, broonie, vkoul, gregkh, jank,
srinivas.kandagatla, slawomir.blauciak, Bard liao, Rander Wang,
Ranjani Sridharan, Pierre-Louis Bossart
Fix warnings reported by cppcheck and make W=1
Pierre-Louis Bossart (2):
soundwire: cadence: update kernel-doc parameter descriptions
soundwire: cadence: remove useless variable incrementation
drivers/soundwire/cadence_master.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
--
2.20.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* [alsa-devel] [PATCH 0/2] soundwire: cadence: remove warnings
@ 2020-01-13 21:10 ` Pierre-Louis Bossart
0 siblings, 0 replies; 8+ messages in thread
From: Pierre-Louis Bossart @ 2020-01-13 21:10 UTC (permalink / raw)
To: alsa-devel
Cc: Pierre-Louis Bossart, tiwai, gregkh, linux-kernel,
Ranjani Sridharan, vkoul, broonie, srinivas.kandagatla, jank,
slawomir.blauciak, Bard liao, Rander Wang
Fix warnings reported by cppcheck and make W=1
Pierre-Louis Bossart (2):
soundwire: cadence: update kernel-doc parameter descriptions
soundwire: cadence: remove useless variable incrementation
drivers/soundwire/cadence_master.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
--
2.20.1
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/2] soundwire: cadence: update kernel-doc parameter descriptions
2020-01-13 21:10 ` [alsa-devel] " Pierre-Louis Bossart
@ 2020-01-13 21:10 ` Pierre-Louis Bossart
-1 siblings, 0 replies; 8+ messages in thread
From: Pierre-Louis Bossart @ 2020-01-13 21:10 UTC (permalink / raw)
To: alsa-devel
Cc: linux-kernel, tiwai, broonie, vkoul, gregkh, jank,
srinivas.kandagatla, slawomir.blauciak, Bard liao, Rander Wang,
Ranjani Sridharan, Pierre-Louis Bossart, Sanyog Kale
make W=1 reports inconsistencies with parameter descriptions, fix
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
drivers/soundwire/cadence_master.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/soundwire/cadence_master.c b/drivers/soundwire/cadence_master.c
index fed21e2b2277..377628de380d 100644
--- a/drivers/soundwire/cadence_master.c
+++ b/drivers/soundwire/cadence_master.c
@@ -814,6 +814,7 @@ EXPORT_SYMBOL(sdw_cdns_exit_reset);
/**
* sdw_cdns_enable_interrupt() - Enable SDW interrupts and update config
* @cdns: Cadence instance
+ * @state: True if we are trying to enable interrupt.
*/
int sdw_cdns_enable_interrupt(struct sdw_cdns *cdns, bool state)
{
@@ -1224,8 +1225,10 @@ EXPORT_SYMBOL(cdns_set_sdw_stream);
* cdns_find_pdi() - Find a free PDI
*
* @cdns: Cadence instance
+ * @offset: Starting offset
* @num: Number of PDIs
* @pdi: PDI instances
+ * @dai_id: DAI id
*
* Find a PDI for a given PDI array. The PDI num and dai_id are
* expected to match, return NULL otherwise.
@@ -1277,6 +1280,7 @@ EXPORT_SYMBOL(sdw_cdns_config_stream);
* @stream: Stream to be allocated
* @ch: Channel count
* @dir: Data direction
+ * @dai_id: DAI id
*/
struct sdw_cdns_pdi *sdw_cdns_alloc_pdi(struct sdw_cdns *cdns,
struct sdw_cdns_streams *stream,
--
2.20.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [alsa-devel] [PATCH 1/2] soundwire: cadence: update kernel-doc parameter descriptions
@ 2020-01-13 21:10 ` Pierre-Louis Bossart
0 siblings, 0 replies; 8+ messages in thread
From: Pierre-Louis Bossart @ 2020-01-13 21:10 UTC (permalink / raw)
To: alsa-devel
Cc: Pierre-Louis Bossart, tiwai, gregkh, linux-kernel,
Ranjani Sridharan, vkoul, broonie, srinivas.kandagatla, jank,
slawomir.blauciak, Sanyog Kale, Bard liao, Rander Wang
make W=1 reports inconsistencies with parameter descriptions, fix
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
drivers/soundwire/cadence_master.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/soundwire/cadence_master.c b/drivers/soundwire/cadence_master.c
index fed21e2b2277..377628de380d 100644
--- a/drivers/soundwire/cadence_master.c
+++ b/drivers/soundwire/cadence_master.c
@@ -814,6 +814,7 @@ EXPORT_SYMBOL(sdw_cdns_exit_reset);
/**
* sdw_cdns_enable_interrupt() - Enable SDW interrupts and update config
* @cdns: Cadence instance
+ * @state: True if we are trying to enable interrupt.
*/
int sdw_cdns_enable_interrupt(struct sdw_cdns *cdns, bool state)
{
@@ -1224,8 +1225,10 @@ EXPORT_SYMBOL(cdns_set_sdw_stream);
* cdns_find_pdi() - Find a free PDI
*
* @cdns: Cadence instance
+ * @offset: Starting offset
* @num: Number of PDIs
* @pdi: PDI instances
+ * @dai_id: DAI id
*
* Find a PDI for a given PDI array. The PDI num and dai_id are
* expected to match, return NULL otherwise.
@@ -1277,6 +1280,7 @@ EXPORT_SYMBOL(sdw_cdns_config_stream);
* @stream: Stream to be allocated
* @ch: Channel count
* @dir: Data direction
+ * @dai_id: DAI id
*/
struct sdw_cdns_pdi *sdw_cdns_alloc_pdi(struct sdw_cdns *cdns,
struct sdw_cdns_streams *stream,
--
2.20.1
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/2] soundwire: cadence: remove useless variable incrementation
2020-01-13 21:10 ` [alsa-devel] " Pierre-Louis Bossart
@ 2020-01-13 21:10 ` Pierre-Louis Bossart
-1 siblings, 0 replies; 8+ messages in thread
From: Pierre-Louis Bossart @ 2020-01-13 21:10 UTC (permalink / raw)
To: alsa-devel
Cc: linux-kernel, tiwai, broonie, vkoul, gregkh, jank,
srinivas.kandagatla, slawomir.blauciak, Bard liao, Rander Wang,
Ranjani Sridharan, Pierre-Louis Bossart, Sanyog Kale
Fix cppcheck warning:
drivers/soundwire/cadence_master.c:992:9: style: Variable 'offset' is
assigned a value that is never used. [unreadVariable]
offset += stream->num_out;
^
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
drivers/soundwire/cadence_master.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/soundwire/cadence_master.c b/drivers/soundwire/cadence_master.c
index 377628de380d..d8d476a9fd21 100644
--- a/drivers/soundwire/cadence_master.c
+++ b/drivers/soundwire/cadence_master.c
@@ -949,8 +949,6 @@ int sdw_cdns_pdi_init(struct sdw_cdns *cdns,
ret = cdns_allocate_pdi(cdns, &stream->out,
stream->num_out, offset);
- offset += stream->num_out;
-
if (ret)
return ret;
--
2.20.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [alsa-devel] [PATCH 2/2] soundwire: cadence: remove useless variable incrementation
@ 2020-01-13 21:10 ` Pierre-Louis Bossart
0 siblings, 0 replies; 8+ messages in thread
From: Pierre-Louis Bossart @ 2020-01-13 21:10 UTC (permalink / raw)
To: alsa-devel
Cc: Pierre-Louis Bossart, tiwai, gregkh, linux-kernel,
Ranjani Sridharan, vkoul, broonie, srinivas.kandagatla, jank,
slawomir.blauciak, Sanyog Kale, Bard liao, Rander Wang
Fix cppcheck warning:
drivers/soundwire/cadence_master.c:992:9: style: Variable 'offset' is
assigned a value that is never used. [unreadVariable]
offset += stream->num_out;
^
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
drivers/soundwire/cadence_master.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/soundwire/cadence_master.c b/drivers/soundwire/cadence_master.c
index 377628de380d..d8d476a9fd21 100644
--- a/drivers/soundwire/cadence_master.c
+++ b/drivers/soundwire/cadence_master.c
@@ -949,8 +949,6 @@ int sdw_cdns_pdi_init(struct sdw_cdns *cdns,
ret = cdns_allocate_pdi(cdns, &stream->out,
stream->num_out, offset);
- offset += stream->num_out;
-
if (ret)
return ret;
--
2.20.1
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 0/2] soundwire: cadence: remove warnings
2020-01-13 21:10 ` [alsa-devel] " Pierre-Louis Bossart
@ 2020-01-14 6:33 ` Vinod Koul
-1 siblings, 0 replies; 8+ messages in thread
From: Vinod Koul @ 2020-01-14 6:33 UTC (permalink / raw)
To: Pierre-Louis Bossart
Cc: alsa-devel, linux-kernel, tiwai, broonie, gregkh, jank,
srinivas.kandagatla, slawomir.blauciak, Bard liao, Rander Wang,
Ranjani Sridharan
On 13-01-20, 15:10, Pierre-Louis Bossart wrote:
> Fix warnings reported by cppcheck and make W=1
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [alsa-devel] [PATCH 0/2] soundwire: cadence: remove warnings
@ 2020-01-14 6:33 ` Vinod Koul
0 siblings, 0 replies; 8+ messages in thread
From: Vinod Koul @ 2020-01-14 6:33 UTC (permalink / raw)
To: Pierre-Louis Bossart
Cc: alsa-devel, tiwai, gregkh, linux-kernel, Ranjani Sridharan,
broonie, srinivas.kandagatla, jank, slawomir.blauciak, Bard liao,
Rander Wang
On 13-01-20, 15:10, Pierre-Louis Bossart wrote:
> Fix warnings reported by cppcheck and make W=1
Applied, thanks
--
~Vinod
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-01-14 14:40 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-13 21:10 [PATCH 0/2] soundwire: cadence: remove warnings Pierre-Louis Bossart
2020-01-13 21:10 ` [alsa-devel] " Pierre-Louis Bossart
2020-01-13 21:10 ` [PATCH 1/2] soundwire: cadence: update kernel-doc parameter descriptions Pierre-Louis Bossart
2020-01-13 21:10 ` [alsa-devel] " Pierre-Louis Bossart
2020-01-13 21:10 ` [PATCH 2/2] soundwire: cadence: remove useless variable incrementation Pierre-Louis Bossart
2020-01-13 21:10 ` [alsa-devel] " Pierre-Louis Bossart
2020-01-14 6:33 ` [PATCH 0/2] soundwire: cadence: remove warnings Vinod Koul
2020-01-14 6:33 ` [alsa-devel] " Vinod Koul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.