All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Laxman Dewangan <ldewangan@nvidia.com>,
	Mikko Perttunen <cyndis@kapsi.fi>,
	linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 4/8] i2c: tegra: Support atomic transfers
Date: Mon, 13 Jan 2020 23:03:15 +0100	[thread overview]
Message-ID: <20200113220315.GB2689@ninjato> (raw)
In-Reply-To: <20200112171430.27219-5-digetx@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 828 bytes --]

On Sun, Jan 12, 2020 at 08:14:26PM +0300, Dmitry Osipenko wrote:
> System shutdown may happen with interrupts being disabled and in this case
> I2C core rejects transfers if atomic transfer isn't supported by driver.

Well, not quite. The core complains about it nowadays, but does not
reject messages. It will try the same behaviour as before. It will just
inform the user that somethings is tried which may not work. I probably
should update the error message printed saying that the transfer is
still tried.

> There were several occurrences where I found my Nexus 7 completely
> discharged despite of being turned off and then one day I spotted this in
> the log:

Given my reasoning above, that should have happened before the warning
was printed as well? Because same behaviour. I'd be surprised if there
was a change...


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2020-01-13 22:03 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-12 17:14 [PATCH v4 0/8] NVIDIA Tegra I2C driver fixes and improvements Dmitry Osipenko
2020-01-12 17:14 ` [PATCH v4 2/8] i2c: tegra: Properly disable runtime PM on driver's probe error Dmitry Osipenko
2020-01-12 17:14 ` [PATCH v4 3/8] i2c: tegra: Prevent interrupt triggering after transfer timeout Dmitry Osipenko
2020-01-12 17:14 ` [PATCH v4 4/8] i2c: tegra: Support atomic transfers Dmitry Osipenko
2020-01-13 22:03   ` Wolfram Sang [this message]
2020-01-13 22:52     ` Dmitry Osipenko
2020-01-14  1:26       ` Dmitry Osipenko
2020-01-14  5:57       ` Wolfram Sang
2020-01-12 17:14 ` [PATCH v4 6/8] i2c: tegra: Use relaxed versions of readl/writel Dmitry Osipenko
2020-01-12 17:14 ` [PATCH v4 7/8] i2c: tegra: Always terminate DMA transfer Dmitry Osipenko
     [not found] ` <20200112171430.27219-1-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-01-12 17:14   ` [PATCH v4 1/8] i2c: tegra: Fix suspending in active runtime PM state Dmitry Osipenko
2020-01-12 17:14     ` Dmitry Osipenko
2020-01-12 17:14   ` [PATCH v4 5/8] i2c: tegra: Rename I2C_PIO_MODE_MAX_LEN to I2C_PIO_MODE_PREFERRED_LEN Dmitry Osipenko
2020-01-12 17:14     ` Dmitry Osipenko
2020-01-12 17:14   ` [PATCH v4 8/8] i2c: tegra: Check DMA completion status in addition to left time Dmitry Osipenko
2020-01-12 17:14     ` Dmitry Osipenko
2020-01-13 21:53   ` [PATCH v4 0/8] NVIDIA Tegra I2C driver fixes and improvements Wolfram Sang
2020-01-13 21:53     ` Wolfram Sang
2020-01-13 23:01     ` Dmitry Osipenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200113220315.GB2689@ninjato \
    --to=wsa@the-dreams.de \
    --cc=cyndis@kapsi.fi \
    --cc=digetx@gmail.com \
    --cc=jonathanh@nvidia.com \
    --cc=ldewangan@nvidia.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.