From: Martin Lau <kafai@fb.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [bug report] bpf: Introduce BPF_MAP_TYPE_STRUCT_OPS
Date: Tue, 14 Jan 2020 00:32:35 +0000 [thread overview]
Message-ID: <20200114003232.pmpq3i4jwgfoi6n7@kafai-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <20200113130617.7ecdrglwlmofhvrx@kili.mountain>
On Mon, Jan 13, 2020 at 04:06:17PM +0300, Dan Carpenter wrote:
> Hello Martin KaFai Lau,
>
> The patch 85d33df357b6: "bpf: Introduce BPF_MAP_TYPE_STRUCT_OPS" from
> Jan 8, 2020, leads to the following static checker warning:
>
> kernel/bpf/bpf_struct_ops.c:501 bpf_struct_ops_map_seq_show_elem()
> warn: 'value' is an error pointer or valid
>
> kernel/bpf/bpf_struct_ops.c
> 495 static void bpf_struct_ops_map_seq_show_elem(struct bpf_map *map, void *key,
> 496 struct seq_file *m)
> 497 {
> 498 void *value;
> 499
> 500 value = bpf_struct_ops_map_lookup_elem(map, key);
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> This is just a dummy function that only returns -EINVAL.
Thanks for the report. I will post a fix.
prev parent reply other threads:[~2020-01-14 0:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 13:06 [bug report] bpf: Introduce BPF_MAP_TYPE_STRUCT_OPS Dan Carpenter
2020-01-14 0:32 ` Martin Lau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200114003232.pmpq3i4jwgfoi6n7@kafai-mbp.dhcp.thefacebook.com \
--to=kafai@fb.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.