From mboxrd@z Thu Jan 1 00:00:00 1970 From: Petr Vorel Date: Tue, 14 Jan 2020 09:14:49 +0100 Subject: [LTP] [PATCH v3] syscalls/newmount: new test case for new mount API In-Reply-To: <20200113153141.GA14282@dhcp-12-102.nay.redhat.com> References: <20191209160227.16125-1-zlang@redhat.com> <20191226072338.GH14328@dhcp-12-102.nay.redhat.com> <20200113153141.GA14282@dhcp-12-102.nay.redhat.com> Message-ID: <20200114081449.GB3468@dell5510> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ltp@lists.linux.it Hi Zorro, > > It's been several weeks passed. Is there more review points? > ping again ... is there anything block this patch review? Here are my comments to your v3 review [1]. Some of them are now irrelevant as you're fixed them in v3 (Cyril ones from v1). So it might be just .dev_fs_flags = TST_FS_SKIP_FUSE and tiny style fixes like is_mounted = 0. I wanted to fix them myself and merge, but didn't find a time. Sending v4 where you fix/implement suggestions generally helps speedup merging (as I already told you) :). The real question is whether to merge this before release. I'd like it to be in the release, but it depends on other maintainers opinion. Cyril, Jan, Li? WDYT? Kind regards, Petr [1] https://patchwork.ozlabs.org/patch/1206389/#2333978