From: Wei Liu <wl@xen.org>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: xen-devel@lists.xenproject.org,
Tamas K Lengyel <tamas@tklengyel.com>,
Ian Jackson <ian.jackson@eu.citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [Xen-devel] [PATCH 2/2] Remove undocumented and unmaintained tools/memshr library
Date: Tue, 14 Jan 2020 11:48:46 +0000 [thread overview]
Message-ID: <20200114114846.r6vjosh23asr4gwk@debian> (raw)
In-Reply-To: <0e418ebe-18fb-e76a-21b1-55d35e95fa34@citrix.com>
On Fri, Jan 10, 2020 at 05:59:44PM +0000, Andrew Cooper wrote:
> On 10/01/2020 02:30, Tamas K Lengyel wrote:
> > The library has been largely untouched for over a decade at this point, it is
> > undocumented and it's unclear what it was originally used for. Remove it from
> > tree, if anyone needs it in the future it can be carved out from git history.
> >
> > Signed-off-by: Tamas K Lengyel <tamas@tklengyel.com>
>
> Hmm - this is a little awkward. You remove yourself as maintainer of
> this code, then delete it.
>
> I suspect what you want to do is have patch 1 simply add tools/test
> saying "include other memshr content", and this patch delete
> tools/memshr including the entry in the maintainers file. (Can be fixed
> up on commit of course, seeing as this is the only issue.)
>
> Overall, I agree with the change, but it will need a tools ack.
>
I mostly agree with Tamas' assessment. No point in keeping dead and
unused code in tree.
Acked-by: Wei Liu <wl@xen.org>
Wei.
> ~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2020-01-14 11:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-10 2:30 [Xen-devel] [PATCH 1/2] MAINTAINERS: adjust path of actually maintained memshr code in tools Tamas K Lengyel
2020-01-10 2:30 ` [Xen-devel] [PATCH 2/2] Remove undocumented and unmaintained tools/memshr library Tamas K Lengyel
2020-01-10 17:59 ` Andrew Cooper
2020-01-10 18:40 ` Tamas K Lengyel
2020-01-14 11:48 ` Wei Liu [this message]
2020-01-14 12:00 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200114114846.r6vjosh23asr4gwk@debian \
--to=wl@xen.org \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=tamas@tklengyel.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.