From: Mark Brown <broonie@kernel.org>
To: Rob Herring <robh+dt@kernel.org>
Cc: Saravanan Sekar <sravanhome@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
Maxime Ripard <mripard@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
"heiko@sntech.de" <heiko@sntech.de>,
Sam Ravnborg <sam@ravnborg.org>, Icenowy Zheng <icenowy@aosc.io>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
David Miller <davem@davemloft.net>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 2/4] dt-bindings: regulator: add document bindings for mpq7920
Date: Tue, 14 Jan 2020 12:33:24 +0000 [thread overview]
Message-ID: <20200114123324.GS3897@sirena.org.uk> (raw)
In-Reply-To: <CAL_JsqJ4vTzyfAG2UWzzkhVkBSLDRPjdyDUFZJ9LrDmsFsQ1gA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 803 bytes --]
On Mon, Jan 13, 2020 at 10:56:55AM -0600, Rob Herring wrote:
> On Thu, Jan 9, 2020 at 5:26 AM Saravanan Sekar <sravanhome@gmail.com> wrote:
> > Add device tree binding information for mpq7920 regulator driver.
> > Example bindings for mpq7920 are added.
> Mark, Please revert this. Not even close to valid schema and my
> questions on v4 are unanswered.
OK... I didn't see any comments on V5.
> > + mps,switch-freq:
> As I asked on v4, shouldn't this be a common property? Switching
> frequency is a common property for switching regulators, right?
It's not very common and where it's offered the valid values are
generally highly constrained so I'm not sure it makes sense to do
that, any device that does have this feature will want to specify
the valid values for that particular device.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-01-14 12:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 11:25 [PATCH v6 0/4] Add regulator support for mpq7920 Saravanan Sekar
2020-01-09 11:25 ` [PATCH v6 1/4] dt-bindings: Add an entry for Monolithic Power System, MPS Saravanan Sekar
2020-01-13 17:14 ` Rob Herring
2020-01-14 11:53 ` Mark Brown
2020-01-09 11:25 ` [PATCH v6 2/4] dt-bindings: regulator: add document bindings for mpq7920 Saravanan Sekar
2020-01-13 16:56 ` Rob Herring
2020-01-14 12:33 ` Mark Brown [this message]
2020-01-09 11:25 ` [PATCH v6 3/4] regulator: mpq7920: add mpq7920 regulator driver Saravanan Sekar
2020-01-09 13:28 ` Mark Brown
2020-01-09 18:34 ` saravanan sekar
2020-01-09 19:16 ` Mark Brown
2020-01-09 11:25 ` [PATCH v6 4/4] MAINTAINERS: Add entry for mpq7920 PMIC driver Saravanan Sekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200114123324.GS3897@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=icenowy@aosc.io \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab+samsung@kernel.org \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=shawnguo@kernel.org \
--cc=sravanhome@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.