From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF29EC33CB1 for ; Tue, 14 Jan 2020 15:22:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BCB4D2072B for ; Tue, 14 Jan 2020 15:22:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579015373; bh=9ONsXseL7vnPhow6rBf8Rwy7QYNR2g1suzafCfQHXSk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=UEViNXegbLu1f7iT5n/KvalVSHLs5JQnUaOhdL95I+KhTt3CFJYqNKm3k7ZiXx1Zc a8Kp8TkwM8yIFMXucC38VfdT8F9D7ePLYqra910PF9eNo1jssFGLF4RNBrQ0gO7wGI 0vyzPYGRuqy8HPYG6bTkObeNzlvwrbRahHT58VPI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728755AbgANPWw (ORCPT ); Tue, 14 Jan 2020 10:22:52 -0500 Received: from mail.kernel.org ([198.145.29.99]:39820 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726335AbgANPWw (ORCPT ); Tue, 14 Jan 2020 10:22:52 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5C73E2467D; Tue, 14 Jan 2020 15:22:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579015372; bh=9ONsXseL7vnPhow6rBf8Rwy7QYNR2g1suzafCfQHXSk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XkObdN6QZyL7qMxqhY0CAJQQ0sjY3N8DpwRxUhEzAeC7xnJ3/Iug79uQYo3uwuU2F ogbuVetlDLA9ETMJDdIEW15hjtaUpveO5gU2AkrPMIAtSFZQV0xcfV5k0D+TnjJay5 w4tfgTsqJb8Rc02Ry5a8qZSK7Y8zwKKeTusf244A= Date: Tue, 14 Jan 2020 16:22:49 +0100 From: Greg Kroah-Hartman To: Martin Fuzzey Cc: Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Christian Brauner , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] binder: fix log spam for existing debugfs file creation. Message-ID: <20200114152249.GA2041689@kroah.com> References: <1578671054-5982-1-git-send-email-martin.fuzzey@flowbird.group> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1578671054-5982-1-git-send-email-martin.fuzzey@flowbird.group> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 10, 2020 at 04:44:01PM +0100, Martin Fuzzey wrote: > Since commit 43e23b6c0b01 ("debugfs: log errors when something goes wrong") > debugfs logs attempts to create existing files. > > However binder attempts to create multiple debugfs files with > the same name when a single PID has multiple contexts, this leads > to log spamming during an Android boot (17 such messages during > boot on my system). > > Fix this by checking if we already know the PID and only create > the debugfs entry for the first context per PID. > > Do the same thing for binderfs for symmetry. > > Signed-off-by: Martin Fuzzey Does this need a "Fixes:" and cc: stable tag? And it would be good to get a review from the binder maintainer(s) to see if this is sane or not... thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F704C33CB1 for ; Tue, 14 Jan 2020 15:23:03 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 113962072B for ; Tue, 14 Jan 2020 15:23:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="XkObdN6Q" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 113962072B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id D40E084115; Tue, 14 Jan 2020 15:23:02 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6l9y1AshuGIB; Tue, 14 Jan 2020 15:22:58 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 592808489F; Tue, 14 Jan 2020 15:22:58 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 1594B1BF574 for ; Tue, 14 Jan 2020 15:22:57 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 0FB7184ADE for ; Tue, 14 Jan 2020 15:22:57 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EqfFZoT70Rq9 for ; Tue, 14 Jan 2020 15:22:52 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by hemlock.osuosl.org (Postfix) with ESMTPS id 29689820C9 for ; Tue, 14 Jan 2020 15:22:52 +0000 (UTC) Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5C73E2467D; Tue, 14 Jan 2020 15:22:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579015372; bh=9ONsXseL7vnPhow6rBf8Rwy7QYNR2g1suzafCfQHXSk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XkObdN6QZyL7qMxqhY0CAJQQ0sjY3N8DpwRxUhEzAeC7xnJ3/Iug79uQYo3uwuU2F ogbuVetlDLA9ETMJDdIEW15hjtaUpveO5gU2AkrPMIAtSFZQV0xcfV5k0D+TnjJay5 w4tfgTsqJb8Rc02Ry5a8qZSK7Y8zwKKeTusf244A= Date: Tue, 14 Jan 2020 16:22:49 +0100 From: Greg Kroah-Hartman To: Martin Fuzzey Subject: Re: [PATCH] binder: fix log spam for existing debugfs file creation. Message-ID: <20200114152249.GA2041689@kroah.com> References: <1578671054-5982-1-git-send-email-martin.fuzzey@flowbird.group> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1578671054-5982-1-git-send-email-martin.fuzzey@flowbird.group> X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Todd Kjos , linux-kernel@vger.kernel.org, Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Joel Fernandes , Martijn Coenen , Christian Brauner Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Fri, Jan 10, 2020 at 04:44:01PM +0100, Martin Fuzzey wrote: > Since commit 43e23b6c0b01 ("debugfs: log errors when something goes wrong") > debugfs logs attempts to create existing files. > > However binder attempts to create multiple debugfs files with > the same name when a single PID has multiple contexts, this leads > to log spamming during an Android boot (17 such messages during > boot on my system). > > Fix this by checking if we already know the PID and only create > the debugfs entry for the first context per PID. > > Do the same thing for binderfs for symmetry. > > Signed-off-by: Martin Fuzzey Does this need a "Fixes:" and cc: stable tag? And it would be good to get a review from the binder maintainer(s) to see if this is sane or not... thanks, greg k-h _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel