All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Jiri Olsa <jolsa@kernel.org>
Cc: Ravi Bangoria <ravi.bangoria@linux.ibm.com>,
	lkml <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Michael Petlan <mpetlan@redhat.com>,
	Jelle van der Waa <jelle@vdwaa.nl>
Subject: Re: [PATCH 2/2] perf/ui/gtk: Fix gtk2 build
Date: Tue, 14 Jan 2020 12:41:25 -0300	[thread overview]
Message-ID: <20200114154125.GB20569@kernel.org> (raw)
In-Reply-To: <20200113104358.123511-2-jolsa@kernel.org>

Em Mon, Jan 13, 2020 at 11:43:58AM +0100, Jiri Olsa escreveu:
> Ravi Bangoria reported issue when detecting gtk2 on Fedora 31,
> where some types got deprecated:
> 
>   /usr/include/gtk-2.0/gtk/gtktypeutils.h:236:1: error: ‘GTypeDebugFlags’ is deprecated [-Werror=deprecated-declarations]
>     236 | void            gtk_type_init   (GTypeDebugFlags    debug_flags);
> 
> Fixing this for perf by allowing the compile to pass
> with deprecated symbols via -Wno-deprecated-declarations.

Thanks, applied.

- Arnaldo
 
> Reported-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
> Tested-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
> Link: https://lkml.kernel.org/n/tip-kg8fqsa0bgq3suc9ubonh4xu@git.kernel.org
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> ---
>  tools/build/feature/Makefile | 2 +-
>  tools/perf/ui/gtk/Build      | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/build/feature/Makefile b/tools/build/feature/Makefile
> index f30a89046aa3..7ac0d8088565 100644
> --- a/tools/build/feature/Makefile
> +++ b/tools/build/feature/Makefile
> @@ -197,7 +197,7 @@ $(OUTPUT)test-libcrypto.bin:
>  	$(BUILD) -lcrypto
>  
>  $(OUTPUT)test-gtk2.bin:
> -	$(BUILD) $(shell $(PKG_CONFIG) --libs --cflags gtk+-2.0 2>/dev/null)
> +	$(BUILD) $(shell $(PKG_CONFIG) --libs --cflags gtk+-2.0 2>/dev/null) -Wno-deprecated-declarations
>  
>  $(OUTPUT)test-gtk2-infobar.bin:
>  	$(BUILD) $(shell $(PKG_CONFIG) --libs --cflags gtk+-2.0 2>/dev/null)
> diff --git a/tools/perf/ui/gtk/Build b/tools/perf/ui/gtk/Build
> index 9b5d5cbb7af7..eef708c502f4 100644
> --- a/tools/perf/ui/gtk/Build
> +++ b/tools/perf/ui/gtk/Build
> @@ -1,4 +1,4 @@
> -CFLAGS_gtk += -fPIC $(GTK_CFLAGS)
> +CFLAGS_gtk += -fPIC $(GTK_CFLAGS) -Wno-deprecated-declarations
>  
>  gtk-y += browser.o
>  gtk-y += hists.o
> -- 
> 2.24.1
> 

-- 

- Arnaldo

  reply	other threads:[~2020-01-14 15:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-13 10:43 [PATCH 1/2] perf/ui/gtk: Add missing zalloc object Jiri Olsa
2020-01-13 10:43 ` [PATCH 2/2] perf/ui/gtk: Fix gtk2 build Jiri Olsa
2020-01-14 15:41   ` Arnaldo Carvalho de Melo [this message]
2020-01-20  8:27   ` [tip: perf/core] " tip-bot2 for Jiri Olsa
2020-01-14 15:25 ` [PATCH 1/2] perf/ui/gtk: Add missing zalloc object Arnaldo Carvalho de Melo
2020-01-20  8:27 ` [tip: perf/core] perf ui gtk: " tip-bot2 for Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200114154125.GB20569@kernel.org \
    --to=arnaldo.melo@gmail.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=jelle@vdwaa.nl \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=mpetlan@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=ravi.bangoria@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.