From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E503C33C9E for ; Tue, 14 Jan 2020 16:18:03 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id CA1A624655 for ; Tue, 14 Jan 2020 16:18:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CA1A624655 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1D9E01BFCC; Tue, 14 Jan 2020 17:18:01 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 747AD1BFA3 for ; Tue, 14 Jan 2020 17:17:59 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Jan 2020 08:17:58 -0800 X-IronPort-AV: E=Sophos;i="5.69,433,1571727600"; d="scan'208";a="225586488" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.26]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 14 Jan 2020 08:17:56 -0800 Date: Tue, 14 Jan 2020 16:17:53 +0000 From: Bruce Richardson To: David Marchand Cc: "Mcnamara, John" , Luca Boccassi , dev , Aaron Conole , Thomas Monjalon Message-ID: <20200114161753.GA1660@bricha3-MOBL.ger.corp.intel.com> References: <20200109115631.500056-1-bruce.richardson@intel.com> <20200110215205.513185-1-bruce.richardson@intel.com> <20200110215205.513185-6-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Subject: Re: [dpdk-dev] [PATCH v4 5/6] doc/guides: rebuild with meson whenever a file changes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jan 14, 2020 at 04:59:24PM +0100, David Marchand wrote: > On Fri, Jan 10, 2020 at 10:52 PM Bruce Richardson > wrote: > > > > Add proper support for calling sphinx whenever a file in the doc > > directory changes. This is accomplished by using a wrapper script > > for sphinx, which runs sphinx but also emits a gcc-format dependency > > file listing all the doc files. This is used by ninja so that any > > change to the doc files triggers a rebuild of the docs. > > > > Signed-off-by: Bruce Richardson > > Acked-by: Aaron Conole > > Acked-by: Luca Boccassi > > --- > > MAINTAINERS | 1 + > > buildtools/call-sphinx-build.py | 31 +++++++++++++++++++++++++++++++ > > buildtools/meson.build | 6 ++++-- > > doc/guides/meson.build | 22 ++++++++-------------- > > 4 files changed, 44 insertions(+), 16 deletions(-) > > create mode 100755 buildtools/call-sphinx-build.py > > Caught an issue on fc30: > > [2094/2338] Generating html_guides with a custom command. > FAILED: doc/guides/html > /usr/bin/python3 ../../dpdk/buildtools/call-sphinx-build.py > /usr/libexec/python2-sphinx/sphinx-build > /home/dmarchan/dpdk/doc/guides > /home/dmarchan/builds/build-x86-default/doc/guides > sphinx-build 1.8.4 > Traceback (most recent call last): > File "../../dpdk/buildtools/call-sphinx-build.py", line 15, in > ver = run([sphinx, '--version'], stdout=PIPE).stdout.decode().split()[-1] > IndexError: list index out of range > > Double checked, the version went to stderr: > > $ sphinx-build --version >/dev/null > sphinx-build 1.8.4 > $ sphinx-build --version 2>/dev/null > That is strange. Didn't hit any issues on fedora 31 which I am using here. I'll see if I can make it work with both stderr and stdout reporting. /Bruce