From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97138C33C9E for ; Tue, 14 Jan 2020 16:37:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5DF842053B for ; Tue, 14 Jan 2020 16:37:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="tnFM93Uq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728516AbgANQhD (ORCPT ); Tue, 14 Jan 2020 11:37:03 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:56522 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726121AbgANQhC (ORCPT ); Tue, 14 Jan 2020 11:37:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=bJVaCxrwr35SB36/aaUlnDWktHBHuj0zzwzpoSHUEtA=; b=tnFM93Uqm/bykCKgamD0hnO71 XP1CdKWoB/HK8TuWpqMrQ0x7QXiwnq7GRhtz7bqqa8ph2tOVP64c/qJ6FV+NNEhibNfzlJ33o0my8 VFd/lvz/GQXoMFth57L1AqL+pZVlnWS8Z3Ozg/aeGbg+dfe+s77cZ1CBC5BisFCpAWWkF/XtHTzFy ouDrykJY4LPC1t5d0q3LfuY3KYUom7mhZThvlRNIq1BNCTSiGZNca3erHg1roAp0Td5NKBAa8KXlG uXMpsG4rgoHZHlve0dkxHtZFQnYtt/4gOPp3SVqzW+WCR5IUkPImENsEHHkHssABcRNYUE1g/Dc/j XX3jgrXHQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1irPBe-00037l-Hn; Tue, 14 Jan 2020 16:37:02 +0000 Date: Tue, 14 Jan 2020 08:37:02 -0800 From: Christoph Hellwig To: Ritesh Harjani Cc: linux-ext4@vger.kernel.org, tytso@mit.edu, jack@suse.cz Subject: Re: [RFC 1/2] iomap: direct-io: Move inode_dio_begin before filemap_write_and_wait_range Message-ID: <20200114163702.GA7127@infradead.org> References: <27607a16327fe9664f32d09abe565af0d1ae56c9.1578907891.git.riteshh@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <27607a16327fe9664f32d09abe565af0d1ae56c9.1578907891.git.riteshh@linux.ibm.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Please add at very least the fsdevel and xfs lists to iomap patches. Using i_dio_count for any kind of detection is bogus. If you want to pass flags to the writeback code please do so explicitly through struct writeback_control.