From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBAC6C33CB3 for ; Wed, 15 Jan 2020 00:05:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A5AF624671 for ; Wed, 15 Jan 2020 00:05:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579046706; bh=cz2UztP9MJAh6C7mWthND8FqaSKP4f7N8ChaD25u+i4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Xz8Pd8WCTPUq/uFBOJ0FH27xfO7IpP7/UVDPXPeqq2khgZodoOitVfw9jUrJoxNlS P3DohzQp+Tc98BPgXfE53KFbReVMFu5ned6inV2Y+E7RsNEWc5tuRxNsBKh3Qp7eSc zNvEIqvAct4tZwDkIucRH+hGLxfMPyO0ACgYLnXs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726495AbgAOAFG (ORCPT ); Tue, 14 Jan 2020 19:05:06 -0500 Received: from mail-ot1-f68.google.com ([209.85.210.68]:32800 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728757AbgAOAFG (ORCPT ); Tue, 14 Jan 2020 19:05:06 -0500 Received: by mail-ot1-f68.google.com with SMTP id b18so14531047otp.0 for ; Tue, 14 Jan 2020 16:05:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=6InMAA6tVFUJhW/7SSG7pRmKfUrz13sPRb9GJnKNkk8=; b=rH7nhw/ihGP4+jjBwcFKqN+deqBcYuTBxWz4LcujR68XunfWI7fJqNdBGKa62T7fFK wqNqyAkgX//KZk9tc6vc77s6IWqqyFPro2mCy/v1Q4LFcNDQXRzGU5dsr/tByeC8q8Cg qPnbivhHRW91IxfNOjrh6V7CCOrnmUXCtaRmVqKvjMmzJWWpq2jQHzk6GCLjVbHUvZzc sIoCP6/KisCJpTHN9McYDVunShd90mIQ5Yq869HiuFh2ZY0MoB67GGyX/dvCqn3bz3ev 5yKcLpkWqms/4wtkfb43/Ozx2mmJ+8aTkGulqfzomBeUxKacZMnkur3lomknGOhkPRV5 ffxg== X-Gm-Message-State: APjAAAVfzxsmRxQ86H+VbThGhFms4f8PUveiVjtPR2ieR4587r7jXAwF xcw7C3wg13n1iyDAkAc9UeYtzPc= X-Google-Smtp-Source: APXvYqwD9B+/LAJ9lE4TVXz8+lz0YNqGuVy3Gj2QgQkyy5LutIPuKjvz7cQ/ldGA9KktQCsqtv3pLQ== X-Received: by 2002:a9d:7b4a:: with SMTP id f10mr829942oto.4.1579046704405; Tue, 14 Jan 2020 16:05:04 -0800 (PST) Received: from rob-hp-laptop (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id l13sm5916577otq.78.2020.01.14.16.05.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jan 2020 16:05:03 -0800 (PST) Received: from rob (uid 1000) (envelope-from rob@rob-hp-laptop) id 220a2e by rob-hp-laptop (DragonFly Mail Agent v0.11); Tue, 14 Jan 2020 18:05:02 -0600 Date: Tue, 14 Jan 2020 18:05:02 -0600 From: Rob Herring To: Shawn Lin Cc: Heiko Stuebner , Lorenzo Pieralisi , Kishon Vijay Abraham I , Bjorn Helgaas , Jingoo Han , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, William Wu , Simon Xue , linux-rockchip@lists.infradead.org Subject: Re: [PATCH 4/6] dt-bindings: rockchip: Add DesignWare based PCIe controller Message-ID: <20200115000502.GA27530@bogus> References: <1578986580-71974-1-git-send-email-shawn.lin@rock-chips.com> <1578986580-71974-5-git-send-email-shawn.lin@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1578986580-71974-5-git-send-email-shawn.lin@rock-chips.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Jan 14, 2020 at 03:22:58PM +0800, Shawn Lin wrote: > From: Simon Xue > > Signed-off-by: Simon Xue > Signed-off-by: Shawn Lin > --- > > .../devicetree/bindings/pci/rockchip-dw-pcie.yaml | 132 +++++++++++++++++++++ > 1 file changed, 132 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml: properties:rockchip,usbpciegrf: {'items': [{'description': 'The grf for COMBPHY configuration and state registers.'}]} is not valid under any of the given schemas (Possible causes of the failure): /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml: properties:rockchip,usbpciegrf: 'description' is a required property > > diff --git a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml > new file mode 100644 > index 0000000..c5205f6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml > @@ -0,0 +1,132 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pci/rockchip-dw-pcie.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: DesignWare based PCIe RC controller on Rockchip SoCs > + > +maintainers: > + - Shawn Lin > + - Simon Xue indent 2 spaces. > + You need to reference pci-bus.yaml. > +properties: > + compatible: > + enum: > + - rockchip,rk1808-pcie > + - snps,dw-pcie This means the compatible is one of these 2 strings. It's also going to be a problem because it will match on all DTs with 'snps,dw-pcie'. Look at some of the 'arm,primecell' schema for how to avoid that with 'select'. > + > + reg: > + maxItems: 2 > + > + clocks: > + items: > + - description: High speed clock for PCIe > + - description: Low speed clock for PCIe > + - description: AHB clock for PCIe > + - description: APB clock for PCIe > + - description: Auxiliary clock for PCIe > + > + clock-names: > + items: > + - const: hsclk > + - const: lsclk > + - const: aclk > + - const: pclk > + - const: sclk-aux > + > + resets: > + items: > + - description: PCIe niu high reset line > + - description: PCIe niu low reset line > + - description: PCIe grf reset line > + - description: PCIe control reset line > + - description: PCIe control powerup reset line > + - description: PCIe control master reset line > + - description: PCIe control slave reset line > + - description: PCIe control dbi reset line > + - description: PCIe control button reset line > + - description: PCIe control power engine reset line > + - description: PCIe control core reset line > + - description: PCIe control non-sticky reset line > + - description: PCIe control sticky reset line > + - description: PCIe control power reset line > + - description: PCIe niu ahb reset line > + - description: PCIe niu apb reset line > + > + reset-names: > + items: > + - const: niu-h > + - const: niu-l > + - const: grf-p > + - const: ctl-p > + - const: ctl-powerup > + - const: ctl-mst-a > + - const: ctl-slv-a > + - const: ctl-dbi-a > + - const: ctl-button > + - const: ctl-pe > + - const: ctl-core > + - const: ctl-nsticky > + - const: ctl-sticky > + - const: ctl-pwr > + - const: ctl-niu-a > + - const: ctl-niu-p > + > + rockchip,usbpciegrf: > + items: > + - description: The grf for COMBPHY configuration and state registers. > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - msi-map > + - num-lanes > + - phys > + - phy-names > + - resets > + - reset-names > + - rockchip,usbpciegrf > + > +additionalProperties: false > + > +examples: > + - | > + usb_pcie_grf: syscon@fe040000 { > + compatible = "rockchip,usb-pcie-grf", "syscon"; > + reg = <0x0 0xfe040000 0x0 0x1000>; > + }; > + > + pcie0: pcie@fc400000 { > + compatible = "rockchip,rk1808-pcie", "snps,dw-pcie"; > + reg = <0x0 0xfc000000 0x0 0x400000>, > + <0x0 0xfc400000 0x0 0x10000>; > + clocks = <&cru HSCLK_PCIE>, <&cru LSCLK_PCIE>, > + <&cru ACLK_PCIE>, <&cru PCLK_PCIE>, > + <&cru SCLK_PCIE_AUX>; > + clock-names = "hsclk", "lsclk", > + "aclk", "pclk", > + "sclk-aux"; > + msi-map = <0x0 &its 0x0 0x1000>; > + num-lanes = <2>; > + phys = <&combphy PHY_TYPE_PCIE>; > + phy-names = "pcie-phy"; > + resets = <&cru SRST_PCIE_NIU_H>, <&cru SRST_PCIE_NIU_L>, > + <&cru SRST_PCIEGRF_P>, <&cru SRST_PCIECTL_P>, > + <&cru SRST_PCIECTL_POWERUP>, <&cru SRST_PCIECTL_MST_A>, > + <&cru SRST_PCIECTL_SLV_A>, <&cru SRST_PCIECTL_DBI_A>, > + <&cru SRST_PCIECTL_BUTTON>, <&cru SRST_PCIECTL_PE>, > + <&cru SRST_PCIECTL_CORE>, <&cru SRST_PCIECTL_NSTICKY>, > + <&cru SRST_PCIECTL_STICKY>, <&cru SRST_PCIECTL_PWR>, > + <&cru SRST_PCIE_NIU_A>, <&cru SRST_PCIE_NIU_P>; > + reset-names = "niu-h", "niu-l", "grf-p", "ctl-p", > + "ctl-powerup", "ctl-mst-a", "ctl-slv-a", > + "ctl-dbi-a", "ctl-button", "ctl-pe", > + "ctl-core", "ctl-nsticky", "ctl-sticky", > + "ctl-pwr", "ctl-niu-a", "ctl-niu-p"; > + rockchip,usbpciegrf = <&usb_pcie_grf>; You are missing a number of common, required PCI properties. > + }; > + > +... > -- > 1.9.1 > > >