From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC2E9C33CB1 for ; Wed, 15 Jan 2020 07:47:32 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9190624655 for ; Wed, 15 Jan 2020 07:47:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9190624655 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kaod.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50646 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1irdOl-0006tU-N2 for qemu-devel@archiver.kernel.org; Wed, 15 Jan 2020 02:47:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41074) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1irdO5-0005bQ-BN for qemu-devel@nongnu.org; Wed, 15 Jan 2020 02:46:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1irdO1-0000ax-Ot for qemu-devel@nongnu.org; Wed, 15 Jan 2020 02:46:49 -0500 Received: from 3.mo173.mail-out.ovh.net ([46.105.34.1]:56428) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1irdO1-0000ZJ-Ig for qemu-devel@nongnu.org; Wed, 15 Jan 2020 02:46:45 -0500 Received: from player774.ha.ovh.net (unknown [10.108.16.135]) by mo173.mail-out.ovh.net (Postfix) with ESMTP id 2EAC212A8F1 for ; Wed, 15 Jan 2020 08:46:42 +0100 (CET) Received: from kaod.org (lns-bzn-46-82-253-208-248.adsl.proxad.net [82.253.208.248]) (Authenticated sender: groug@kaod.org) by player774.ha.ovh.net (Postfix) with ESMTPSA id 794D1E4CF170; Wed, 15 Jan 2020 07:46:22 +0000 (UTC) Date: Wed, 15 Jan 2020 08:46:21 +0100 From: Greg Kurz To: Vladimir Sementsov-Ogievskiy Subject: Re: [PATCH v6 01/11] qapi/error: add (Error **errp) cleaning APIs Message-ID: <20200115084621.5f8d1b10@bahia.lan> In-Reply-To: <20200110194158.14190-2-vsementsov@virtuozzo.com> References: <20200110194158.14190-1-vsementsov@virtuozzo.com> <20200110194158.14190-2-vsementsov@virtuozzo.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Ovh-Tracer-Id: 14078815388168395091 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedugedrtddvgdduudduucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffhvffukfgjfhfogggtgfesthhqredtredtjeenucfhrhhomhepifhrvghgucfmuhhriicuoehgrhhouhhgsehkrghougdrohhrgheqnecukfhppedtrddtrddtrddtpdekvddrvdehfedrvddtkedrvdegkeenucfrrghrrghmpehmohguvgepshhmthhpqdhouhhtpdhhvghlohepphhlrgihvghrjeejgedrhhgrrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpehgrhhouhhgsehkrghougdrohhrghdprhgtphhtthhopehqvghmuhdquggvvhgvlhesnhhonhhgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptd X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 46.105.34.1 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Stefano Stabellini , Laszlo Ersek , qemu-block@nongnu.org, Paul Durrant , Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= , Cornelia Huck , qemu-devel@nongnu.org, Max Reitz , Gerd Hoffmann , Stefan Hajnoczi , Anthony Perard , xen-devel@lists.xenproject.org, Michael Roth , Markus Armbruster , Stefan Berger Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 10 Jan 2020 22:41:48 +0300 Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- >=20 Reviewed-by: Greg Kurz > CC: Cornelia Huck > CC: Eric Blake > CC: Kevin Wolf > CC: Max Reitz > CC: Greg Kurz > CC: Stefan Hajnoczi > CC: Stefano Stabellini > CC: Anthony Perard > CC: Paul Durrant > CC: "Philippe Mathieu-Daud=C3=A9" > CC: Laszlo Ersek > CC: Gerd Hoffmann > CC: Stefan Berger > CC: Markus Armbruster > CC: Michael Roth > CC: qemu-block@nongnu.org > CC: xen-devel@lists.xenproject.org >=20 > include/qapi/error.h | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) >=20 > diff --git a/include/qapi/error.h b/include/qapi/error.h > index ad5b6e896d..fa8d51fd6d 100644 > --- a/include/qapi/error.h > +++ b/include/qapi/error.h > @@ -309,6 +309,32 @@ void warn_reportf_err(Error *err, const char *fmt, .= ..) > void error_reportf_err(Error *err, const char *fmt, ...) > GCC_FMT_ATTR(2, 3); > =20 > +/* > + * Functions to clean Error **errp: call corresponding Error *err cleani= ng > + * function an set pointer to NULL > + */ > +static inline void error_free_errp(Error **errp) > +{ > + assert(errp && *errp); > + error_free(*errp); > + *errp =3D NULL; > +} > + > +static inline void error_report_errp(Error **errp) > +{ > + assert(errp && *errp); > + error_report_err(*errp); > + *errp =3D NULL; > +} > + > +static inline void warn_report_errp(Error **errp) > +{ > + assert(errp && *errp); > + warn_report_err(*errp); > + *errp =3D NULL; > +} > + > + > /* > * Just like error_setg(), except you get to specify the error class. > * Note: use of error classes other than ERROR_CLASS_GENERIC_ERROR is From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D0BCC33CB1 for ; Wed, 15 Jan 2020 07:47:12 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EBBA024655 for ; Wed, 15 Jan 2020 07:47:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EBBA024655 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kaod.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1irdO4-0005Po-Kd; Wed, 15 Jan 2020 07:46:48 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1irdO2-0005Pj-Uk for xen-devel@lists.xenproject.org; Wed, 15 Jan 2020 07:46:46 +0000 X-Inumbo-ID: 2cade94e-376b-11ea-84e2-12813bfff9fa Received: from 7.mo173.mail-out.ovh.net (unknown [46.105.44.159]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 2cade94e-376b-11ea-84e2-12813bfff9fa; Wed, 15 Jan 2020 07:46:44 +0000 (UTC) Received: from player774.ha.ovh.net (unknown [10.109.143.18]) by mo173.mail-out.ovh.net (Postfix) with ESMTP id 6CDB412C688 for ; Wed, 15 Jan 2020 08:46:43 +0100 (CET) Received: from kaod.org (lns-bzn-46-82-253-208-248.adsl.proxad.net [82.253.208.248]) (Authenticated sender: groug@kaod.org) by player774.ha.ovh.net (Postfix) with ESMTPSA id 794D1E4CF170; Wed, 15 Jan 2020 07:46:22 +0000 (UTC) Date: Wed, 15 Jan 2020 08:46:21 +0100 From: Greg Kurz To: Vladimir Sementsov-Ogievskiy Message-ID: <20200115084621.5f8d1b10@bahia.lan> In-Reply-To: <20200110194158.14190-2-vsementsov@virtuozzo.com> References: <20200110194158.14190-1-vsementsov@virtuozzo.com> <20200110194158.14190-2-vsementsov@virtuozzo.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-Ovh-Tracer-Id: 14078815388168395091 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedugedrtddvgdduudduucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffhvffukfgjfhfogggtgfesthhqredtredtjeenucfhrhhomhepifhrvghgucfmuhhriicuoehgrhhouhhgsehkrghougdrohhrgheqnecukfhppedtrddtrddtrddtpdekvddrvdehfedrvddtkedrvdegkeenucfrrghrrghmpehmohguvgepshhmthhpqdhouhhtpdhhvghlohepphhlrgihvghrjeejgedrhhgrrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpehgrhhouhhgsehkrghougdrohhrghdprhgtphhtthhopeigvghnqdguvghvvghlsehlihhsthhsrdigvghnphhrohhjvggtthdrohhrghenucevlhhushhtvghrufhiiigvpedt Subject: Re: [Xen-devel] [PATCH v6 01/11] qapi/error: add (Error **errp) cleaning APIs X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Stefano Stabellini , Laszlo Ersek , qemu-block@nongnu.org, Paul Durrant , Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= , Cornelia Huck , qemu-devel@nongnu.org, Max Reitz , Gerd Hoffmann , Stefan Hajnoczi , Anthony Perard , xen-devel@lists.xenproject.org, Eric Blake , Michael Roth , Markus Armbruster , Stefan Berger Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" T24gRnJpLCAxMCBKYW4gMjAyMCAyMjo0MTo0OCArMDMwMApWbGFkaW1pciBTZW1lbnRzb3YtT2dp ZXZza2l5IDx2c2VtZW50c292QHZpcnR1b3p6by5jb20+IHdyb3RlOgoKPiBTaWduZWQtb2ZmLWJ5 OiBWbGFkaW1pciBTZW1lbnRzb3YtT2dpZXZza2l5IDx2c2VtZW50c292QHZpcnR1b3p6by5jb20+ Cj4gLS0tCj4gCgpSZXZpZXdlZC1ieTogR3JlZyBLdXJ6IDxncm91Z0BrYW9kLm9yZz4KCj4gQ0M6 IENvcm5lbGlhIEh1Y2sgPGNvaHVja0ByZWRoYXQuY29tPgo+IENDOiBFcmljIEJsYWtlIDxlYmxh a2VAcmVkaGF0LmNvbT4KPiBDQzogS2V2aW4gV29sZiA8a3dvbGZAcmVkaGF0LmNvbT4KPiBDQzog TWF4IFJlaXR6IDxtcmVpdHpAcmVkaGF0LmNvbT4KPiBDQzogR3JlZyBLdXJ6IDxncm91Z0BrYW9k Lm9yZz4KPiBDQzogU3RlZmFuIEhham5vY3ppIDxzdGVmYW5oYUByZWRoYXQuY29tPgo+IENDOiBT dGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+Cj4gQ0M6IEFudGhvbnkg UGVyYXJkIDxhbnRob255LnBlcmFyZEBjaXRyaXguY29tPgo+IENDOiBQYXVsIER1cnJhbnQgPHBh dWxAeGVuLm9yZz4KPiBDQzogIlBoaWxpcHBlIE1hdGhpZXUtRGF1ZMOpIiA8cGhpbG1kQHJlZGhh dC5jb20+Cj4gQ0M6IExhc3psbyBFcnNlayA8bGVyc2VrQHJlZGhhdC5jb20+Cj4gQ0M6IEdlcmQg SG9mZm1hbm4gPGtyYXhlbEByZWRoYXQuY29tPgo+IENDOiBTdGVmYW4gQmVyZ2VyIDxzdGVmYW5i QGxpbnV4LmlibS5jb20+Cj4gQ0M6IE1hcmt1cyBBcm1icnVzdGVyIDxhcm1icnVAcmVkaGF0LmNv bT4KPiBDQzogTWljaGFlbCBSb3RoIDxtZHJvdGhAbGludXgudm5ldC5pYm0uY29tPgo+IENDOiBx ZW11LWJsb2NrQG5vbmdudS5vcmcKPiBDQzogeGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3Jn Cj4gCj4gIGluY2x1ZGUvcWFwaS9lcnJvci5oIHwgMjYgKysrKysrKysrKysrKysrKysrKysrKysr KysKPiAgMSBmaWxlIGNoYW5nZWQsIDI2IGluc2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEv aW5jbHVkZS9xYXBpL2Vycm9yLmggYi9pbmNsdWRlL3FhcGkvZXJyb3IuaAo+IGluZGV4IGFkNWI2 ZTg5NmQuLmZhOGQ1MWZkNmQgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS9xYXBpL2Vycm9yLmgKPiAr KysgYi9pbmNsdWRlL3FhcGkvZXJyb3IuaAo+IEBAIC0zMDksNiArMzA5LDMyIEBAIHZvaWQgd2Fy bl9yZXBvcnRmX2VycihFcnJvciAqZXJyLCBjb25zdCBjaGFyICpmbXQsIC4uLikKPiAgdm9pZCBl cnJvcl9yZXBvcnRmX2VycihFcnJvciAqZXJyLCBjb25zdCBjaGFyICpmbXQsIC4uLikKPiAgICAg IEdDQ19GTVRfQVRUUigyLCAzKTsKPiAgCj4gKy8qCj4gKyAqIEZ1bmN0aW9ucyB0byBjbGVhbiBF cnJvciAqKmVycnA6IGNhbGwgY29ycmVzcG9uZGluZyBFcnJvciAqZXJyIGNsZWFuaW5nCj4gKyAq IGZ1bmN0aW9uIGFuIHNldCBwb2ludGVyIHRvIE5VTEwKPiArICovCj4gK3N0YXRpYyBpbmxpbmUg dm9pZCBlcnJvcl9mcmVlX2VycnAoRXJyb3IgKiplcnJwKQo+ICt7Cj4gKyAgICBhc3NlcnQoZXJy cCAmJiAqZXJycCk7Cj4gKyAgICBlcnJvcl9mcmVlKCplcnJwKTsKPiArICAgICplcnJwID0gTlVM TDsKPiArfQo+ICsKPiArc3RhdGljIGlubGluZSB2b2lkIGVycm9yX3JlcG9ydF9lcnJwKEVycm9y ICoqZXJycCkKPiArewo+ICsgICAgYXNzZXJ0KGVycnAgJiYgKmVycnApOwo+ICsgICAgZXJyb3Jf cmVwb3J0X2VycigqZXJycCk7Cj4gKyAgICAqZXJycCA9IE5VTEw7Cj4gK30KPiArCj4gK3N0YXRp YyBpbmxpbmUgdm9pZCB3YXJuX3JlcG9ydF9lcnJwKEVycm9yICoqZXJycCkKPiArewo+ICsgICAg YXNzZXJ0KGVycnAgJiYgKmVycnApOwo+ICsgICAgd2Fybl9yZXBvcnRfZXJyKCplcnJwKTsKPiAr ICAgICplcnJwID0gTlVMTDsKPiArfQo+ICsKPiArCj4gIC8qCj4gICAqIEp1c3QgbGlrZSBlcnJv cl9zZXRnKCksIGV4Y2VwdCB5b3UgZ2V0IHRvIHNwZWNpZnkgdGhlIGVycm9yIGNsYXNzLgo+ICAg KiBOb3RlOiB1c2Ugb2YgZXJyb3IgY2xhc3NlcyBvdGhlciB0aGFuIEVSUk9SX0NMQVNTX0dFTkVS SUNfRVJST1IgaXMKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9y ZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs