From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 122BAC33CB2 for ; Wed, 15 Jan 2020 13:40:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D1CC324656 for ; Wed, 15 Jan 2020 13:40:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579095617; bh=vq7dWZIt2uzMmU//MJnDRlhzag57tdT+vRJG617udFk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=QoppMseHWLueuQBPPOCfoeMOtBfHCwwWlo0xxw59uoe+x9chlpZLKep6Il6RQ9yER SYSlvw6IOK2px7nGwT9c2Qw5gif46+0/f13aT2KPkE7rnxogXO+A4hEPMKjh6PJVHq j8PCfQFS8aeqlX8PzSFcN7X2Z355EM5+R5FivD04= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728977AbgAONkO (ORCPT ); Wed, 15 Jan 2020 08:40:14 -0500 Received: from mail.kernel.org ([198.145.29.99]:51314 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726071AbgAONkN (ORCPT ); Wed, 15 Jan 2020 08:40:13 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5FF6B207FF; Wed, 15 Jan 2020 13:40:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579095613; bh=vq7dWZIt2uzMmU//MJnDRlhzag57tdT+vRJG617udFk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pAuyIq2GysfG9S3GlghWZ6CQmBaqtmrJezPEwteygMOKNCDLyRE8eXRMflMeiWvza ufxC+sjMlz+9DD3PZkDbc0BoAThgdsDIQNqRr1tk8EOCy/UIhVDW5o/9iA2wj0sGcO xXVuV696c5E89sRBN9ayELZBHVGuO9qzKoEW1wI8= Date: Wed, 15 Jan 2020 14:40:10 +0100 From: Greg Kroah-Hartman To: =?iso-8859-1?B?Suly9G1l?= Pouiller Cc: "devel@driverdev.osuosl.org" , "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "David S . Miller" , Kalle Valo Subject: Re: [PATCH 00/65] Simplify and improve the wfx driver Message-ID: <20200115134010.GA3555935@kroah.com> References: <20200115121041.10863-1-Jerome.Pouiller@silabs.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200115121041.10863-1-Jerome.Pouiller@silabs.com> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Wed, Jan 15, 2020 at 12:12:07PM +0000, Jérôme Pouiller wrote: > From: Jérôme Pouiller > > Hello all, > > This pull request is finally bigger than I expected, sorry. After applying this series, I get this build error: drivers/staging/wfx/sta.c: In function ‘wfx_cqm_bssloss_sm’: drivers/staging/wfx/sta.c:91:28: error: expected ‘;’ before ‘struct’ 91 | struct ieee80211_hdr *hdr | ^ | ; 92 | struct ieee80211_tx_control control = { }; | ~~~~~~ drivers/staging/wfx/sta.c:99:3: error: ‘hdr’ undeclared (first use in this function); did you mean ‘idr’? 99 | hdr = (struct ieee80211_hdr *)skb->data; | ^~~ | idr Did you even test-build this? I could try to bisect and track down the offending commit, but that's too much work :) I'll wait for a v2 of this series, please fix up and resend. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BFF2C33CB1 for ; Wed, 15 Jan 2020 13:40:26 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CFBAA222C3 for ; Wed, 15 Jan 2020 13:40:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="pAuyIq2G" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CFBAA222C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id EF70B204E7; Wed, 15 Jan 2020 13:40:24 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hlcZBl8u9HxD; Wed, 15 Jan 2020 13:40:19 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id 6B299203B1; Wed, 15 Jan 2020 13:40:19 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 2FA451BF573 for ; Wed, 15 Jan 2020 13:40:18 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 2AAC4860D6 for ; Wed, 15 Jan 2020 13:40:18 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id v2N1TvGvUAzx for ; Wed, 15 Jan 2020 13:40:13 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by whitealder.osuosl.org (Postfix) with ESMTPS id 4C16D860A2 for ; Wed, 15 Jan 2020 13:40:13 +0000 (UTC) Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5FF6B207FF; Wed, 15 Jan 2020 13:40:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579095613; bh=vq7dWZIt2uzMmU//MJnDRlhzag57tdT+vRJG617udFk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pAuyIq2GysfG9S3GlghWZ6CQmBaqtmrJezPEwteygMOKNCDLyRE8eXRMflMeiWvza ufxC+sjMlz+9DD3PZkDbc0BoAThgdsDIQNqRr1tk8EOCy/UIhVDW5o/9iA2wj0sGcO xXVuV696c5E89sRBN9ayELZBHVGuO9qzKoEW1wI8= Date: Wed, 15 Jan 2020 14:40:10 +0100 From: Greg Kroah-Hartman To: =?iso-8859-1?B?Suly9G1l?= Pouiller Subject: Re: [PATCH 00/65] Simplify and improve the wfx driver Message-ID: <20200115134010.GA3555935@kroah.com> References: <20200115121041.10863-1-Jerome.Pouiller@silabs.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200115121041.10863-1-Jerome.Pouiller@silabs.com> X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devel@driverdev.osuosl.org" , "netdev@vger.kernel.org" , "linux-wireless@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "David S . Miller" , Kalle Valo Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" T24gV2VkLCBKYW4gMTUsIDIwMjAgYXQgMTI6MTI6MDdQTSArMDAwMCwgSsOpcsO0bWUgUG91aWxs ZXIgd3JvdGU6Cj4gRnJvbTogSsOpcsO0bWUgUG91aWxsZXIgPGplcm9tZS5wb3VpbGxlckBzaWxh YnMuY29tPgo+IAo+IEhlbGxvIGFsbCwKPiAKPiBUaGlzIHB1bGwgcmVxdWVzdCBpcyBmaW5hbGx5 IGJpZ2dlciB0aGFuIEkgZXhwZWN0ZWQsIHNvcnJ5LgoKQWZ0ZXIgYXBwbHlpbmcgdGhpcyBzZXJp ZXMsIEkgZ2V0IHRoaXMgYnVpbGQgZXJyb3I6Cgpkcml2ZXJzL3N0YWdpbmcvd2Z4L3N0YS5jOiBJ biBmdW5jdGlvbiDigJh3ZnhfY3FtX2Jzc2xvc3Nfc23igJk6CmRyaXZlcnMvc3RhZ2luZy93Zngv c3RhLmM6OTE6Mjg6IGVycm9yOiBleHBlY3RlZCDigJg74oCZIGJlZm9yZSDigJhzdHJ1Y3TigJkK ICAgOTEgfCAgIHN0cnVjdCBpZWVlODAyMTFfaGRyICpoZHIKICAgICAgfCAgICAgICAgICAgICAg ICAgICAgICAgICAgICBeCiAgICAgIHwgICAgICAgICAgICAgICAgICAgICAgICAgICAgOwogICA5 MiB8ICAgc3RydWN0IGllZWU4MDIxMV90eF9jb250cm9sIGNvbnRyb2wgPSB7IH07CiAgICAgIHwg ICB+fn5+fn4KZHJpdmVycy9zdGFnaW5nL3dmeC9zdGEuYzo5OTozOiBlcnJvcjog4oCYaGRy4oCZ IHVuZGVjbGFyZWQgKGZpcnN0IHVzZSBpbiB0aGlzIGZ1bmN0aW9uKTsgZGlkIHlvdSBtZWFuIOKA mGlkcuKAmT8KICAgOTkgfCAgIGhkciA9IChzdHJ1Y3QgaWVlZTgwMjExX2hkciAqKXNrYi0+ZGF0 YTsKICAgICAgfCAgIF5+fgogICAgICB8ICAgaWRyCgpEaWQgeW91IGV2ZW4gdGVzdC1idWlsZCB0 aGlzPwoKSSBjb3VsZCB0cnkgdG8gYmlzZWN0IGFuZCB0cmFjayBkb3duIHRoZSBvZmZlbmRpbmcg Y29tbWl0LCBidXQgdGhhdCdzCnRvbyBtdWNoIHdvcmsgOikKCkknbGwgd2FpdCBmb3IgYSB2MiBv ZiB0aGlzIHNlcmllcywgcGxlYXNlIGZpeCB1cCBhbmQgcmVzZW5kLgoKdGhhbmtzLAoKZ3JlZyBr LWgKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZGV2ZWwg bWFpbGluZyBsaXN0CmRldmVsQGxpbnV4ZHJpdmVycHJvamVjdC5vcmcKaHR0cDovL2RyaXZlcmRl di5saW51eGRyaXZlcnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8vZHJpdmVyZGV2LWRldmVs Cg==