From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F268C33CB3 for ; Wed, 15 Jan 2020 15:11:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0C73224671 for ; Wed, 15 Jan 2020 15:11:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579101083; bh=3gTNlszr+LAWpyQAE9KCG1f9A2EIwYniEezh0GNli7U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=tCDw0shQlGFdEndVbPya33w1oRggmGMhYf/FJC1yaHwtl5RRNI4G8/km5UOLsQo+V FIw6qmBgDVqMbGViWwZWyyokoFjx9AoyUyH3np9horyo45yaavd42wvKkmXI2S2v3k d9+qyq1yA6SxgMYrWt77Q6PwrNZ4GOm6l0QC2NhU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729107AbgAOPLW (ORCPT ); Wed, 15 Jan 2020 10:11:22 -0500 Received: from mail.kernel.org ([198.145.29.99]:50722 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726506AbgAOPLW (ORCPT ); Wed, 15 Jan 2020 10:11:22 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BD259222C3; Wed, 15 Jan 2020 15:11:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579101081; bh=3gTNlszr+LAWpyQAE9KCG1f9A2EIwYniEezh0GNli7U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LSztWCtE7OCoSmM5XihhW6xXTTQSxnf9FmQw8flyMeiHK+7qSvtL8C42FQ8Z2sc4T rVPD+6bdqi4RgQxeV3urPxq0U+0+XdIyUMGeJ27mCSIQyyPyWQUfjacDJpbPCIdNja gEbc9AOg+rgwKSX7+wfvUmz1E5Pn58TmLlH1nlDA= Date: Wed, 15 Jan 2020 16:11:18 +0100 From: Greg KH To: Suzuki Kuruppassery Poulose Cc: Sasha Levin , stable@vger.kernel.org, linux-arm-kernel@lists.infradead.org, mathieu.poirier@linaro.org, linux-kernel@vger.kernel.org Subject: Re: [stable] [PATCH 1/2] coresight: etb10: Do not call smp_processor_id from preemptible Message-ID: <20200115151118.GC3740793@kroah.com> References: <20200108110541.318672-1-suzuki.poulose@arm.com> <20200109143537.GE1706@sasha-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 09, 2020 at 02:36:17PM +0000, Suzuki Kuruppassery Poulose wrote: > On 09/01/2020 14:35, Sasha Levin wrote: > > On Wed, Jan 08, 2020 at 11:05:40AM +0000, Suzuki K Poulose wrote: > > > [ Upstream commit 730766bae3280a25d40ea76a53dc6342e84e6513 ] > > > > > > During a perf session we try to allocate buffers on the "node" associated > > > with the CPU the event is bound to. If it is not bound to a CPU, we > > > use the current CPU node, using smp_processor_id(). However this is > > > unsafe > > > in a pre-emptible context and could generate the splats as below : > > > > > > BUG: using smp_processor_id() in preemptible [00000000] code: perf/2544 > > > > > > Use NUMA_NO_NODE hint instead of using the current node for events > > > not bound to CPUs. > > > > > > Fixes: 2997aa4063d97fdb39 ("coresight: etb10: implementing AUX API") > > > Cc: Mathieu Poirier > > > Signed-off-by: Suzuki K Poulose > > > Cc: stable # v4.9 to v4.19 > > > Signed-off-by: Mathieu Poirier > > > Link: https://lore.kernel.org/r/20190620221237.3536-5-mathieu.poirier@linaro.org > > > > > > > I've queued this for 4.9-4.19. There was a simple conflict on 4.9 which > > also had to be resolved. > > > > > Thanks Sasha ! Note, these had to all be dropped as they broke the build :( So can you please send us patches that at least build? :) thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90789C33CB1 for ; Wed, 15 Jan 2020 15:11:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1EA69222C3 for ; Wed, 15 Jan 2020 15:11:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="U8RUORgE"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="LSztWCtE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1EA69222C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=d0kAYlDOKbnFufPaxArqjBvSN4Quk0eiKCZWjN0TGog=; b=U8RUORgEJqfA+V jZNJ4j2pOJrGxQMOxgGoiKhfdoJFccM+2B9beP0LaaX1P4GDm1hbo0vn34l3Z/8mFBDj4f1K28dsY jt91EhJYbbiBtPEZidZKWwm2f20m1jQjoNQzsfUkaRCmJ6kL6nKeVI6XJK1/mbZWBo4IguEDdHtGI T+091GtkNg/RNIq0ce5XWdHNBle5g6pgxIq+IsXnYLtFsMdgcjtcdZ3LExsMXlCuuYIQvkzL3O4qP zQQnlqjh2PEIKF2h4LGYLKxxjKWI3qiaQWzjNILCZuIK+8kN86NYGqWqqdEKjsxNfTVutOurvtW58 60lpBNs2cqqC1+Svg36g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1irkKN-0002aO-Eg; Wed, 15 Jan 2020 15:11:27 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1irkKI-0002ZV-2F for linux-arm-kernel@lists.infradead.org; Wed, 15 Jan 2020 15:11:26 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BD259222C3; Wed, 15 Jan 2020 15:11:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579101081; bh=3gTNlszr+LAWpyQAE9KCG1f9A2EIwYniEezh0GNli7U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LSztWCtE7OCoSmM5XihhW6xXTTQSxnf9FmQw8flyMeiHK+7qSvtL8C42FQ8Z2sc4T rVPD+6bdqi4RgQxeV3urPxq0U+0+XdIyUMGeJ27mCSIQyyPyWQUfjacDJpbPCIdNja gEbc9AOg+rgwKSX7+wfvUmz1E5Pn58TmLlH1nlDA= Date: Wed, 15 Jan 2020 16:11:18 +0100 From: Greg KH To: Suzuki Kuruppassery Poulose Subject: Re: [stable] [PATCH 1/2] coresight: etb10: Do not call smp_processor_id from preemptible Message-ID: <20200115151118.GC3740793@kroah.com> References: <20200108110541.318672-1-suzuki.poulose@arm.com> <20200109143537.GE1706@sasha-vm> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200115_071122_125539_EA9F5AE2 X-CRM114-Status: GOOD ( 16.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sasha Levin , mathieu.poirier@linaro.org, linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 09, 2020 at 02:36:17PM +0000, Suzuki Kuruppassery Poulose wrote: > On 09/01/2020 14:35, Sasha Levin wrote: > > On Wed, Jan 08, 2020 at 11:05:40AM +0000, Suzuki K Poulose wrote: > > > [ Upstream commit 730766bae3280a25d40ea76a53dc6342e84e6513 ] > > > > > > During a perf session we try to allocate buffers on the "node" associated > > > with the CPU the event is bound to. If it is not bound to a CPU, we > > > use the current CPU node, using smp_processor_id(). However this is > > > unsafe > > > in a pre-emptible context and could generate the splats as below : > > > > > > BUG: using smp_processor_id() in preemptible [00000000] code: perf/2544 > > > > > > Use NUMA_NO_NODE hint instead of using the current node for events > > > not bound to CPUs. > > > > > > Fixes: 2997aa4063d97fdb39 ("coresight: etb10: implementing AUX API") > > > Cc: Mathieu Poirier > > > Signed-off-by: Suzuki K Poulose > > > Cc: stable # v4.9 to v4.19 > > > Signed-off-by: Mathieu Poirier > > > Link: https://lore.kernel.org/r/20190620221237.3536-5-mathieu.poirier@linaro.org > > > > > > > I've queued this for 4.9-4.19. There was a simple conflict on 4.9 which > > also had to be resolved. > > > > > Thanks Sasha ! Note, these had to all be dropped as they broke the build :( So can you please send us patches that at least build? :) thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel