From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FD51C33CB1 for ; Wed, 15 Jan 2020 15:22:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6956D222C3 for ; Wed, 15 Jan 2020 15:22:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579101740; bh=xQmCyFQKagD5zDRlX3Qlfs8hMu8+HZwNUQzGdVyqi5g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=G5ELH3An/9q8HmaEkJ05aipSTExYvk8ekGUJ/6YhBSY02aySMJ8qHVs5oDJmKhGGt 68MBGGz4UzFO+e+DfIJKhXlUTycjzwrxOhyaWBVQJu6HDaSPEx6rQ0kj0aK5giMxkZ KP8MpoCGoSX1pdm+OymWeCxUAsx3gJriS0Ph0u2I= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729049AbgAOPWT (ORCPT ); Wed, 15 Jan 2020 10:22:19 -0500 Received: from mail.kernel.org ([198.145.29.99]:37382 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726165AbgAOPWT (ORCPT ); Wed, 15 Jan 2020 10:22:19 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 309C32053B; Wed, 15 Jan 2020 15:22:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579101738; bh=xQmCyFQKagD5zDRlX3Qlfs8hMu8+HZwNUQzGdVyqi5g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fVw5yj+U1NPrGHrcpdvUVYorEbTy7dsunxncXsx5tOnJfYg8xDWzdUYV5T3JpRMj3 kfhnPv44rNtofwxqnyHr36yJhL8caHMOIOVaXUPv4gIDfGdiFfXjVNr88CAT66S/Cw PLEbNEbRTfxGN9Yv+jMz+F9EOeYQuNQhYpTPRa5Y= Date: Wed, 15 Jan 2020 16:22:15 +0100 From: Greg KH To: Julian Stecklina Cc: intel-gvt-dev@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, zhiyuan.lv@intel.com, hang.yuan@intel.com, Zhenyu Wang Subject: Re: [RFC PATCH 4/4] drm/i915/gvt: move public gvt headers out into global include Message-ID: <20200115152215.GA3830321@kroah.com> References: <4079ce7c26a2d2a3c7e0828ed1ea6008d6e2c805.camel@cyberus-technology.de> <20200109171357.115936-1-julian.stecklina@cyberus-technology.de> <20200109171357.115936-5-julian.stecklina@cyberus-technology.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200109171357.115936-5-julian.stecklina@cyberus-technology.de> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 09, 2020 at 07:13:57PM +0200, Julian Stecklina wrote: > Now that the GVT interface to hypervisors does not depend on i915/GVT > internals anymore, we can move the headers to the global include/. > > This makes out-of-tree modules for hypervisor integration possible. What kind of out-of-tree modules do you need/want for this? And why do they somehow have to be out of the tree? We want them in the tree, and so should you, as it will save you time and money if they are. Also, as Christoph said, adding exports for functions that are not used by anything within the kernel tree itself is not ok, that's not how we work. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9566C33CB3 for ; Wed, 15 Jan 2020 15:22:20 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BFC3C2465A for ; Wed, 15 Jan 2020 15:22:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="fVw5yj+U" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BFC3C2465A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F26986EADB; Wed, 15 Jan 2020 15:22:19 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id DB9D56EADA; Wed, 15 Jan 2020 15:22:18 +0000 (UTC) Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 309C32053B; Wed, 15 Jan 2020 15:22:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579101738; bh=xQmCyFQKagD5zDRlX3Qlfs8hMu8+HZwNUQzGdVyqi5g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fVw5yj+U1NPrGHrcpdvUVYorEbTy7dsunxncXsx5tOnJfYg8xDWzdUYV5T3JpRMj3 kfhnPv44rNtofwxqnyHr36yJhL8caHMOIOVaXUPv4gIDfGdiFfXjVNr88CAT66S/Cw PLEbNEbRTfxGN9Yv+jMz+F9EOeYQuNQhYpTPRa5Y= Date: Wed, 15 Jan 2020 16:22:15 +0100 From: Greg KH To: Julian Stecklina Subject: Re: [RFC PATCH 4/4] drm/i915/gvt: move public gvt headers out into global include Message-ID: <20200115152215.GA3830321@kroah.com> References: <4079ce7c26a2d2a3c7e0828ed1ea6008d6e2c805.camel@cyberus-technology.de> <20200109171357.115936-1-julian.stecklina@cyberus-technology.de> <20200109171357.115936-5-julian.stecklina@cyberus-technology.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200109171357.115936-5-julian.stecklina@cyberus-technology.de> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, hang.yuan@intel.com, dri-devel@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, zhiyuan.lv@intel.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Jan 09, 2020 at 07:13:57PM +0200, Julian Stecklina wrote: > Now that the GVT interface to hypervisors does not depend on i915/GVT > internals anymore, we can move the headers to the global include/. > > This makes out-of-tree modules for hypervisor integration possible. What kind of out-of-tree modules do you need/want for this? And why do they somehow have to be out of the tree? We want them in the tree, and so should you, as it will save you time and money if they are. Also, as Christoph said, adding exports for functions that are not used by anything within the kernel tree itself is not ok, that's not how we work. thanks, greg k-h _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel