From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC39FC33CB3 for ; Wed, 15 Jan 2020 17:21:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 953DC24679 for ; Wed, 15 Jan 2020 17:21:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579108890; bh=lj6dG1jiiZtm+t3uE76M72ECvRumXwWAIZv2H54jjK8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=SpGp7RYBjCqj3uLevaexd99PalkeFZFuh+rVq1H0vdVuWbVbFjvpNqKq2dXUq4DSV bJgd2Ps+hXHze7DVM3cD2baCF+suJuf6mGNBBiGTGyX/TGTGjhGCu1uISWblgulQ95 fy6YRsbVxwbyrYwUVa+up6rPAfJlC5rw1TgxiSbY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729092AbgAORV3 (ORCPT ); Wed, 15 Jan 2020 12:21:29 -0500 Received: from mail.kernel.org ([198.145.29.99]:49424 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727016AbgAORV3 (ORCPT ); Wed, 15 Jan 2020 12:21:29 -0500 Received: from localhost (unknown [217.68.49.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3749E24671; Wed, 15 Jan 2020 17:21:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579108888; bh=lj6dG1jiiZtm+t3uE76M72ECvRumXwWAIZv2H54jjK8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=R6J4aYn55KVaZr35ao7n9TIQJ5A1K5+ihjd00AuNkdY4zS1MoNMNZebFB9XuJRg7I 9lixIXV5Li8Eb/7KCQIFOIiShLSFTYSN/WWfAvMztOxEGB4/3OPj0Gy/PzKnpuQ10d 8pe7kkrhK4U8fCObDw2gFZrnioGxXw7+Yl6jVZyk= Date: Wed, 15 Jan 2020 18:21:26 +0100 From: Greg KH To: Suzuki Kuruppassery Poulose Cc: Sasha Levin , stable@vger.kernel.org, linux-arm-kernel@lists.infradead.org, mathieu.poirier@linaro.org, linux-kernel@vger.kernel.org Subject: Re: [stable] [PATCH 1/2] coresight: etb10: Do not call smp_processor_id from preemptible Message-ID: <20200115172126.GB4127163@kroah.com> References: <20200108110541.318672-1-suzuki.poulose@arm.com> <20200109143537.GE1706@sasha-vm> <20200115151118.GC3740793@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 15, 2020 at 04:44:29PM +0000, Suzuki Kuruppassery Poulose wrote: > > Hi Greg, > > On 15/01/2020 15:11, Greg KH wrote: > > On Thu, Jan 09, 2020 at 02:36:17PM +0000, Suzuki Kuruppassery Poulose wrote: > > > On 09/01/2020 14:35, Sasha Levin wrote: > > > > On Wed, Jan 08, 2020 at 11:05:40AM +0000, Suzuki K Poulose wrote: > > > > > [ Upstream commit 730766bae3280a25d40ea76a53dc6342e84e6513 ] > > > > > > > > > > During a perf session we try to allocate buffers on the "node" associated > > > > > with the CPU the event is bound to. If it is not bound to a CPU, we > > > > > use the current CPU node, using smp_processor_id(). However this is > > > > > unsafe > > > > > in a pre-emptible context and could generate the splats as below : > > > > > > > > > > BUG: using smp_processor_id() in preemptible [00000000] code: perf/2544 > > > > > > > > > > Use NUMA_NO_NODE hint instead of using the current node for events > > > > > not bound to CPUs. > > > > > > > > > > Fixes: 2997aa4063d97fdb39 ("coresight: etb10: implementing AUX API") > > > > > Cc: Mathieu Poirier > > > > > Signed-off-by: Suzuki K Poulose > > > > > Cc: stable # v4.9 to v4.19 > > > > > Signed-off-by: Mathieu Poirier > > > > > Link: https://lore.kernel.org/r/20190620221237.3536-5-mathieu.poirier@linaro.org > > > > > > > > > > > > > I've queued this for 4.9-4.19. There was a simple conflict on 4.9 which > > > > also had to be resolved. > > > > > > > > > > > > > Thanks Sasha ! > > > > Note, these had to all be dropped as they broke the build :( > > > > So can you please send us patches that at least build? :) > > > > Do you have a build failure log ? I did build test it before sending it > over. I tried it again on 4.9, 4.14 and 4.19. I don't hit any build > failures here. > > Please could you share the log if you have it handy ? It was in the stable -rc review emails, I don't have it handy, sorry. greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9CF8C32771 for ; Wed, 15 Jan 2020 17:21:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8CFB324671 for ; Wed, 15 Jan 2020 17:21:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KHl0nY5i"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="R6J4aYn5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8CFB324671 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=a4PX9Wv0MVG3spHHQ4vngyLBGjiwsJ8hn6QwSYDzToo=; b=KHl0nY5i4K6pKe NqZvv19UyalLEulf5yHx5jV/uzV4YEixMHEIlNn3v6IENsg9fK98sWINHizH/qNdWNnFmoqR2dP78 VLYfmYW+gh1ENj1Rl78FqqIOkh3gW10EX1t6+Q+a+BMPkM1WbxiODFGhwHVCfucp3I4YIcDIUSgbl 1HKDVYGFFfcfkKI69HFSeL1idzQtO8SawWabk4cJw5K8ZDEi8LAuH1S6N06+7BxwpNWee9KCgFDfE 29q3X4nNo9imR2MDMX6S6vi2vaxS6dLnHanZYiHJN7bxlX28prnDtRh0rpzugoVx14/yYiWBKN4/i xCaCrXTOf6li0bVADphw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1irmMK-0003LB-CZ; Wed, 15 Jan 2020 17:21:36 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1irmME-0003KB-Ea for linux-arm-kernel@lists.infradead.org; Wed, 15 Jan 2020 17:21:34 +0000 Received: from localhost (unknown [217.68.49.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3749E24671; Wed, 15 Jan 2020 17:21:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579108888; bh=lj6dG1jiiZtm+t3uE76M72ECvRumXwWAIZv2H54jjK8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=R6J4aYn55KVaZr35ao7n9TIQJ5A1K5+ihjd00AuNkdY4zS1MoNMNZebFB9XuJRg7I 9lixIXV5Li8Eb/7KCQIFOIiShLSFTYSN/WWfAvMztOxEGB4/3OPj0Gy/PzKnpuQ10d 8pe7kkrhK4U8fCObDw2gFZrnioGxXw7+Yl6jVZyk= Date: Wed, 15 Jan 2020 18:21:26 +0100 From: Greg KH To: Suzuki Kuruppassery Poulose Subject: Re: [stable] [PATCH 1/2] coresight: etb10: Do not call smp_processor_id from preemptible Message-ID: <20200115172126.GB4127163@kroah.com> References: <20200108110541.318672-1-suzuki.poulose@arm.com> <20200109143537.GE1706@sasha-vm> <20200115151118.GC3740793@kroah.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200115_092130_510233_13BD76CD X-CRM114-Status: GOOD ( 20.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sasha Levin , mathieu.poirier@linaro.org, linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 15, 2020 at 04:44:29PM +0000, Suzuki Kuruppassery Poulose wrote: > > Hi Greg, > > On 15/01/2020 15:11, Greg KH wrote: > > On Thu, Jan 09, 2020 at 02:36:17PM +0000, Suzuki Kuruppassery Poulose wrote: > > > On 09/01/2020 14:35, Sasha Levin wrote: > > > > On Wed, Jan 08, 2020 at 11:05:40AM +0000, Suzuki K Poulose wrote: > > > > > [ Upstream commit 730766bae3280a25d40ea76a53dc6342e84e6513 ] > > > > > > > > > > During a perf session we try to allocate buffers on the "node" associated > > > > > with the CPU the event is bound to. If it is not bound to a CPU, we > > > > > use the current CPU node, using smp_processor_id(). However this is > > > > > unsafe > > > > > in a pre-emptible context and could generate the splats as below : > > > > > > > > > > BUG: using smp_processor_id() in preemptible [00000000] code: perf/2544 > > > > > > > > > > Use NUMA_NO_NODE hint instead of using the current node for events > > > > > not bound to CPUs. > > > > > > > > > > Fixes: 2997aa4063d97fdb39 ("coresight: etb10: implementing AUX API") > > > > > Cc: Mathieu Poirier > > > > > Signed-off-by: Suzuki K Poulose > > > > > Cc: stable # v4.9 to v4.19 > > > > > Signed-off-by: Mathieu Poirier > > > > > Link: https://lore.kernel.org/r/20190620221237.3536-5-mathieu.poirier@linaro.org > > > > > > > > > > > > > I've queued this for 4.9-4.19. There was a simple conflict on 4.9 which > > > > also had to be resolved. > > > > > > > > > > > > > Thanks Sasha ! > > > > Note, these had to all be dropped as they broke the build :( > > > > So can you please send us patches that at least build? :) > > > > Do you have a build failure log ? I did build test it before sending it > over. I tried it again on 4.9, 4.14 and 4.19. I don't hit any build > failures here. > > Please could you share the log if you have it handy ? It was in the stable -rc review emails, I don't have it handy, sorry. greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel