From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB5B4C32771 for ; Wed, 15 Jan 2020 17:45:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9484F206D7 for ; Wed, 15 Jan 2020 17:45:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729011AbgAORp4 (ORCPT ); Wed, 15 Jan 2020 12:45:56 -0500 Received: from sauhun.de ([88.99.104.3]:39068 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728896AbgAORpz (ORCPT ); Wed, 15 Jan 2020 12:45:55 -0500 Received: from localhost (p54B33239.dip0.t-ipconnect.de [84.179.50.57]) by pokefinder.org (Postfix) with ESMTPSA id C51E02C0742; Wed, 15 Jan 2020 18:45:53 +0100 (CET) Date: Wed, 15 Jan 2020 18:45:53 +0100 From: Wolfram Sang To: Krzysztof Kozlowski Cc: Vladimir Zapolskiy , Sylvain Lemieux , Linus Walleij , Arnd Bergmann , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jean Delvare , Jarkko Nikula Subject: Re: [PATCH v2 1/4] i2c: pmcmsp: Use proper printk format for resource_size_t Message-ID: <20200115174553.GI1239@ninjato> References: <1578992765-1418-1-git-send-email-krzk@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="16qp2B0xu0fRvRD7" Content-Disposition: inline In-Reply-To: <1578992765-1418-1-git-send-email-krzk@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --16qp2B0xu0fRvRD7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > + "Unable to get memory/io address region %pap\n", > + &(res->start)); My first thought was "parens not needed"; not because I like being picky but because it doesn't look more readable to me. checkpatch agrees: CHECK: Unnecessary parentheses around res->start #30: FILE: drivers/i2c/busses/i2c-pmcmsp.c:278: + &(res->start)); --16qp2B0xu0fRvRD7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAl4fT9EACgkQFA3kzBSg Kbb91BAAjPtROcvdlQNblLFk8PxjameI1NyWeapD6DkN0jImw+pfJ5nJFMnOu+Wh F6XntHHABtG0TIZrWZcaapSG2HtJBxJq1+1H00YyQMtlUqKnBsqZCcJ0qavL1Of8 4QoH/tLRxc263i7eSKo8Q/v7NJdrfzf6SXDGj0d2uyOgHXkiBcbiw7YOeIruvgF2 nPCAe65wsLvlS2/oVyEGjSuguyiFvkhz5y75LikWQ6KPA7mOTYYlsDFldEI0Jr0n Cjcp26950LR3uH6dkPnKJncyvgo+bqTCXty2VQZriONaIM2BgsziesYD6lZchTvT 0OyNUxrFbM6ajIuwtLD5HMiQ7GmvfHRABUscFjhWutXrjyBTmLKiWlDHMsVLnYwb z07XxGhjmufTlBSPI4rXIZtyMv81+aQGagjZXWDwefUnsKQjilb7DFo1f5fbnsxC sKO/C6Pi4scgwXvUCBgok0xczp1jVE2NhVLgATIvSiGqzTaTSt0xzlIZd06bStO+ uUBiyilC5TPyGU9npLRLvcaDg2LROH9UrTrb+vZX4qz5EOs25uMKb55F9oLtC5cc STUdu4uesKZgQc6xQEZ5ZoiuWiXTr/HZ6W8sBeaIO74SLgo+g4/6mtyaRBkz53u3 vibl9z27lUGZskp0ClfuU5AD1mH0GnRTizBlJmnZIBTmmzKM5bQ= =cFSU -----END PGP SIGNATURE----- --16qp2B0xu0fRvRD7-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC05AC32771 for ; Wed, 15 Jan 2020 17:46:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C162C206D7 for ; Wed, 15 Jan 2020 17:46:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DhMzPdn0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C162C206D7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=the-dreams.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=aOtnOzH1BMTujcZzFGtdMSYF1ujVWHd4OqsfO58Hw7I=; b=DhMzPdn0HXW2NVrUGPZt/ABx2 9uN2I6Z7bK0xsP+rVmXRhi0QCnIuuWCLKlt/7pKYFlTnGlSSJR4cQ4GwVFMiDSqhbl+YFmSZUs9bI lbP1i6+IppywyQe961w+cc8tgDK9wT7AZbv7eRPDZUulql3J2TKcMhrzNjHZ4Y/emy7Z2GXgZUjcx Qf7CGZXmOH7vulcfEb2Mwj2ze8BWWII2qJ6gCPRL0tQFVpOOgNvZ/m7s/KuRLzBK46u3r/PrHy6EW MzBmIFHKzckd9xBnes93Nm/VXtea6MVxQmbeNatGNZKnJ0ByrSMIU+zrPbfM8BbZtY+Yf8+UIwyZv iWoLVH4og==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1irmjy-00063l-6M; Wed, 15 Jan 2020 17:46:02 +0000 Received: from sauhun.de ([88.99.104.3] helo=pokefinder.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1irmjq-00062o-Gk for linux-arm-kernel@lists.infradead.org; Wed, 15 Jan 2020 17:46:00 +0000 Received: from localhost (p54B33239.dip0.t-ipconnect.de [84.179.50.57]) by pokefinder.org (Postfix) with ESMTPSA id C51E02C0742; Wed, 15 Jan 2020 18:45:53 +0100 (CET) Date: Wed, 15 Jan 2020 18:45:53 +0100 From: Wolfram Sang To: Krzysztof Kozlowski Subject: Re: [PATCH v2 1/4] i2c: pmcmsp: Use proper printk format for resource_size_t Message-ID: <20200115174553.GI1239@ninjato> References: <1578992765-1418-1-git-send-email-krzk@kernel.org> MIME-Version: 1.0 In-Reply-To: <1578992765-1418-1-git-send-email-krzk@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200115_094554_702753_E018C773 X-CRM114-Status: UNSURE ( 5.97 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , Linus Walleij , linux-kernel@vger.kernel.org, Jean Delvare , Vladimir Zapolskiy , Jarkko Nikula , linux-i2c@vger.kernel.org, Sylvain Lemieux , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============5489443147480025839==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============5489443147480025839== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="16qp2B0xu0fRvRD7" Content-Disposition: inline --16qp2B0xu0fRvRD7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > + "Unable to get memory/io address region %pap\n", > + &(res->start)); My first thought was "parens not needed"; not because I like being picky but because it doesn't look more readable to me. checkpatch agrees: CHECK: Unnecessary parentheses around res->start #30: FILE: drivers/i2c/busses/i2c-pmcmsp.c:278: + &(res->start)); --16qp2B0xu0fRvRD7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAl4fT9EACgkQFA3kzBSg Kbb91BAAjPtROcvdlQNblLFk8PxjameI1NyWeapD6DkN0jImw+pfJ5nJFMnOu+Wh F6XntHHABtG0TIZrWZcaapSG2HtJBxJq1+1H00YyQMtlUqKnBsqZCcJ0qavL1Of8 4QoH/tLRxc263i7eSKo8Q/v7NJdrfzf6SXDGj0d2uyOgHXkiBcbiw7YOeIruvgF2 nPCAe65wsLvlS2/oVyEGjSuguyiFvkhz5y75LikWQ6KPA7mOTYYlsDFldEI0Jr0n Cjcp26950LR3uH6dkPnKJncyvgo+bqTCXty2VQZriONaIM2BgsziesYD6lZchTvT 0OyNUxrFbM6ajIuwtLD5HMiQ7GmvfHRABUscFjhWutXrjyBTmLKiWlDHMsVLnYwb z07XxGhjmufTlBSPI4rXIZtyMv81+aQGagjZXWDwefUnsKQjilb7DFo1f5fbnsxC sKO/C6Pi4scgwXvUCBgok0xczp1jVE2NhVLgATIvSiGqzTaTSt0xzlIZd06bStO+ uUBiyilC5TPyGU9npLRLvcaDg2LROH9UrTrb+vZX4qz5EOs25uMKb55F9oLtC5cc STUdu4uesKZgQc6xQEZ5ZoiuWiXTr/HZ6W8sBeaIO74SLgo+g4/6mtyaRBkz53u3 vibl9z27lUGZskp0ClfuU5AD1mH0GnRTizBlJmnZIBTmmzKM5bQ= =cFSU -----END PGP SIGNATURE----- --16qp2B0xu0fRvRD7-- --===============5489443147480025839== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5489443147480025839==--