From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 514D0C32771 for ; Wed, 15 Jan 2020 19:52:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 27C69222C3 for ; Wed, 15 Jan 2020 19:52:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579117923; bh=uRSGaQ1itz52/dktuz7xbZhU0dwlsdhmm69wo6JhzqA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=N7sufj+M1cxUl61kAMWNEqdhwH43JDggI+6adPmdWkw2frP13MtvNk2ALy1rdc8Ja a6si3dGcwRy0NyBSsjLsJevaLhGLyMc4wQdHTTXBz07XIT7RhgXc4fOxl3oM18E+Yb w2g/HTTQm0W1m2ZNLAtOuZbnpjWWrbbmgkrBtXr0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729508AbgAOTwC (ORCPT ); Wed, 15 Jan 2020 14:52:02 -0500 Received: from mail-ed1-f65.google.com ([209.85.208.65]:39509 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726423AbgAOTwB (ORCPT ); Wed, 15 Jan 2020 14:52:01 -0500 Received: by mail-ed1-f65.google.com with SMTP id t17so16680884eds.6; Wed, 15 Jan 2020 11:52:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=aHd50RCmkVU/ZS/HxtfzC0g4zmJOst7WpqvtTeB8dwQ=; b=JRtQjebV1XuPND6/OQUpTB5OCOco5o6BMMxxe3cGAHp+9T8/xN+lkrePaMjP28O37/ AvEDzf0WD4i9yuiAcMuKCR0ac3LOQZ/q+ducBdFRmUN53Kr9Jj9438cb3bMBa/02g4VW OI81Iw9sbr8BAfVfBwS8lRhl4Y2GB0D7OXLLOSJZDTNK0lOsdqaqEKgjzR7ppSTlAtHB 9Pq8U1A13i6CrvWZkogovC6PL2zA+rmgkxfpZeS96wt4F3GDk1fGgN+olXeBtgl6uBzM zQeazAbACRU276mQqOW2S/OsNcrgFmUvHgtwNx+v6RMvBQ0Oi2wE9JkzMB3xCJjNkIXS 27ZQ== X-Gm-Message-State: APjAAAVYj019168MwilqmvoAvyJpPENg0XToPPfu5n2agLnleBEFGN33 jorpXIfkzq+ctSfaaP9Tm1Y= X-Google-Smtp-Source: APXvYqwe+/d6KcpGCa37Qjgf5sHzR3xo/URPMNvfsudTgB/tmaCyZ/Ctbk+unVAtHKq+h/sEPaRNag== X-Received: by 2002:a05:6402:298:: with SMTP id l24mr32222230edv.70.1579117919881; Wed, 15 Jan 2020 11:51:59 -0800 (PST) Received: from kozik-lap ([194.230.155.229]) by smtp.googlemail.com with ESMTPSA id j63sm756813edd.81.2020.01.15.11.51.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 15 Jan 2020 11:51:59 -0800 (PST) Date: Wed, 15 Jan 2020 20:51:57 +0100 From: Krzysztof Kozlowski To: Wolfram Sang Cc: Vladimir Zapolskiy , Sylvain Lemieux , Linus Walleij , Arnd Bergmann , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jean Delvare , Jarkko Nikula Subject: Re: [PATCH v2 1/4] i2c: pmcmsp: Use proper printk format for resource_size_t Message-ID: <20200115195157.GA8661@kozik-lap> References: <1578992765-1418-1-git-send-email-krzk@kernel.org> <20200115174553.GI1239@ninjato> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200115174553.GI1239@ninjato> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 15, 2020 at 06:45:53PM +0100, Wolfram Sang wrote: > > > + "Unable to get memory/io address region %pap\n", > > + &(res->start)); > > My first thought was "parens not needed"; not because I like being picky > but because it doesn't look more readable to me. > > checkpatch agrees: > > CHECK: Unnecessary parentheses around res->start > #30: FILE: drivers/i2c/busses/i2c-pmcmsp.c:278: > + &(res->start)); Indeed... let me send v3. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFCD9C32771 for ; Wed, 15 Jan 2020 19:52:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8EF882467A for ; Wed, 15 Jan 2020 19:52:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SFHhyYOq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8EF882467A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WZ0KJMCKPJVb70sm/nS98DeVaxNSR5a50d54fbTvgDc=; b=SFHhyYOqcZajO/ YvaoCeq9bbF9wFY5F2l/nr2a0z1vgQGYdQLn6KKIw3uD3wiPGbyywt+mQrCMpMg+Wkodc63Lze1MW XVl4QoXh3aJT4VCghMO0FB74ino7P5o3ur9vcdoK1VRr49UVY/54MkG4wqRep1QcCYOMzoKae7UA5 6UL+2A7yHDb4nL1SheRI6csxgc/IgV4XBZNbXGQstW9NJYTy2vY72V83EGXlonTbBeQ7RXOrwobms yZcW8Ob338phRTNFno3nNZEW50BjyycmfLSEvQG1lYY4gxR/jfB8oxZTlJiAQKk+DtdXJ/bNTi2nG BI0Pmo+8T3PE50FJ4pYA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iroi2-0001i7-N1; Wed, 15 Jan 2020 19:52:10 +0000 Received: from mail-ed1-f67.google.com ([209.85.208.67]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1irohv-0001hI-0O for linux-arm-kernel@lists.infradead.org; Wed, 15 Jan 2020 19:52:08 +0000 Received: by mail-ed1-f67.google.com with SMTP id i16so16683322edr.5 for ; Wed, 15 Jan 2020 11:52:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=aHd50RCmkVU/ZS/HxtfzC0g4zmJOst7WpqvtTeB8dwQ=; b=QeoKE9z42cmdtedH8UmkPBFxxyb810N9QrXptT3Vqmp+XlliFsfchuoGVRaPtcZU6Z 0YmqYy5jspOgierEv+LfxFbZ+sgX/VC8BEvK4KJYVfnoY/zV/1UIz8QyzWeygIoN5mLd X2p0NhZhze4GIeF4pWFNKxAWaefy50Xxo46QNvqcMmOdx+m+9mGSB/AWJxbwstp0pvjZ +IUOsDFN2UYuRm6S92ZOBokJ/v8C9iQlYy3jWe6AOcs3NCTk/IiUGsjaBla7E9xja4rO F5ajrty8d0n18q7aZTA13U+qZyVM/r12ippn6T85FQIlGE4Vl7GThs/wwuGOL6SjZSdA 9T8w== X-Gm-Message-State: APjAAAVKCXU+UjiNFsoh3xBBwIKaZdmf9M6RI9WQIIu4eiCtrXAmZoTA M38M171bnHxbqBrJOrDfuBdv4T5X5Tw= X-Google-Smtp-Source: APXvYqwe+/d6KcpGCa37Qjgf5sHzR3xo/URPMNvfsudTgB/tmaCyZ/Ctbk+unVAtHKq+h/sEPaRNag== X-Received: by 2002:a05:6402:298:: with SMTP id l24mr32222230edv.70.1579117919881; Wed, 15 Jan 2020 11:51:59 -0800 (PST) Received: from kozik-lap ([194.230.155.229]) by smtp.googlemail.com with ESMTPSA id j63sm756813edd.81.2020.01.15.11.51.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 15 Jan 2020 11:51:59 -0800 (PST) Date: Wed, 15 Jan 2020 20:51:57 +0100 From: Krzysztof Kozlowski To: Wolfram Sang Subject: Re: [PATCH v2 1/4] i2c: pmcmsp: Use proper printk format for resource_size_t Message-ID: <20200115195157.GA8661@kozik-lap> References: <1578992765-1418-1-git-send-email-krzk@kernel.org> <20200115174553.GI1239@ninjato> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200115174553.GI1239@ninjato> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200115_115203_051089_C75180B7 X-CRM114-Status: GOOD ( 11.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , Linus Walleij , linux-kernel@vger.kernel.org, Jean Delvare , Vladimir Zapolskiy , Jarkko Nikula , linux-i2c@vger.kernel.org, Sylvain Lemieux , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 15, 2020 at 06:45:53PM +0100, Wolfram Sang wrote: > > > + "Unable to get memory/io address region %pap\n", > > + &(res->start)); > > My first thought was "parens not needed"; not because I like being picky > but because it doesn't look more readable to me. > > checkpatch agrees: > > CHECK: Unnecessary parentheses around res->start > #30: FILE: drivers/i2c/busses/i2c-pmcmsp.c:278: > + &(res->start)); Indeed... let me send v3. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel