From: Christoph Hellwig <hch@lst.de>
To: Andreas Dilger <adilger@dilger.ca>
Cc: David Howells <dhowells@redhat.com>,
Christoph Hellwig <hch@lst.de>,
Qu Wenruo <quwenruo.btrfs@gmx.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
"Theodore Y. Ts'o" <tytso@mit.edu>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
linux-ext4 <linux-ext4@vger.kernel.org>,
linux-xfs <linux-xfs@vger.kernel.org>,
linux-btrfs <linux-btrfs@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Problems with determining data presence by examining extents?
Date: Thu, 16 Jan 2020 11:16:12 +0100 [thread overview]
Message-ID: <20200116101612.GB16435@lst.de> (raw)
In-Reply-To: <C0F67EC5-7B5D-4179-9F28-95B84D9CC326@dilger.ca>
On Wed, Jan 15, 2020 at 12:48:44PM -0700, Andreas Dilger wrote:
> I don't think either of those will be any better than FIEMAP, if the reason
> is that the underlying filesystem is filling in holes with actual data
> blocks to optimize the IO pattern. SEEK_HOLE would not find a hole in
> the block allocation, and would happily return the block of zeroes to
> the caller. Also, it isn't clear if SEEK_HOLE considers an allocated but
> unwritten extent to be a hole or a block?
It is supposed to treat unwritten extents that are not dirty as holes.
Note that fiemap can't even track the dirty state, so it will always give
you the wrong answer in some cases. And that is by design given that it
is a debug tool to give you the file system extent layout and can't be
used for data integrity purposes.
next prev parent reply other threads:[~2020-01-16 10:16 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 16:48 Problems with determining data presence by examining extents? David Howells
2020-01-14 22:49 ` Theodore Y. Ts'o
2020-01-15 3:54 ` Qu Wenruo
2020-01-15 12:46 ` Andreas Dilger
2020-01-15 13:10 ` Qu Wenruo
2020-01-15 13:31 ` Christoph Hellwig
2020-01-15 19:48 ` Andreas Dilger
2020-01-16 10:16 ` Christoph Hellwig [this message]
2020-01-15 20:55 ` David Howells
2020-01-15 22:11 ` Andreas Dilger
2020-01-15 23:09 ` David Howells
2020-01-26 18:19 ` Zygo Blaxell
2020-01-15 14:35 ` David Howells
2020-01-15 14:48 ` Christoph Hellwig
2020-01-15 14:59 ` David Howells
2020-01-16 10:13 ` Christoph Hellwig
2020-01-17 16:43 ` David Howells
2020-01-15 14:20 ` David Howells
2020-01-15 8:38 ` Christoph Hellwig
2020-01-15 13:50 ` David Howells
2020-01-15 14:05 ` David Howells
2020-01-15 14:24 ` Qu Wenruo
2020-01-15 14:50 ` David Howells
2020-01-15 14:15 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200116101612.GB16435@lst.de \
--to=hch@lst.de \
--cc=adilger@dilger.ca \
--cc=clm@fb.com \
--cc=darrick.wong@oracle.com \
--cc=dhowells@redhat.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.