[PATCH v3 1/2] ARM: dts: imx6: phycore-som: fix arm and soc minimum voltage

[PATCH v3 1/2] ARM: dts: imx6: phycore-som: fix arm and soc minimum voltage

[Marco Felsch]

The current set minimum voltage of 730000µV seems to be wrong. I don't
know the document which specifies that but the imx6qdl datasheets says
that the minimum voltage should be 0.925V for VDD_ARM (LDO bypassed,
lowest opp) and 1.15V for VDD_SOC (LDO bypassed, lowest opp).

Fixes: ddec5d1c0047 ("ARM: dts: imx6: Add initial support for phyCORE-i.MX 6 SOM")
Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
v3:
- fix commit message
v2:
- use ldo bypassed values
---
 arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
index a1e2c5094d58..51a47a242783 100644
--- a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
@@ -111,14 +111,14 @@
 		regulators {
 			vdd_arm: buck1 {
 				regulator-name = "vdd_arm";
-				regulator-min-microvolt = <730000>;
+				regulator-min-microvolt = <925000>;
 				regulator-max-microvolt = <1380000>;
 				regulator-always-on;
 			};
 
 			vdd_soc: buck2 {
 				regulator-name = "vdd_soc";
-				regulator-min-microvolt = <730000>;
+				regulator-min-microvolt = <1150000>;
 				regulator-max-microvolt = <1380000>;
 				regulator-always-on;
 			};
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH v3 2/2] ARM: dts: imx6: phycore-som: fix emmc supply

[Marco Felsch]

Currently the vmmc is supplied by the 1.8V pmic rail but this is wrong.
The default module behaviour is to power VCCQ and VCC by the 3.3V power
rail. Optional the user can connect the VCCQ to the pmic 1.8V emmc
power rail using a solder jumper.

Fixes: ddec5d1c0047 ("ARM: dts: imx6: Add initial support for phyCORE-i.MX 6 SOM")
Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
v3:
- adapt commit message
v2:
- remove all supplies references because per default the emmc is
  powered by the 3.3V power rail.
- adapt commit message
---
 arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
index 51a47a242783..0e7f452dfb81 100644
--- a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
@@ -187,7 +187,6 @@
 	pinctrl-0 = <&pinctrl_usdhc4>;
 	bus-width = <8>;
 	non-removable;
-	vmmc-supply = <&vdd_emmc_1p8>;
 	status = "disabled";
 };
 
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v3 2/2] ARM: dts: imx6: phycore-som: fix emmc supply

[Shawn Guo]

On Thu, Jan 16, 2020 at 03:01:08PM +0100, Marco Felsch wrote:
> Currently the vmmc is supplied by the 1.8V pmic rail but this is wrong.
> The default module behaviour is to power VCCQ and VCC by the 3.3V power
> rail. Optional the user can connect the VCCQ to the pmic 1.8V emmc
> power rail using a solder jumper.
> 
> Fixes: ddec5d1c0047 ("ARM: dts: imx6: Add initial support for phyCORE-i.MX 6 SOM")
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>

Applied, thanks.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v3 1/2] ARM: dts: imx6: phycore-som: fix arm and soc minimum voltage

[Shawn Guo]

On Thu, Jan 16, 2020 at 03:01:07PM +0100, Marco Felsch wrote:
> The current set minimum voltage of 730000µV seems to be wrong. I don't
> know the document which specifies that but the imx6qdl datasheets says
> that the minimum voltage should be 0.925V for VDD_ARM (LDO bypassed,
> lowest opp) and 1.15V for VDD_SOC (LDO bypassed, lowest opp).
> 
> Fixes: ddec5d1c0047 ("ARM: dts: imx6: Add initial support for phyCORE-i.MX 6 SOM")
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>

I failed to apply it.  Please rebase and resend.

Shawn

> ---
> v3:
> - fix commit message
> v2:
> - use ldo bypassed values
> ---
>  arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
> index a1e2c5094d58..51a47a242783 100644
> --- a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
> @@ -111,14 +111,14 @@
>  		regulators {
>  			vdd_arm: buck1 {
>  				regulator-name = "vdd_arm";
> -				regulator-min-microvolt = <730000>;
> +				regulator-min-microvolt = <925000>;
>  				regulator-max-microvolt = <1380000>;
>  				regulator-always-on;
>  			};
>  
>  			vdd_soc: buck2 {
>  				regulator-name = "vdd_soc";
> -				regulator-min-microvolt = <730000>;
> +				regulator-min-microvolt = <1150000>;
>  				regulator-max-microvolt = <1380000>;
>  				regulator-always-on;
>  			};
> -- 
> 2.20.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v3 1/2] ARM: dts: imx6: phycore-som: fix arm and soc minimum voltage

[Marco Felsch]

Hi Shawn,

On 20-02-13 20:59, Shawn Guo wrote:
> On Thu, Jan 16, 2020 at 03:01:07PM +0100, Marco Felsch wrote:
> > The current set minimum voltage of 730000µV seems to be wrong. I don't
> > know the document which specifies that but the imx6qdl datasheets says
> > that the minimum voltage should be 0.925V for VDD_ARM (LDO bypassed,
> > lowest opp) and 1.15V for VDD_SOC (LDO bypassed, lowest opp).
> > 
> > Fixes: ddec5d1c0047 ("ARM: dts: imx6: Add initial support for phyCORE-i.MX 6 SOM")
> > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> 
> I failed to apply it.  Please rebase and resend.

Which base commit did you use? I rebased the patch on v5.6-rc1 without
problems.

Regards,
  Marco

> Shawn
> 
> > ---
> > v3:
> > - fix commit message
> > v2:
> > - use ldo bypassed values
> > ---
> >  arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
> > index a1e2c5094d58..51a47a242783 100644
> > --- a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
> > +++ b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
> > @@ -111,14 +111,14 @@
> >  		regulators {
> >  			vdd_arm: buck1 {
> >  				regulator-name = "vdd_arm";
> > -				regulator-min-microvolt = <730000>;
> > +				regulator-min-microvolt = <925000>;
> >  				regulator-max-microvolt = <1380000>;
> >  				regulator-always-on;
> >  			};
> >  
> >  			vdd_soc: buck2 {
> >  				regulator-name = "vdd_soc";
> > -				regulator-min-microvolt = <730000>;
> > +				regulator-min-microvolt = <1150000>;
> >  				regulator-max-microvolt = <1380000>;
> >  				regulator-always-on;
> >  			};
> > -- 
> > 2.20.1
> > 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v3 1/2] ARM: dts: imx6: phycore-som: fix arm and soc minimum voltage

[Shawn Guo]

On Fri, Feb 21, 2020 at 08:27:51AM +0100, Marco Felsch wrote:
> Hi Shawn,
> 
> On 20-02-13 20:59, Shawn Guo wrote:
> > On Thu, Jan 16, 2020 at 03:01:07PM +0100, Marco Felsch wrote:
> > > The current set minimum voltage of 730000µV seems to be wrong. I don't
> > > know the document which specifies that but the imx6qdl datasheets says
> > > that the minimum voltage should be 0.925V for VDD_ARM (LDO bypassed,
> > > lowest opp) and 1.15V for VDD_SOC (LDO bypassed, lowest opp).
> > > 
> > > Fixes: ddec5d1c0047 ("ARM: dts: imx6: Add initial support for phyCORE-i.MX 6 SOM")
> > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> > 
> > I failed to apply it.  Please rebase and resend.
> 
> Which base commit did you use? I rebased the patch on v5.6-rc1 without
> problems.

But 'git am' fails on v5.6-rc1.

Applying: ARM: dts: imx6: phycore-som: fix arm and soc minimum voltage
error: patch failed: arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi:111
error: arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi: patch does not apply
Patch failed at 0001 ARM: dts: imx6: phycore-som: fix arm and soc minimum voltage
Use 'git am --show-current-patch' to see the failed patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Shawn

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v3 1/2] ARM: dts: imx6: phycore-som: fix arm and soc minimum voltage

[Marco Felsch]

On 20-02-24 09:06, Shawn Guo wrote:
> On Fri, Feb 21, 2020 at 08:27:51AM +0100, Marco Felsch wrote:
> > Hi Shawn,
> > 
> > On 20-02-13 20:59, Shawn Guo wrote:
> > > On Thu, Jan 16, 2020 at 03:01:07PM +0100, Marco Felsch wrote:
> > > > The current set minimum voltage of 730000µV seems to be wrong. I don't
> > > > know the document which specifies that but the imx6qdl datasheets says
> > > > that the minimum voltage should be 0.925V for VDD_ARM (LDO bypassed,
> > > > lowest opp) and 1.15V for VDD_SOC (LDO bypassed, lowest opp).
> > > > 
> > > > Fixes: ddec5d1c0047 ("ARM: dts: imx6: Add initial support for phyCORE-i.MX 6 SOM")
> > > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> > > 
> > > I failed to apply it.  Please rebase and resend.
> > 
> > Which base commit did you use? I rebased the patch on v5.6-rc1 without
> > problems.
> 
> But 'git am' fails on v5.6-rc1.

Mh.. don't see why git am complains on my side.. Anyway I will send a
new version =)

Regards,
  Marco

> Applying: ARM: dts: imx6: phycore-som: fix arm and soc minimum voltage
> error: patch failed: arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi:111
> error: arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi: patch does not apply
> Patch failed at 0001 ARM: dts: imx6: phycore-som: fix arm and soc minimum voltage
> Use 'git am --show-current-patch' to see the failed patch
> When you have resolved this problem, run "git am --continue".
> If you prefer to skip this patch, run "git am --skip" instead.
> To restore the original branch and stop patching, run "git am --abort".
> 
> Shawn

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel