From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D99B6C33CAF for ; Thu, 16 Jan 2020 17:47:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A6F9C246A0 for ; Thu, 16 Jan 2020 17:47:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579196873; bh=qgwuVNNpFdCc0+ZOl5qpDoUQmhiEEmnb/2EBaZ+Or9Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=tS41TBvxr9LujRJa9pWTnpI8kL9wnCLBhKKI2IQ4AFOQCU/zzQWm5Gyq/9saIpaCT CIE9ZbUBozbkLhYTu45DUVqePbIxr9aHrVAVPlyz811dbXUk18ZOGj6Mch1kEN5xwD 8QXRoTFyG5Mi7FZUweJFcpHSjWzyW4GrFo2+8i0s= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394281AbgAPRrw (ORCPT ); Thu, 16 Jan 2020 12:47:52 -0500 Received: from mail.kernel.org ([198.145.29.99]:41458 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391425AbgAPRrt (ORCPT ); Thu, 16 Jan 2020 12:47:49 -0500 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E01792468D; Thu, 16 Jan 2020 17:47:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579196868; bh=qgwuVNNpFdCc0+ZOl5qpDoUQmhiEEmnb/2EBaZ+Or9Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zhPIL1EXrxLJ9zQQ7bEFkZWA7AWqtAjYqdQSmnvfZjye2DRhfSFwsSLLTYMu9V0Mg eQ/3fUbX8BTSoHXiW8WhIQt+1erUB/4740KmjBBJkoodYcsgRVRzY54PCjVGThuSlb cpFRRfHtCiwi8f5mqkZlFMK+vFG/zTgB9EQpSWx0= Date: Thu, 16 Jan 2020 17:47:43 +0000 From: Will Deacon To: Sami Tolvanen Cc: Catalin Marinas , Steven Rostedt , Masami Hiramatsu , Ard Biesheuvel , Mark Rutland , Dave Martin , Kees Cook , Laura Abbott , Marc Zyngier , Nick Desaulniers , Jann Horn , Miguel Ojeda , Masahiro Yamada , clang-built-linux@googlegroups.com, kernel-hardening@lists.openwall.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 13/15] arm64: disable SCS for hypervisor code Message-ID: <20200116174742.GF21396@willie-the-truck> References: <20191018161033.261971-1-samitolvanen@google.com> <20191206221351.38241-1-samitolvanen@google.com> <20191206221351.38241-14-samitolvanen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191206221351.38241-14-samitolvanen@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 06, 2019 at 02:13:49PM -0800, Sami Tolvanen wrote: > Filter out CC_FLAGS_SCS for code that runs at a different exception > level. > > Suggested-by: Steven Rostedt (VMware) > Signed-off-by: Sami Tolvanen > Reviewed-by: Kees Cook > Reviewed-by: Mark Rutland > --- > arch/arm64/kvm/hyp/Makefile | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/kvm/hyp/Makefile b/arch/arm64/kvm/hyp/Makefile > index ea710f674cb6..17ea3da325e9 100644 > --- a/arch/arm64/kvm/hyp/Makefile > +++ b/arch/arm64/kvm/hyp/Makefile > @@ -28,3 +28,6 @@ GCOV_PROFILE := n > KASAN_SANITIZE := n > UBSAN_SANITIZE := n > KCOV_INSTRUMENT := n > + > +# remove the SCS flags from all objects in this directory > +KBUILD_CFLAGS := $(filter-out $(CC_FLAGS_SCS), $(KBUILD_CFLAGS)) Same comment as for the vDSO; can we remove the -ffixed-x18 as well? Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FB99C33CAF for ; Thu, 16 Jan 2020 18:36:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EC9832073A for ; Thu, 16 Jan 2020 18:36:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Hq1KkdK7"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="zhPIL1EX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC9832073A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AWYRbLeM78JX00WqJltdtEuC4B8QA38rmoTPFyXAwfw=; b=Hq1KkdK7VvGxoH 57rRtYd4eMzbogRbhD4UD7Yb7ym6FIYkTWOfwS4u5IJrdKWoWNHj0EWrwtVPuJHIFr0BPfK4t5SQB uTZ/2bKXt4n/5msLkm6mGkJ/EsSVPOmS7rDYwGiL5u9sTBnJZ7bLeS8F6aeuR58lQeUPTG8bF6JWa BTZl3P+WbOa7QiNRCn+HWDJD/DWvsvQGWUm/w/R+CO2tshR/DII+PzhrBSweHnZJxBpiX1L5r+iOX nUOBtsp9JJ3ynd6PWQ4kk4LOwWOUPsUZPsbO+Ct+JURPfDpyKnyDJJSLwIAGsCGtb1gzCY/X0aJOK 4fHhegFPzBdMHSgz6pAg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1isA0T-0006K6-1Z; Thu, 16 Jan 2020 18:36:37 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1is9FF-0007am-J8 for linux-arm-kernel@lists.infradead.org; Thu, 16 Jan 2020 17:47:55 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E01792468D; Thu, 16 Jan 2020 17:47:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579196868; bh=qgwuVNNpFdCc0+ZOl5qpDoUQmhiEEmnb/2EBaZ+Or9Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zhPIL1EXrxLJ9zQQ7bEFkZWA7AWqtAjYqdQSmnvfZjye2DRhfSFwsSLLTYMu9V0Mg eQ/3fUbX8BTSoHXiW8WhIQt+1erUB/4740KmjBBJkoodYcsgRVRzY54PCjVGThuSlb cpFRRfHtCiwi8f5mqkZlFMK+vFG/zTgB9EQpSWx0= Date: Thu, 16 Jan 2020 17:47:43 +0000 From: Will Deacon To: Sami Tolvanen Subject: Re: [PATCH v6 13/15] arm64: disable SCS for hypervisor code Message-ID: <20200116174742.GF21396@willie-the-truck> References: <20191018161033.261971-1-samitolvanen@google.com> <20191206221351.38241-1-samitolvanen@google.com> <20191206221351.38241-14-samitolvanen@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191206221351.38241-14-samitolvanen@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200116_094749_751683_9425B5E2 X-CRM114-Status: GOOD ( 13.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Kees Cook , Ard Biesheuvel , Masahiro Yamada , Catalin Marinas , Jann Horn , Nick Desaulniers , linux-kernel@vger.kernel.org, Steven Rostedt , Miguel Ojeda , clang-built-linux@googlegroups.com, Masami Hiramatsu , Marc Zyngier , kernel-hardening@lists.openwall.com, Laura Abbott , Dave Martin , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Dec 06, 2019 at 02:13:49PM -0800, Sami Tolvanen wrote: > Filter out CC_FLAGS_SCS for code that runs at a different exception > level. > > Suggested-by: Steven Rostedt (VMware) > Signed-off-by: Sami Tolvanen > Reviewed-by: Kees Cook > Reviewed-by: Mark Rutland > --- > arch/arm64/kvm/hyp/Makefile | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/kvm/hyp/Makefile b/arch/arm64/kvm/hyp/Makefile > index ea710f674cb6..17ea3da325e9 100644 > --- a/arch/arm64/kvm/hyp/Makefile > +++ b/arch/arm64/kvm/hyp/Makefile > @@ -28,3 +28,6 @@ GCOV_PROFILE := n > KASAN_SANITIZE := n > UBSAN_SANITIZE := n > KCOV_INSTRUMENT := n > + > +# remove the SCS flags from all objects in this directory > +KBUILD_CFLAGS := $(filter-out $(CC_FLAGS_SCS), $(KBUILD_CFLAGS)) Same comment as for the vDSO; can we remove the -ffixed-x18 as well? Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel