From: Andrew Morton <akpm@linux-foundation.org>
To: David Rientjes <rientjes@google.com>
Cc: Mel Gorman <mgorman@techsingularity.net>,
Vlastimil Babka <vbabka@suse.cz>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [patch] mm, thp: fix defrag setting if newline is not used
Date: Thu, 16 Jan 2020 19:16:09 -0800 [thread overview]
Message-ID: <20200116191609.3972fd5301cf364a27381923@linux-foundation.org> (raw)
In-Reply-To: <alpine.DEB.2.21.2001141757490.108121@chino.kir.corp.google.com>
On Tue, 14 Jan 2020 17:58:36 -0800 (PST) David Rientjes <rientjes@google.com> wrote:
> If thp defrag setting "defer" is used and a newline is *not* used when
> writing to the sysfs file, this is interpreted as the "defer+madvise"
> option.
>
> This is because we do prefix matching and if five characters are written
> without a newline, the current code ends up comparing to the first five
> bytes of the "defer+madvise" option and using that instead.
>
> Find the length of what the user is writing and use that to guide our
> decision on which string comparison to do.
Gee, why is this code so complicated? Can't we just do
if (sysfs_streq(buf, "always")) {
...
} else if sysfs_streq(buf, "defer+madvise")) {
...
}
...
next prev parent reply other threads:[~2020-01-17 3:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 1:58 [patch] mm, thp: fix defrag setting if newline is not used David Rientjes
2020-01-15 1:58 ` David Rientjes
2020-01-15 12:45 ` Vlastimil Babka
2020-01-17 3:16 ` Andrew Morton [this message]
2020-01-17 8:24 ` Vlastimil Babka
2020-01-17 9:43 ` David Rientjes
2020-01-17 9:43 ` David Rientjes
2020-01-17 10:12 ` Vlastimil Babka
2020-01-17 22:11 ` [patch v2] " David Rientjes
2020-01-17 22:11 ` David Rientjes
2020-01-18 10:54 ` Vlastimil Babka
2020-01-19 1:04 ` Andrew Morton
2020-01-19 21:57 ` David Rientjes
2020-01-19 21:57 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200116191609.3972fd5301cf364a27381923@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.