From: Shourya Shukla <shouryashukla.oo@gmail.com>
To: git@vger.kernel.org, gitster@pobox.com, johannes.schindelin@gmx.de
Cc: Shourya Shukla <shouryashukla.oo@gmail.com>
Subject: [PATCH 0/3] t6025: updating tests
Date: Fri, 17 Jan 2020 02:06:19 +0530 [thread overview]
Message-ID: <20200116203622.4694-1-shouryashukla.oo@gmail.com> (raw)
Greetings everyone!
This is my first ever contribution in the Open-Source Community and I chose Git
for this purpose as I have been using this important tool to maintain my projects
regularly.
In this patch, I have:
- modernized these tests so that they meet current Git CodingGuidlines[1]
- replaced the pipe operator with the redirection operator so that one can
detect the errors easily and precisely
- used helper function 'test_path_is_file()' to replace 'test -f' checks in
in the program as it improves the readability of the code and provides
better error messages
Also, I have some questions to better my understanding of the code:
- In the statement,
> git hash-object -t blob -w --stdin
is it necessary to explicitly specify the type 'blob' of the hash-object?
I have this question because it is the default type of hash-object.
- In the statement,
> l=$(printf file | git hash-object -t blob -w --stdin)
I have not used the redirection operator as this sub-shell will be executed
separately, hence its error cannot be captured therefore the presence of '>'
will not matter. Will using '>' improve the code?
Thanks,
Shourya Shukla
Shourya Shukla (3):
t6025: modernize style
t6025: replace pipe with redirection operator
t6025: use helpers to replace test -f <path>
t/t6025-merge-symlinks.sh | 97 ++++++++++++++++++++-------------------
1 file changed, 50 insertions(+), 47 deletions(-)
--
2.20.1
next reply other threads:[~2020-01-16 20:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 20:36 Shourya Shukla [this message]
2020-01-16 20:36 ` [PATCH 1/3] t6025: modernize style Shourya Shukla
2020-01-16 21:42 ` Johannes Schindelin
2020-01-16 20:36 ` [PATCH 2/3] t6025: replace pipe with redirection operator Shourya Shukla
2020-01-16 22:57 ` Junio C Hamano
2020-01-16 20:36 ` [PATCH 3/3] t6025: use helpers to replace test -f <path> Shourya Shukla
2020-01-16 22:58 ` Junio C Hamano
2020-01-17 20:44 ` [PATCH 0/3] t6025: amended changes after suggestions from the community Shourya Shukla
2020-01-17 20:44 ` [PATCH 1/3] t6025: modernize style Shourya Shukla
2020-01-17 21:15 ` Eric Sunshine
2020-01-17 21:28 ` Junio C Hamano
2020-01-17 20:44 ` [PATCH 2/3] t6025: replace pipe with redirection operator Shourya Shukla
2020-01-17 21:24 ` Eric Sunshine
2020-01-18 8:33 ` [PATCH 0/3] t6025: updating tests Shourya Shukla
2020-01-18 8:33 ` [PATCH 1/3] t6025: modernize style Shourya Shukla
2020-01-18 8:33 ` [PATCH 2/3] t6025: replace pipe with redirection operator Shourya Shukla
2020-01-18 8:33 ` [PATCH 3/3] t6025: use helpers to replace test -f <path> Shourya Shukla
2020-01-18 8:33 ` [PATCH v3 0/2] t025: amended changes after suggestions from the community Shourya Shukla
2020-01-18 8:33 ` [PATCH v3 1/2] t6025: modernize style Shourya Shukla
2020-01-21 21:57 ` Junio C Hamano
2020-01-18 8:33 ` [PATCH v3 2/2] t6025: use helpers to replace test -f <path> Shourya Shukla
2020-01-21 21:58 ` Junio C Hamano
2020-01-17 20:44 ` [PATCH 3/3] " Shourya Shukla
2020-01-16 21:46 ` [PATCH 0/3] t6025: updating tests Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200116203622.4694-1-shouryashukla.oo@gmail.com \
--to=shouryashukla.oo@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.