Re: [PATCH v10 05/14] exfat: add file operations

From: "Pali Rohár" <pali.rohar@gmail.com>
To: Namjae Jeon <namjae.jeon@samsung.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	gregkh@linuxfoundation.org, valdis.kletnieks@vt.edu, hch@lst.de,
	sj1557.seo@samsung.com, linkinjeon@gmail.com, arnd@arndb.de
Subject: Re: [PATCH v10 05/14] exfat: add file operations
Date: Fri, 17 Jan 2020 10:18:13 +0100	[thread overview]
Message-ID: <20200117091813.wiksrz5khmtoocbj@pali> (raw)
In-Reply-To: <20200115082447.19520-6-namjae.jeon@samsung.com>

On Wednesday 15 January 2020 17:24:38 Namjae Jeon wrote:
> This adds the implementation of file operations for exfat.
> 
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> Signed-off-by: Sungjong Seo <sj1557.seo@samsung.com>
> ---
>  fs/exfat/file.c | 355 ++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 355 insertions(+)
>  create mode 100644 fs/exfat/file.c
> 
> diff --git a/fs/exfat/file.c b/fs/exfat/file.c
> new file mode 100644
> index 000000000000..b4b8af0cae0a
> --- /dev/null
> +++ b/fs/exfat/file.c

...

> +/* resize the file length */
> +int __exfat_truncate(struct inode *inode, loff_t new_size)
> +{

...

> +
> +		ktime_get_real_ts64(&ts);
> +		exfat_set_entry_time(sbi, &ts,
> +				&ep->dentry.file.modify_time,
> +				&ep->dentry.file.modify_date,
> +				&ep->dentry.file.modify_tz);

Hello! Now I spotted that you forgot to update "modify_time_ms" entry.

To prevent this problem, maybe function modify_time_ms() could take
another (optional) parameter for specifying time_ms?

> +		ep->dentry.file.attr = cpu_to_le16(ei->attr);
> +
> +		/* File size should be zero if there is no cluster allocated */
> +		if (ei->start_clu == EXFAT_EOF_CLUSTER) {
> +			ep->dentry.stream.valid_size = 0;
> +			ep->dentry.stream.size = 0;
> +		} else {
> +			ep->dentry.stream.valid_size = cpu_to_le64(new_size);
> +			ep->dentry.stream.size = ep->dentry.stream.valid_size;
> +		}
> +

-- 
Pali Rohár
pali.rohar@gmail.com