From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86762C33CB7 for ; Fri, 17 Jan 2020 11:52:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5B6CB2082F for ; Fri, 17 Jan 2020 11:52:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579261951; bh=VBDE1VIH+G3Ugqt0Cf5Pd1R/zl3rJNvOW48TQo0f6IU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=KrwEweLO+ajvsV8YOJPGmwc+iFnG0BBTUNZxtTxuGkUerZXgqFISqQoRoYORAVzpY flv0192dI/SLzU1vO1ySmGeyL0x8/RBQDqdNlzGo661kGKEgUtftk1CM22N3uDxONz /LbCz7CJ+ZCakhH9S3BLrsN6xq7tg/CTzzFUMEls= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727691AbgAQLwa (ORCPT ); Fri, 17 Jan 2020 06:52:30 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:35405 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726864AbgAQLw3 (ORCPT ); Fri, 17 Jan 2020 06:52:29 -0500 Received: by mail-wr1-f68.google.com with SMTP id g17so22397452wro.2; Fri, 17 Jan 2020 03:52:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=CfaMrw+TYdEFJRwNODCdrVm4OOMZyFpQ0nkjoCPs5oc=; b=joiWYM23dUV5fRgLneE6DZ+1UH/i4alcTSHI7MiV4iZNn1nDf5MPxofqkdHbJAfyyH 3FvHBuS0gfu/qRxN8OU9/ERnrT/HL7ip7tMd12l9xbRiVspPzGLO4NA8j190fddtSjYy 6uhJVgn0z+0NNy0O37oqOFAzcDyVMsplAbxsB5uXxAwTwMm/T6S7CR3tuuPj3AKwoXkV CGQjnGr8wPWHzJbg0cqfABPwdAWMFviZJQWHtfZwYQVEkymAUBYYHFGADhsuDVYclSkG pxWlrnbpeuujcAzMhE2PEP8f6MF37KAIeTd90C0GMHUk9tb1dpEW5eUEUE/960fteYuy qP0A== X-Gm-Message-State: APjAAAWVNGcsfDDPZkxE40LsCXBFGSvJYsJqscLy5/MYwU/7JNcNpmuh weCVE3LHcPofQfva6qKw0/s= X-Google-Smtp-Source: APXvYqyFPhokZ7VGCqtGBvrGiYujSUt2mcWg7TDf/fiD867pU8zDvypUZ/CFGECXxUvRKPCo1tfbgw== X-Received: by 2002:a5d:6a83:: with SMTP id s3mr2496048wru.99.1579261946860; Fri, 17 Jan 2020 03:52:26 -0800 (PST) Received: from localhost (prg-ext-pat.suse.com. [213.151.95.130]) by smtp.gmail.com with ESMTPSA id k13sm33558283wrx.59.2020.01.17.03.52.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jan 2020 03:52:26 -0800 (PST) Date: Fri, 17 Jan 2020 12:52:25 +0100 From: Michal Hocko To: Minchan Kim Cc: Andrew Morton , LKML , linux-mm , linux-api@vger.kernel.org, oleksandr@redhat.com, Suren Baghdasaryan , Tim Murray , Daniel Colascione , Sandeep Patil , Sonny Rao , Brian Geffon , Johannes Weiner , Shakeel Butt , John Dias , ktkhai@virtuozzo.com, christian.brauner@ubuntu.com, sjpark@amazon.de Subject: Re: [PATCH v2 2/5] mm: introduce external memory hinting API Message-ID: <20200117115225.GV19428@dhcp22.suse.cz> References: <20200116235953.163318-1-minchan@kernel.org> <20200116235953.163318-3-minchan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200116235953.163318-3-minchan@kernel.org> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 16-01-20 15:59:50, Minchan Kim wrote: > There is usecase that System Management Software(SMS) want to give > a memory hint like MADV_[COLD|PAGEEOUT] to other processes and > in the case of Android, it is the ActivityManagerService. > > It's similar in spirit to madvise(MADV_WONTNEED), but the information > required to make the reclaim decision is not known to the app. Instead, > it is known to the centralized userspace daemon(ActivityManagerService), > and that daemon must be able to initiate reclaim on its own without > any app involvement. > > To solve the issue, this patch introduces new syscall process_madvise(2). > It uses pidfd of an external processs to give the hint. > > int process_madvise(int pidfd, void *addr, size_t length, int advise, > unsigned long flag); > > Since it could affect other process's address range, only privileged > process(CAP_SYS_PTRACE) or something else(e.g., being the same UID) > gives it the right to ptrace the process could use it successfully. > The flag argument is reserved for future use if we need to extend the > API. > > I think supporting all hints madvise has/will supported/support to > process_madvise is rather risky. Because we are not sure all hints make > sense from external process and implementation for the hint may rely on > the caller being in the current context so it could be error-prone. > Thus, I just limited hints as MADV_[COLD|PAGEOUT] in this patch. > > If someone want to add other hints, we could hear hear the usecase and > review it for each hint. It's more safe for maintainace rather than > introducing a buggy syscall but hard to fix it later. I have brought this up when we discussed this in the past but there is no reflection on that here so let me bring that up again. I believe that the interface has an inherent problem that it is racy. The external entity needs to know the address space layout of the target process to do anyhing useful on it. The address space is however under the full control of the target process though and the external entity has no means to find out that the layout has changed. So time-to-check-time-to-act is an inherent problem. This is a serious design flaw and it should be explained why it doesn't matter or how to use the interface properly to prevent that problem. -- Michal Hocko SUSE Labs From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Hocko Subject: Re: [PATCH v2 2/5] mm: introduce external memory hinting API Date: Fri, 17 Jan 2020 12:52:25 +0100 Message-ID: <20200117115225.GV19428@dhcp22.suse.cz> References: <20200116235953.163318-1-minchan@kernel.org> <20200116235953.163318-3-minchan@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20200116235953.163318-3-minchan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Minchan Kim Cc: Andrew Morton , LKML , linux-mm , linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, oleksandr-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, Suren Baghdasaryan , Tim Murray , Daniel Colascione , Sandeep Patil , Sonny Rao , Brian Geffon , Johannes Weiner , Shakeel Butt , John Dias , ktkhai-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org, christian.brauner-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org, sjpark-ebkRAfMGSJGzQB+pC5nmwQ@public.gmane.org List-Id: linux-api@vger.kernel.org On Thu 16-01-20 15:59:50, Minchan Kim wrote: > There is usecase that System Management Software(SMS) want to give > a memory hint like MADV_[COLD|PAGEEOUT] to other processes and > in the case of Android, it is the ActivityManagerService. > > It's similar in spirit to madvise(MADV_WONTNEED), but the information > required to make the reclaim decision is not known to the app. Instead, > it is known to the centralized userspace daemon(ActivityManagerService), > and that daemon must be able to initiate reclaim on its own without > any app involvement. > > To solve the issue, this patch introduces new syscall process_madvise(2). > It uses pidfd of an external processs to give the hint. > > int process_madvise(int pidfd, void *addr, size_t length, int advise, > unsigned long flag); > > Since it could affect other process's address range, only privileged > process(CAP_SYS_PTRACE) or something else(e.g., being the same UID) > gives it the right to ptrace the process could use it successfully. > The flag argument is reserved for future use if we need to extend the > API. > > I think supporting all hints madvise has/will supported/support to > process_madvise is rather risky. Because we are not sure all hints make > sense from external process and implementation for the hint may rely on > the caller being in the current context so it could be error-prone. > Thus, I just limited hints as MADV_[COLD|PAGEOUT] in this patch. > > If someone want to add other hints, we could hear hear the usecase and > review it for each hint. It's more safe for maintainace rather than > introducing a buggy syscall but hard to fix it later. I have brought this up when we discussed this in the past but there is no reflection on that here so let me bring that up again. I believe that the interface has an inherent problem that it is racy. The external entity needs to know the address space layout of the target process to do anyhing useful on it. The address space is however under the full control of the target process though and the external entity has no means to find out that the layout has changed. So time-to-check-time-to-act is an inherent problem. This is a serious design flaw and it should be explained why it doesn't matter or how to use the interface properly to prevent that problem. -- Michal Hocko SUSE Labs