From: Petri Latvala <petri.latvala@intel.com>
To: Mika Kahola <mika.kahola@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_lowres: Test only with one plane
Date: Fri, 17 Jan 2020 14:13:05 +0200 [thread overview]
Message-ID: <20200117121305.GT25209@platvala-desk.ger.corp.intel.com> (raw)
In-Reply-To: <20200117091749.1606-1-mika.kahola@intel.com>
On Fri, Jan 17, 2020 at 11:17:49AM +0200, Mika Kahola wrote:
> The test is intended to test resolution changes from higher to
> lower and back. We can test this with only one plane and we don't
> need to run through all planes. This will save significant amount
> of test execution time.
>
> Fix for
> Bugzilla: https://gitlab.freedesktop.org/drm/intel/issues/899
I'm having a hard time understanding how this change fixes this issue.
>
> Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> ---
> tests/kms_plane_lowres.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/kms_plane_lowres.c b/tests/kms_plane_lowres.c
> index 4c3f5636..ee6fb1fb 100644
> --- a/tests/kms_plane_lowres.c
> +++ b/tests/kms_plane_lowres.c
> @@ -208,7 +208,8 @@ test_planes_on_pipe_with_output(data_t *data, enum pipe pipe,
> igt_assert_crc_equal(&data->ref_lowres.crc, &crc_lowres);
>
> igt_plane_set_fb(plane, NULL);
> - tested++;
> + if (tested++)
> + break;
At this point one must ask: Why have the count variable anymore?
--
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-01-17 12:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 9:17 [igt-dev] [PATCH i-g-t] tests/kms_plane_lowres: Test only with one plane Mika Kahola
2020-01-17 10:00 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2020-01-17 12:13 ` Petri Latvala [this message]
2020-01-17 12:44 ` [igt-dev] [PATCH i-g-t] " Kahola, Mika
2020-01-17 13:15 ` Petri Latvala
2020-01-17 14:35 ` Kahola, Mika
2020-01-20 12:02 ` Petri Latvala
2020-01-20 17:19 ` Ville Syrjälä
2020-01-22 8:55 ` Kahola, Mika
2020-01-20 11:39 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200117121305.GT25209@platvala-desk.ger.corp.intel.com \
--to=petri.latvala@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=mika.kahola@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.