From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68607C33CB8 for ; Fri, 17 Jan 2020 12:16:20 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4808F2073A for ; Fri, 17 Jan 2020 12:16:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4808F2073A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B5C4A6F47E; Fri, 17 Jan 2020 12:16:18 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3445B6F43D; Fri, 17 Jan 2020 12:16:17 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jan 2020 04:15:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,330,1574150400"; d="scan'208";a="424443966" Received: from aquilante.fi.intel.com (HELO intel.com) ([10.237.72.158]) by fmsmga005.fm.intel.com with ESMTP; 17 Jan 2020 04:15:48 -0800 Date: Fri, 17 Jan 2020 14:15:50 +0200 From: Andi Shyti To: Zhang Xiaoxu Subject: Re: [PATCH] drm/i915: Fix i915_error_state_store error defination Message-ID: <20200117121550.GA3238@intel.intel> References: <20200117073436.6507-1-zhangxiaoxu5@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200117073436.6507-1-zhangxiaoxu5@huawei.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: airlied@linux.ie, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, rodrigo.vivi@intel.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Zhang, On Fri, Jan 17, 2020 at 03:34:36PM +0800, Zhang Xiaoxu wrote: > Since commit 742379c0c4001 ("drm/i915: Start chopping up the GPU error > capture"), function 'i915_error_state_store' was defined and used with > only one parameter. > > But if no 'CONFIG_DRM_I915_CAPTURE_ERROR', this function was defined > with two parameter. > > This may lead compile error. This patch fix it. > > Reported-by: Hulk Robot I've never been a fan of non human accounts, we had this discussion already in a different mailing list. Could you please find a different way of giving credit to your CI system? > Signed-off-by: Zhang Xiaoxu > --- > drivers/gpu/drm/i915/i915_gpu_error.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_gpu_error.h b/drivers/gpu/drm/i915/i915_gpu_error.h > index 9109004956bd..41c1475e1500 100644 > --- a/drivers/gpu/drm/i915/i915_gpu_error.h > +++ b/drivers/gpu/drm/i915/i915_gpu_error.h > @@ -314,8 +314,7 @@ i915_vma_capture_finish(struct intel_gt_coredump *gt, > } > > static inline void > -i915_error_state_store(struct drm_i915_private *i915, > - struct i915_gpu_coredump *error) > +i915_error_state_store(struct i915_gpu_coredump *error) ouch! that's an oversight. Thanks for your patch, Reviewed-by: Andi Shyti Andi _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E573BC47409 for ; Fri, 17 Jan 2020 12:16:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C58402083E for ; Fri, 17 Jan 2020 12:16:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C58402083E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5B4166F43D; Fri, 17 Jan 2020 12:16:18 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3445B6F43D; Fri, 17 Jan 2020 12:16:17 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jan 2020 04:15:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,330,1574150400"; d="scan'208";a="424443966" Received: from aquilante.fi.intel.com (HELO intel.com) ([10.237.72.158]) by fmsmga005.fm.intel.com with ESMTP; 17 Jan 2020 04:15:48 -0800 Date: Fri, 17 Jan 2020 14:15:50 +0200 From: Andi Shyti To: Zhang Xiaoxu Message-ID: <20200117121550.GA3238@intel.intel> References: <20200117073436.6507-1-zhangxiaoxu5@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200117073436.6507-1-zhangxiaoxu5@huawei.com> Subject: Re: [Intel-gfx] [PATCH] drm/i915: Fix i915_error_state_store error defination X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: airlied@linux.ie, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Zhang, On Fri, Jan 17, 2020 at 03:34:36PM +0800, Zhang Xiaoxu wrote: > Since commit 742379c0c4001 ("drm/i915: Start chopping up the GPU error > capture"), function 'i915_error_state_store' was defined and used with > only one parameter. > > But if no 'CONFIG_DRM_I915_CAPTURE_ERROR', this function was defined > with two parameter. > > This may lead compile error. This patch fix it. > > Reported-by: Hulk Robot I've never been a fan of non human accounts, we had this discussion already in a different mailing list. Could you please find a different way of giving credit to your CI system? > Signed-off-by: Zhang Xiaoxu > --- > drivers/gpu/drm/i915/i915_gpu_error.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_gpu_error.h b/drivers/gpu/drm/i915/i915_gpu_error.h > index 9109004956bd..41c1475e1500 100644 > --- a/drivers/gpu/drm/i915/i915_gpu_error.h > +++ b/drivers/gpu/drm/i915/i915_gpu_error.h > @@ -314,8 +314,7 @@ i915_vma_capture_finish(struct intel_gt_coredump *gt, > } > > static inline void > -i915_error_state_store(struct drm_i915_private *i915, > - struct i915_gpu_coredump *error) > +i915_error_state_store(struct i915_gpu_coredump *error) ouch! that's an oversight. Thanks for your patch, Reviewed-by: Andi Shyti Andi _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx