From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 139D6C33CB1 for ; Fri, 17 Jan 2020 12:34:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DAFBE2072B for ; Fri, 17 Jan 2020 12:34:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BbEl2ga7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728826AbgAQMeH (ORCPT ); Fri, 17 Jan 2020 07:34:07 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:57329 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726991AbgAQMeG (ORCPT ); Fri, 17 Jan 2020 07:34:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579264445; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=n6noiswpldg3fHomtpJXeotHAxwJmLIHoQgf83pfhEE=; b=BbEl2ga7E79fTmOKwavNOOnQphc30p+5fxW4HSC2AYJex16MuQASo7MqJ0WlvVGWHPpZ1H DFqp5OcLxV2Qga5SnmwjAzV8sCnOuEVB2UbrHJfLhTrT/5vjv4y1N/O0SeIdLURn7ZN02/ c+SJi+d6iBykgJHBSXuowKt1OKEhifc= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-204-mXKpx-TiOIKZ3Al0tTub0A-1; Fri, 17 Jan 2020 07:34:04 -0500 X-MC-Unique: mXKpx-TiOIKZ3Al0tTub0A-1 Received: by mail-wr1-f71.google.com with SMTP id v17so10428161wrm.17 for ; Fri, 17 Jan 2020 04:34:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=n6noiswpldg3fHomtpJXeotHAxwJmLIHoQgf83pfhEE=; b=sZ+dk9ZN/RzIsuspsJmNrZWaLMCnJFh2tUBUPuru9iH3zdcohaC6RLPzJJFpXt+A4F AHaYML+bFTYH+qlFQoYr1KkaJ2xnR6DxA3wujbimmcQZdygXUuKa06KiFbKQUmXw/cG0 IKVDqBnUah1DoQTlcOPQtKUgUTbv2ysWVVhjtt/wAYfIcRpZhd56j3T1MZv07XNlgxWZ Drtdi7IwY5KqVOkJMGrzLlZWd4bP/yRiDMa1nj8xVFy+rDPsPAkd2xAOwBVNrOHm2cDU /q3KieptWwpvlcAA1rHZPmJ2FmJ7YF7W/I9Gi5cUGRpDLk2DEF9ZHoeY+pmH7PIYidq2 B/cg== X-Gm-Message-State: APjAAAVBHOIcdUe8cq2PvZYPjQPAcTcmOOKAZ6O1o1jBfO7+MgB1kZbr xwyAJbRnId8NGMW7ltALuN54YKuwLwa/4AsGyh0xiTe2TMlLeMoxCd2dw3iWxXKu5OrkvxPJOTP rr/NLSZkbIQfYQNJfPhiRhLEV X-Received: by 2002:adf:df83:: with SMTP id z3mr2783914wrl.389.1579264442699; Fri, 17 Jan 2020 04:34:02 -0800 (PST) X-Google-Smtp-Source: APXvYqyXrFbb1XX82iYVpnh0BdWbZbvio6PUNm045gC9KyuT7ceLT/vO7ufARgEZP9im72FHYd9BGQ== X-Received: by 2002:adf:df83:: with SMTP id z3mr2783892wrl.389.1579264442359; Fri, 17 Jan 2020 04:34:02 -0800 (PST) Received: from localhost (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id n3sm4655448wmc.27.2020.01.17.04.34.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jan 2020 04:34:01 -0800 (PST) Date: Fri, 17 Jan 2020 13:34:00 +0100 From: Oleksandr Natalenko To: Kirill Tkhai Cc: Minchan Kim , Andrew Morton , LKML , linux-mm , linux-api@vger.kernel.org, Suren Baghdasaryan , Tim Murray , Daniel Colascione , Sandeep Patil , Sonny Rao , Brian Geffon , Michal Hocko , Johannes Weiner , Shakeel Butt , John Dias , christian.brauner@ubuntu.com, sjpark@amazon.de, Minchan Kim Subject: Re: [PATCH v2 4/5] mm/madvise: allow KSM hints for remote API Message-ID: <20200117123400.o3ne6kazkovq4okd@butterfly.localdomain> References: <20200116235953.163318-1-minchan@kernel.org> <20200116235953.163318-5-minchan@kernel.org> <37338e14-5a55-1926-b6c1-5f98b6a6fdb5@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <37338e14-5a55-1926-b6c1-5f98b6a6fdb5@virtuozzo.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi. On Fri, Jan 17, 2020 at 01:13:14PM +0300, Kirill Tkhai wrote: > On 17.01.2020 02:59, Minchan Kim wrote: > > From: Oleksandr Natalenko > > > > It all began with the fact that KSM works only on memory that is marked > > by madvise(). And the only way to get around that is to either: > > > > * use LD_PRELOAD; or > > * patch the kernel with something like UKSM or PKSM. > > > > (i skip ptrace can of worms here intentionally) > > > > To overcome this restriction, lets employ a new remote madvise API. This > > can be used by some small userspace helper daemon that will do auto-KSM > > job for us. > > > > I think of two major consumers of remote KSM hints: > > > > * hosts, that run containers, especially similar ones and especially in > > a trusted environment, sharing the same runtime like Node.js; > > > > * heavy applications, that can be run in multiple instances, not > > limited to opensource ones like Firefox, but also those that cannot be > > modified since they are binary-only and, maybe, statically linked. > > > > Speaking of statistics, more numbers can be found in the very first > > submission, that is related to this one [1]. For my current setup with > > two Firefox instances I get 100 to 200 MiB saved for the second instance > > depending on the amount of tabs. > > > > 1 FF instance with 15 tabs: > > > > $ echo "$(cat /sys/kernel/mm/ksm/pages_sharing) * 4 / 1024" | bc > > 410 > > > > 2 FF instances, second one has 12 tabs (all the tabs are different): > > > > $ echo "$(cat /sys/kernel/mm/ksm/pages_sharing) * 4 / 1024" | bc > > 592 > > > > At the very moment I do not have specific numbers for containerised > > workload, but those should be comparable in case the containers share > > similar/same runtime. > > > > [1] https://lore.kernel.org/patchwork/patch/1012142/ > > > > Signed-off-by: Oleksandr Natalenko > > Signed-off-by: Minchan Kim > > --- > > mm/madvise.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/mm/madvise.c b/mm/madvise.c > > index 84cffd0900f1..89557998d287 100644 > > --- a/mm/madvise.c > > +++ b/mm/madvise.c > > @@ -1000,6 +1000,8 @@ process_madvise_behavior_valid(int behavior) > > switch (behavior) { > > case MADV_COLD: > > case MADV_PAGEOUT: > > + case MADV_MERGEABLE: > > + case MADV_UNMERGEABLE: > > return true; > > default: > > return false; > > Remote madvise on KSM parameters should be OK. > > One thing is madvise_behavior_valid() places MADV_MERGEABLE/UNMERGEABLE > in #ifdef brackes, so -EINVAL is returned by madvise() syscall if KSM > is not enabled. Here we should follow the same way for symmetry. > Thanks for the suggestion. Minchan, shall you adopt it directly, or I should send a separate patch? -- Best regards, Oleksandr Natalenko (post-factum) Senior Software Maintenance Engineer From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oleksandr Natalenko Subject: Re: [PATCH v2 4/5] mm/madvise: allow KSM hints for remote API Date: Fri, 17 Jan 2020 13:34:00 +0100 Message-ID: <20200117123400.o3ne6kazkovq4okd@butterfly.localdomain> References: <20200116235953.163318-1-minchan@kernel.org> <20200116235953.163318-5-minchan@kernel.org> <37338e14-5a55-1926-b6c1-5f98b6a6fdb5@virtuozzo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <37338e14-5a55-1926-b6c1-5f98b6a6fdb5-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Kirill Tkhai Cc: Minchan Kim , Andrew Morton , LKML , linux-mm , linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Suren Baghdasaryan , Tim Murray , Daniel Colascione , Sandeep Patil , Sonny Rao , Brian Geffon , Michal Hocko , Johannes Weiner , Shakeel Butt , John Dias , christian.brauner-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org, sjpark-ebkRAfMGSJGzQB+pC5nmwQ@public.gmane.org, Minchan Kim List-Id: linux-api@vger.kernel.org Hi. On Fri, Jan 17, 2020 at 01:13:14PM +0300, Kirill Tkhai wrote: > On 17.01.2020 02:59, Minchan Kim wrote: > > From: Oleksandr Natalenko > > > > It all began with the fact that KSM works only on memory that is marked > > by madvise(). And the only way to get around that is to either: > > > > * use LD_PRELOAD; or > > * patch the kernel with something like UKSM or PKSM. > > > > (i skip ptrace can of worms here intentionally) > > > > To overcome this restriction, lets employ a new remote madvise API. This > > can be used by some small userspace helper daemon that will do auto-KSM > > job for us. > > > > I think of two major consumers of remote KSM hints: > > > > * hosts, that run containers, especially similar ones and especially in > > a trusted environment, sharing the same runtime like Node.js; > > > > * heavy applications, that can be run in multiple instances, not > > limited to opensource ones like Firefox, but also those that cannot be > > modified since they are binary-only and, maybe, statically linked. > > > > Speaking of statistics, more numbers can be found in the very first > > submission, that is related to this one [1]. For my current setup with > > two Firefox instances I get 100 to 200 MiB saved for the second instance > > depending on the amount of tabs. > > > > 1 FF instance with 15 tabs: > > > > $ echo "$(cat /sys/kernel/mm/ksm/pages_sharing) * 4 / 1024" | bc > > 410 > > > > 2 FF instances, second one has 12 tabs (all the tabs are different): > > > > $ echo "$(cat /sys/kernel/mm/ksm/pages_sharing) * 4 / 1024" | bc > > 592 > > > > At the very moment I do not have specific numbers for containerised > > workload, but those should be comparable in case the containers share > > similar/same runtime. > > > > [1] https://lore.kernel.org/patchwork/patch/1012142/ > > > > Signed-off-by: Oleksandr Natalenko > > Signed-off-by: Minchan Kim > > --- > > mm/madvise.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/mm/madvise.c b/mm/madvise.c > > index 84cffd0900f1..89557998d287 100644 > > --- a/mm/madvise.c > > +++ b/mm/madvise.c > > @@ -1000,6 +1000,8 @@ process_madvise_behavior_valid(int behavior) > > switch (behavior) { > > case MADV_COLD: > > case MADV_PAGEOUT: > > + case MADV_MERGEABLE: > > + case MADV_UNMERGEABLE: > > return true; > > default: > > return false; > > Remote madvise on KSM parameters should be OK. > > One thing is madvise_behavior_valid() places MADV_MERGEABLE/UNMERGEABLE > in #ifdef brackes, so -EINVAL is returned by madvise() syscall if KSM > is not enabled. Here we should follow the same way for symmetry. > Thanks for the suggestion. Minchan, shall you adopt it directly, or I should send a separate patch? -- Best regards, Oleksandr Natalenko (post-factum) Senior Software Maintenance Engineer