From: Rob Herring <robh@kernel.org>
To: Amelie Delaunay <amelie.delaunay@st.com>
Cc: Minas Harutyunyan <hminas@synopsys.com>,
Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
Fabrice Gasnier <fabrice.gasnier@st.com>,
Benjamin Gaignard <benjamin.gaignard@st.com>
Subject: Re: [PATCHv2 1/2] dt-bindings: usb: dwc2: add support for STM32MP15 SoCs USB OTG HS and FS
Date: Fri, 17 Jan 2020 08:48:37 -0600 [thread overview]
Message-ID: <20200117144837.GA27455@bogus> (raw)
In-Reply-To: <20200116144524.16070-2-amelie.delaunay@st.com>
On Thu, Jan 16, 2020 at 03:45:23PM +0100, Amelie Delaunay wrote:
> Add the specific compatible string for the DWC2 IP found in the STM32MP15
> SoCs.
> STM32MP15 SoCs uses sensing comparators to detect Vbus valid levels and
> ID pin state. usb33d-supply described the regulator supplying Vbus and ID
> sensing comparators.
>
> Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
> ---
> Documentation/devicetree/bindings/usb/dwc2.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/dwc2.yaml b/Documentation/devicetree/bindings/usb/dwc2.yaml
> index 71cf7ba32237..0b86250b97a9 100644
> --- a/Documentation/devicetree/bindings/usb/dwc2.yaml
> +++ b/Documentation/devicetree/bindings/usb/dwc2.yaml
> @@ -58,6 +58,8 @@ properties:
> - const: st,stm32f4x9-fsotg
> - const: st,stm32f4x9-hsotg
> - const: st,stm32f7-hsotg
> + - const: st,stm32mp15-fsotg
> + - const: st,stm32mp15-hsotg
> - const: samsung,s3c6400-hsotg
>
> reg:
> @@ -103,6 +105,10 @@ properties:
> vusb_a-supply:
> description: phandle to voltage regulator of analog section.
>
> + vusb33d_supply:
Not a valid regulator property.
> + description: reference to the external VBUS and ID sensing comparators, in
> + order to perform OTG operation, used on STM32MP15 SoCs.
Are they external or part of the SoC? When we have Vbus sense and ID
GPIOs, those go in the connector node, so this probably should too if
these are board components.
Rob
next prev parent reply other threads:[~2020-01-17 14:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 14:45 [PATCHv2 0/2] USB DWC2 support for STM32MP15 SoCs USB OTG Amelie Delaunay
2020-01-16 14:45 ` [PATCHv2 1/2] dt-bindings: usb: dwc2: add support for STM32MP15 SoCs USB OTG HS and FS Amelie Delaunay
2020-01-17 14:48 ` Rob Herring [this message]
2020-01-17 15:24 ` Amelie DELAUNAY
2020-01-16 14:45 ` [PATCHv2 2/2] " Amelie Delaunay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200117144837.GA27455@bogus \
--to=robh@kernel.org \
--cc=amelie.delaunay@st.com \
--cc=balbi@kernel.org \
--cc=benjamin.gaignard@st.com \
--cc=devicetree@vger.kernel.org \
--cc=fabrice.gasnier@st.com \
--cc=gregkh@linuxfoundation.org \
--cc=hminas@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.