From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77879C33CB1 for ; Fri, 17 Jan 2020 15:13:30 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 533EA20842 for ; Fri, 17 Jan 2020 15:13:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 533EA20842 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E662F6F5DA; Fri, 17 Jan 2020 15:13:29 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7AD6E6F5DA for ; Fri, 17 Jan 2020 15:13:28 +0000 (UTC) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jan 2020 07:13:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,330,1574150400"; d="scan'208";a="220751512" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by fmsmga008.fm.intel.com with SMTP; 17 Jan 2020 07:13:26 -0800 Received: by stinkbox (sSMTP sendmail emulation); Fri, 17 Jan 2020 17:13:25 +0200 Date: Fri, 17 Jan 2020 17:13:25 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Jani Nikula Message-ID: <20200117151325.GQ13686@intel.com> References: <4338a29e4ed49e69f859dff1490fd85f6ae6177e.1579270868.git.jani.nikula@intel.com> <20200117151238.GP13686@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200117151238.GP13686@intel.com> X-Patchwork-Hint: comment User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [PATCH 8/9] drm/i915/bios: check port presence based on child device X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, Jan 17, 2020 at 05:12:38PM +0200, Ville Syrj=E4l=E4 wrote: > On Fri, Jan 17, 2020 at 04:29:28PM +0200, Jani Nikula wrote: > > Affects only two calls in output setup, and ddi init will check the > > features in more fine grained way. > > = > > This will make future changes easier. > > = > > Signed-off-by: Jani Nikula > > --- > > drivers/gpu/drm/i915/display/intel_bios.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > = > > diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/dr= m/i915/display/intel_bios.c > > index 4c69253739ec..70fb87e7afb6 100644 > > --- a/drivers/gpu/drm/i915/display/intel_bios.c > > +++ b/drivers/gpu/drm/i915/display/intel_bios.c > > @@ -2236,9 +2236,7 @@ bool intel_bios_is_port_present(struct drm_i915_p= rivate *dev_priv, enum port por > > const struct ddi_vbt_port_info *port_info =3D > > &dev_priv->vbt.ddi_port_info[port]; > > = > > - return port_info->supports_dp || > > - port_info->supports_dvi || > > - port_info->supports_hdmi; > > + return port_info->child; > = > Pondering what happens if there's a non-DP/DVI/HDMI port declared in the > VBT... I guess those should not have their dvo port set to anything we > accept? Umm, no. We accept DVO_PORT_CRT as PORT_E. > = > > } > > = > > /* FIXME maybe deal with port A as well? */ > > -- = > > 2.20.1 > > = > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx > = > -- = > Ville Syrj=E4l=E4 > Intel -- = Ville Syrj=E4l=E4 Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx