All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <arnaldo.melo-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Yulia Kartseva <hex-b10kYP2dOMg@public.gmane.org>
Cc: dwarves-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/2] pahole: fix compiler warning
Date: Fri, 17 Jan 2020 13:28:26 -0300	[thread overview]
Message-ID: <20200117162826.GA21253@kernel.org> (raw)
In-Reply-To: <d0b9a8c3bd459fb41f9b4dfb80d5a5972b5c2949.1579221668.git.hex-b10kYP2dOMg@public.gmane.org>

Em Thu, Jan 16, 2020 at 04:59:12PM -0800, Yulia Kartseva escreveu:
> From: Julia Kartseva <hex-b10kYP2dOMg@public.gmane.org>
> 
> Signed-off-by: Julia Kartseva <hex-b10kYP2dOMg@public.gmane.org>
> ---
>  pahole.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/pahole.c b/pahole.c
> index 829c9ab..7ac49c2 100644
> --- a/pahole.c
> +++ b/pahole.c
> @@ -684,8 +684,8 @@ static void print_structs_with_pointer_to(struct cu *cu, uint32_t type)
>  	uint32_t id;
>  
>  	cu__for_each_struct_or_union(cu, id, pos) {
> +		struct structure *str = NULL;
>  		bool looked = false;
> -		struct structure *str;

I just fixed this one after trying to build it on RHEL7, thanks!

https://git.kernel.org/pub/scm/devel/pahole/pahole.git/commit/?id=9b09f578b7d1e75cf168e9b3098d4fb17504f26e

- Arnaldo
  
>  		if (pos->type.namespace.name == 0)
>  			continue;
> -- 
> 2.17.1
> 

-- 

- Arnaldo

  parent reply	other threads:[~2020-01-17 16:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-17  0:59 [PATCH 0/2] pahole: fix maybe-uninitialized and rpm build Yulia Kartseva
     [not found] ` <cover.1579221668.git.hex-b10kYP2dOMg@public.gmane.org>
2020-01-17  0:59   ` [PATCH 1/2] pahole: fix compiler warning Yulia Kartseva
     [not found]     ` <d0b9a8c3bd459fb41f9b4dfb80d5a5972b5c2949.1579221668.git.hex-b10kYP2dOMg@public.gmane.org>
2020-01-17 16:28       ` Arnaldo Carvalho de Melo [this message]
2020-01-17  0:59   ` [PATCH 2/2] pahole: fix changelog date in dwarves.spec Yulia Kartseva
     [not found]     ` <e454b36160ba6cdc0fede26ca2ee8fe15314ae99.1579221668.git.hex-b10kYP2dOMg@public.gmane.org>
2020-01-17 16:31       ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200117162826.GA21253@kernel.org \
    --to=arnaldo.melo-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=dwarves-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=hex-b10kYP2dOMg@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.