All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Andi Kleen <ak@linux.intel.com>
Cc: roman.sudarikov@linux.intel.com, peterz@infradead.org,
	mingo@redhat.com, acme@kernel.org, mark.rutland@arm.com,
	alexander.shishkin@linux.intel.com, jolsa@redhat.com,
	namhyung@kernel.org, linux-kernel@vger.kernel.org,
	eranian@google.com, bgregg@netflix.com,
	kan.liang@linux.intel.com, alexander.antonov@intel.com
Subject: Re: [PATCH v4 2/2] perf x86: Exposing an Uncore unit to PMON for Intel Xeon® server platform
Date: Fri, 17 Jan 2020 17:54:06 +0100	[thread overview]
Message-ID: <20200117165406.GA1937954@kroah.com> (raw)
In-Reply-To: <20200117162357.GK302770@tassilo.jf.intel.com>

On Fri, Jan 17, 2020 at 08:23:57AM -0800, Andi Kleen wrote:
> > I thought I was nice and gentle last time and said that this was a
> > really bad idea and you would fix it up.  That didn't happen, so I am
> > being explicit here, THIS IS NOT AN ACCEPTABLE FILE OUTPUT FOR A SYSFS
> > FILE.
> 
> Could you suggest how such a 1:N mapping should be expressed instead in
> sysfs?

I have yet to figure out what it is you all are trying to express here
given a lack of Documentation/ABI/ file :)

But again, sysfs is ONE VALUE PER FILE.  You have a list of items here,
that is bounded only by the number of devices in the system at the
moment.  That number will go up in time, as we all know.  So this is
just not going to work at all as-is.

greg k-h

  reply	other threads:[~2020-01-17 16:54 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-17 13:37 [PATCH v4 0/2] perf x86: Exposing IO stack to IO PMON mapping through sysfs roman.sudarikov
2020-01-17 13:37 ` [PATCH v4 1/2] perf x86: Infrastructure for exposing an Uncore unit to PMON mapping roman.sudarikov
2020-01-17 14:16   ` Greg KH
2020-01-17 13:37 ` [PATCH v4 2/2] perf x86: Exposing an Uncore unit to PMON for Intel Xeon® server platform roman.sudarikov
2020-01-17 14:19   ` Greg KH
2020-01-17 16:23     ` Andi Kleen
2020-01-17 16:54       ` Greg KH [this message]
2020-01-17 17:27         ` Andi Kleen
2020-01-17 18:42           ` Greg KH
2020-01-17 19:12             ` Andi Kleen
2020-01-17 23:03               ` Greg KH
2020-01-17 23:21                 ` Andi Kleen
2020-01-21 16:15         ` Sudarikov, Roman
2020-01-21 17:15           ` Greg KH
2020-01-28 14:55             ` Sudarikov, Roman
2020-01-28 20:19               ` Liang, Kan
2020-01-17 14:14 ` [PATCH v4 0/2] perf x86: Exposing IO stack to IO PMON mapping through sysfs Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200117165406.GA1937954@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=alexander.antonov@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=bgregg@netflix.com \
    --cc=eranian@google.com \
    --cc=jolsa@redhat.com \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=roman.sudarikov@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.