All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: allwinner: a64: Add gpio bank supply for A64-Olinuxino
@ 2020-01-16 19:46 ` Emmanuel Vadot
  0 siblings, 0 replies; 5+ messages in thread
From: Emmanuel Vadot @ 2020-01-16 19:46 UTC (permalink / raw)
  To: mripard, wens, robh+dt, mark.rutland
  Cc: linux-arm-kernel, devicetree, linux-kernel, Emmanuel Vadot

Add the regulators for each bank on this boards.

Signed-off-by: Emmanuel Vadot <manu@freebsd.org>
---
 .../boot/dts/allwinner/sun50i-a64-olinuxino.dts   | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
index 01a9a52edae4..1a25abf6065c 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
@@ -163,6 +163,17 @@ &ohci1 {
 	status = "okay";
 };
 
+&pio {
+	vcc-pa-supply = <&reg_dcdc1>;
+	vcc-pb-supply = <&reg_dcdc1>;
+	vcc-pc-supply = <&reg_dcdc1>;
+	vcc-pd-supply = <&reg_dcdc1>;
+	vcc-pe-supply = <&reg_aldo1>;
+	vcc-pf-supply = <&reg_dcdc1>;
+	vcc-pg-supply = <&reg_dldo4>;
+	vcc-ph-supply = <&reg_dcdc1>;
+};
+
 &r_rsb {
 	status = "okay";
 
@@ -175,6 +186,10 @@ axp803: pmic@3a3 {
 	};
 };
 
+&r_pio {
+	vcc-pl-supply = <&reg_aldo2>;
+};
+
 #include "axp803.dtsi"
 
 &ac_power_supply {
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH] arm64: dts: allwinner: a64: Add gpio bank supply for A64-Olinuxino
@ 2020-01-16 19:46 ` Emmanuel Vadot
  0 siblings, 0 replies; 5+ messages in thread
From: Emmanuel Vadot @ 2020-01-16 19:46 UTC (permalink / raw)
  To: mripard, wens, robh+dt, mark.rutland
  Cc: Emmanuel Vadot, devicetree, linux-kernel, linux-arm-kernel

Add the regulators for each bank on this boards.

Signed-off-by: Emmanuel Vadot <manu@freebsd.org>
---
 .../boot/dts/allwinner/sun50i-a64-olinuxino.dts   | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
index 01a9a52edae4..1a25abf6065c 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
@@ -163,6 +163,17 @@ &ohci1 {
 	status = "okay";
 };
 
+&pio {
+	vcc-pa-supply = <&reg_dcdc1>;
+	vcc-pb-supply = <&reg_dcdc1>;
+	vcc-pc-supply = <&reg_dcdc1>;
+	vcc-pd-supply = <&reg_dcdc1>;
+	vcc-pe-supply = <&reg_aldo1>;
+	vcc-pf-supply = <&reg_dcdc1>;
+	vcc-pg-supply = <&reg_dldo4>;
+	vcc-ph-supply = <&reg_dcdc1>;
+};
+
 &r_rsb {
 	status = "okay";
 
@@ -175,6 +186,10 @@ axp803: pmic@3a3 {
 	};
 };
 
+&r_pio {
+	vcc-pl-supply = <&reg_aldo2>;
+};
+
 #include "axp803.dtsi"
 
 &ac_power_supply {
-- 
2.24.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: a64: Add gpio bank supply for A64-Olinuxino
  2020-01-16 19:46 ` Emmanuel Vadot
@ 2020-01-17  3:20   ` Chen-Yu Tsai
  -1 siblings, 0 replies; 5+ messages in thread
From: Chen-Yu Tsai @ 2020-01-17  3:20 UTC (permalink / raw)
  To: Emmanuel Vadot
  Cc: Maxime Ripard, Rob Herring, Mark Rutland, devicetree,
	linux-kernel, linux-arm-kernel

On Fri, Jan 17, 2020 at 3:47 AM Emmanuel Vadot <manu@freebsd.org> wrote:
>
> Add the regulators for each bank on this boards.
>
> Signed-off-by: Emmanuel Vadot <manu@freebsd.org>
> ---
>  .../boot/dts/allwinner/sun50i-a64-olinuxino.dts   | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> index 01a9a52edae4..1a25abf6065c 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> @@ -163,6 +163,17 @@ &ohci1 {
>         status = "okay";
>  };
>
> +&pio {
> +       vcc-pa-supply = <&reg_dcdc1>;
> +       vcc-pb-supply = <&reg_dcdc1>;
> +       vcc-pc-supply = <&reg_dcdc1>;
> +       vcc-pd-supply = <&reg_dcdc1>;
> +       vcc-pe-supply = <&reg_aldo1>;
> +       vcc-pf-supply = <&reg_dcdc1>;
> +       vcc-pg-supply = <&reg_dldo4>;
> +       vcc-ph-supply = <&reg_dcdc1>;
> +};
> +
>  &r_rsb {
>         status = "okay";
>
> @@ -175,6 +186,10 @@ axp803: pmic@3a3 {
>         };
>  };
>
> +&r_pio {
> +       vcc-pl-supply = <&reg_aldo2>;

This is likely going to cause a circular dependency, because the RSB
interface that is used to talk to the PMIC is also on the PL pins.

(How does FreeBSD deal with this?)

Instead, just add a comment describing what is really used, and set
the regulator to always-on, which should already be the case.

ChenYu

> +};
> +
>  #include "axp803.dtsi"
>
>  &ac_power_supply {
> --
> 2.24.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: a64: Add gpio bank supply for A64-Olinuxino
@ 2020-01-17  3:20   ` Chen-Yu Tsai
  0 siblings, 0 replies; 5+ messages in thread
From: Chen-Yu Tsai @ 2020-01-17  3:20 UTC (permalink / raw)
  To: Emmanuel Vadot
  Cc: Mark Rutland, devicetree, linux-kernel, Maxime Ripard,
	Rob Herring, linux-arm-kernel

On Fri, Jan 17, 2020 at 3:47 AM Emmanuel Vadot <manu@freebsd.org> wrote:
>
> Add the regulators for each bank on this boards.
>
> Signed-off-by: Emmanuel Vadot <manu@freebsd.org>
> ---
>  .../boot/dts/allwinner/sun50i-a64-olinuxino.dts   | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> index 01a9a52edae4..1a25abf6065c 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> @@ -163,6 +163,17 @@ &ohci1 {
>         status = "okay";
>  };
>
> +&pio {
> +       vcc-pa-supply = <&reg_dcdc1>;
> +       vcc-pb-supply = <&reg_dcdc1>;
> +       vcc-pc-supply = <&reg_dcdc1>;
> +       vcc-pd-supply = <&reg_dcdc1>;
> +       vcc-pe-supply = <&reg_aldo1>;
> +       vcc-pf-supply = <&reg_dcdc1>;
> +       vcc-pg-supply = <&reg_dldo4>;
> +       vcc-ph-supply = <&reg_dcdc1>;
> +};
> +
>  &r_rsb {
>         status = "okay";
>
> @@ -175,6 +186,10 @@ axp803: pmic@3a3 {
>         };
>  };
>
> +&r_pio {
> +       vcc-pl-supply = <&reg_aldo2>;

This is likely going to cause a circular dependency, because the RSB
interface that is used to talk to the PMIC is also on the PL pins.

(How does FreeBSD deal with this?)

Instead, just add a comment describing what is really used, and set
the regulator to always-on, which should already be the case.

ChenYu

> +};
> +
>  #include "axp803.dtsi"
>
>  &ac_power_supply {
> --
> 2.24.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: a64: Add gpio bank supply for A64-Olinuxino
  2020-01-17  3:20   ` Chen-Yu Tsai
  (?)
@ 2020-01-18 14:27   ` Emmanuel Vadot
  -1 siblings, 0 replies; 5+ messages in thread
From: Emmanuel Vadot @ 2020-01-18 14:27 UTC (permalink / raw)
  To: Chen-Yu Tsai
  Cc: Emmanuel Vadot, Mark Rutland, devicetree, linux-kernel,
	Maxime Ripard, Rob Herring, linux-arm-kernel

On Fri, 17 Jan 2020 11:20:21 +0800
Chen-Yu Tsai <wens@csie.org> wrote:

> On Fri, Jan 17, 2020 at 3:47 AM Emmanuel Vadot <manu@freebsd.org> wrote:
> >
> > Add the regulators for each bank on this boards.
> >
> > Signed-off-by: Emmanuel Vadot <manu@freebsd.org>
> > ---
> >  .../boot/dts/allwinner/sun50i-a64-olinuxino.dts   | 15 +++++++++++++++
> >  1 file changed, 15 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> > index 01a9a52edae4..1a25abf6065c 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> > @@ -163,6 +163,17 @@ &ohci1 {
> >         status = "okay";
> >  };
> >
> > +&pio {
> > +       vcc-pa-supply = <&reg_dcdc1>;
> > +       vcc-pb-supply = <&reg_dcdc1>;
> > +       vcc-pc-supply = <&reg_dcdc1>;
> > +       vcc-pd-supply = <&reg_dcdc1>;
> > +       vcc-pe-supply = <&reg_aldo1>;
> > +       vcc-pf-supply = <&reg_dcdc1>;
> > +       vcc-pg-supply = <&reg_dldo4>;
> > +       vcc-ph-supply = <&reg_dcdc1>;
> > +};
> > +
> >  &r_rsb {
> >         status = "okay";
> >
> > @@ -175,6 +186,10 @@ axp803: pmic@3a3 {
> >         };
> >  };
> >
> > +&r_pio {
> > +       vcc-pl-supply = <&reg_aldo2>;
> 
> This is likely going to cause a circular dependency, because the RSB
> interface that is used to talk to the PMIC is also on the PL pins.

 Indeed that cause a Linux kernel to not boot at all.

> (How does FreeBSD deal with this?)

 We don't deal with vcc-X-supply until later in the boot, this is not
ideal but better than not dealing with them.

> Instead, just add a comment describing what is really used, and set
> the regulator to always-on, which should already be the case.

 Ok will do,

Thanks.

> ChenYu
> 
> > +};
> > +
> >  #include "axp803.dtsi"
> >
> >  &ac_power_supply {
> > --
> > 2.24.1
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel


-- 
Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-01-18 14:34 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-16 19:46 [PATCH] arm64: dts: allwinner: a64: Add gpio bank supply for A64-Olinuxino Emmanuel Vadot
2020-01-16 19:46 ` Emmanuel Vadot
2020-01-17  3:20 ` Chen-Yu Tsai
2020-01-17  3:20   ` Chen-Yu Tsai
2020-01-18 14:27   ` Emmanuel Vadot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.