* [PATCH] arch/x86/kernel/tsc_sync.c: Clean up code by removing unused assignment
@ 2020-01-18 17:11 mateusznosek0
2020-01-22 13:02 ` [tip: x86/cleanups] x86/tsc: Remove redundant assignment tip-bot2 for Mateusz Nosek
0 siblings, 1 reply; 2+ messages in thread
From: mateusznosek0 @ 2020-01-18 17:11 UTC (permalink / raw)
To: linux-kernel; +Cc: Mateusz Nosek, x86, hpa, bp, mingo, tglx
From: Mateusz Nosek <mateusznosek0@gmail.com>
Previously the assignment to local variable 'now' took place before the for
loop. The loop is unconditional so it will be entered at least once. The
variable 'now' is reassigned in the loop and is not used before reassigning.
Therefore the assignment before the loop is unnecessary and can be removed.
Signed-off-by: Mateusz Nosek <mateusznosek0@gmail.com>
---
arch/x86/kernel/tsc_sync.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/x86/kernel/tsc_sync.c b/arch/x86/kernel/tsc_sync.c
index b8acf639abd1..32a818764e03 100644
--- a/arch/x86/kernel/tsc_sync.c
+++ b/arch/x86/kernel/tsc_sync.c
@@ -233,7 +233,6 @@ static cycles_t check_tsc_warp(unsigned int timeout)
* The measurement runs for 'timeout' msecs:
*/
end = start + (cycles_t) tsc_khz * timeout;
- now = start;
for (i = 0; ; i++) {
/*
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip: x86/cleanups] x86/tsc: Remove redundant assignment
2020-01-18 17:11 [PATCH] arch/x86/kernel/tsc_sync.c: Clean up code by removing unused assignment mateusznosek0
@ 2020-01-22 13:02 ` tip-bot2 for Mateusz Nosek
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot2 for Mateusz Nosek @ 2020-01-22 13:02 UTC (permalink / raw)
To: linux-tip-commits; +Cc: Mateusz Nosek, Borislav Petkov, x86, LKML
The following commit has been merged into the x86/cleanups branch of tip:
Commit-ID: 4144fddbd3932b59370e6e279002991c3e2b2fc6
Gitweb: https://git.kernel.org/tip/4144fddbd3932b59370e6e279002991c3e2b2fc6
Author: Mateusz Nosek <mateusznosek0@gmail.com>
AuthorDate: Sat, 18 Jan 2020 18:11:43 +01:00
Committer: Borislav Petkov <bp@suse.de>
CommitterDate: Wed, 22 Jan 2020 13:52:42 +01:00
x86/tsc: Remove redundant assignment
Previously, the assignment to the local variable 'now' took place
before the for loop. The loop is unconditional so it will be entered
at least once. The variable 'now' is reassigned in the loop and is not
used before reassigning. Therefore, the assignment before the loop is
unnecessary and can be removed.
No code changed:
# arch/x86/kernel/tsc_sync.o:
text data bss dec hex filename
3569 198 44 3811 ee3 tsc_sync.o.before
3569 198 44 3811 ee3 tsc_sync.o.after
md5:
36216de29b208edbcd34fed9fe7f7b69 tsc_sync.o.before.asm
36216de29b208edbcd34fed9fe7f7b69 tsc_sync.o.after.asm
[ bp: Massage commit message. ]
Signed-off-by: Mateusz Nosek <mateusznosek0@gmail.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Link: https://lkml.kernel.org/r/20200118171143.25178-1-mateusznosek0@gmail.com
---
arch/x86/kernel/tsc_sync.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/x86/kernel/tsc_sync.c b/arch/x86/kernel/tsc_sync.c
index b8acf63..32a8187 100644
--- a/arch/x86/kernel/tsc_sync.c
+++ b/arch/x86/kernel/tsc_sync.c
@@ -233,7 +233,6 @@ static cycles_t check_tsc_warp(unsigned int timeout)
* The measurement runs for 'timeout' msecs:
*/
end = start + (cycles_t) tsc_khz * timeout;
- now = start;
for (i = 0; ; i++) {
/*
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-22 13:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-18 17:11 [PATCH] arch/x86/kernel/tsc_sync.c: Clean up code by removing unused assignment mateusznosek0
2020-01-22 13:02 ` [tip: x86/cleanups] x86/tsc: Remove redundant assignment tip-bot2 for Mateusz Nosek
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.