From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH] arm: Enable VIDEO_BPP32 on pinebook.
Date: Sat, 18 Jan 2020 17:00:52 -0500 [thread overview]
Message-ID: <20200118220052.GM8732@bill-the-cat> (raw)
In-Reply-To: <8736ccr0qx.fsf@ponder>
On Sat, Jan 18, 2020 at 12:03:02PM -0800, Vagrant Cascadian wrote:
> On 2020-01-18, Maxime Ripard wrote:
> > On Sat, Jan 18, 2020 at 03:15:15AM -0800, Vagrant Cascadian wrote:
> >> Video output on the pinebook LCD screen was broken by:
> >>
> >> commit 2cc393f32fd9 ("video: make BPP and ANSI configs optional").
> >>
> >> Enable VIDEO_BPP32 which was previously enabled by default when
> >> DM_VIDEO was set.
> >>
> >> Signed-off-by: Vagrant Cascadian <vagrant@debian.org>
> >
> > There's nothing really specific about the pinebook here, but it's
> > needed for pretty much all the boards using DM_VIDEO (on Allwinner at
> > least).
> >
> > You should add a kconfig select / default instead
>
> That would basically revert 2cc393f32fd9, and I figured there was a
> reason for it...
>
> It wouldn't surprise me that other systems are affected, but I only
> notice this issue on the pinebook (most of the systems I use are
> headless), where it definitely needed to be fixed somehow.
>
> If there's a correct and more general fix, please propose it!
Well, looking at 2cc393f32fd9 there are a number of platforms that
enable more than one mode. But maybe we should always have at least one
mode?
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200118/337687df/attachment.sig>
next prev parent reply other threads:[~2020-01-18 22:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-18 11:15 [PATCH] arm: Enable VIDEO_BPP32 on pinebook Vagrant Cascadian
2020-01-18 11:27 ` Anatolij Gustschin
2020-01-18 11:29 ` Maxime Ripard
2020-01-18 20:03 ` Vagrant Cascadian
2020-01-18 22:00 ` Tom Rini [this message]
2020-01-22 17:43 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200118220052.GM8732@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.