From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8439C33CB7 for ; Sun, 19 Jan 2020 12:18:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AE9542072B for ; Sun, 19 Jan 2020 12:18:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727049AbgASMS3 (ORCPT ); Sun, 19 Jan 2020 07:18:29 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:9196 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726798AbgASMS3 (ORCPT ); Sun, 19 Jan 2020 07:18:29 -0500 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id A6758F5E5F10B0003819; Sun, 19 Jan 2020 20:18:26 +0800 (CST) Received: from huawei.com (10.175.124.28) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.439.0; Sun, 19 Jan 2020 20:18:18 +0800 From: yu kuai To: , CC: , , , , , Subject: [PATCH 3/4] video: fbdev: remove set but not used variable 'vSyncPol' Date: Sun, 19 Jan 2020 20:17:29 +0800 Message-ID: <20200119121730.10701-4-yukuai3@huawei.com> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20200119121730.10701-1-yukuai3@huawei.com> References: <20200119121730.10701-1-yukuai3@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.175.124.28] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes gcc '-Wunused-but-set-variable' warning: drivers/video/fbdev/aty/radeon_base.c: In function ‘radeonfb_set_par’: drivers/video/fbdev/aty/radeon_base.c:1653:48: warning: variable ‘cSync’ set but not used [-Wunused-but-set-variable] It is never used, and so can be removed. Signed-off-by: yu kuai --- drivers/video/fbdev/aty/radeon_base.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/video/fbdev/aty/radeon_base.c b/drivers/video/fbdev/aty/radeon_base.c index 0666f848bf70..7d2ee889ffcd 100644 --- a/drivers/video/fbdev/aty/radeon_base.c +++ b/drivers/video/fbdev/aty/radeon_base.c @@ -1650,7 +1650,7 @@ static int radeonfb_set_par(struct fb_info *info) struct fb_var_screeninfo *mode = &info->var; struct radeon_regs *newmode; int hTotal, vTotal, hSyncStart, hSyncEnd, - vSyncStart, vSyncEnd, cSync; + vSyncStart, vSyncEnd; u8 hsync_adj_tab[] = {0, 0x12, 9, 9, 6, 5}; u8 hsync_fudge_fp[] = {2, 2, 0, 0, 5, 5}; u32 sync, h_sync_pol, v_sync_pol, dotClock, pixClock; @@ -1730,8 +1730,6 @@ static int radeonfb_set_par(struct fb_info *info) else if (vsync_wid > 0x1f) /* max */ vsync_wid = 0x1f; - cSync = mode->sync & FB_SYNC_COMP_HIGH_ACT ? (1 << 4) : 0; - format = radeon_get_dstbpp(depth); bytpp = mode->bits_per_pixel >> 3; -- 2.17.2 From mboxrd@z Thu Jan 1 00:00:00 1970 From: yu kuai Date: Sun, 19 Jan 2020 12:17:29 +0000 Subject: [PATCH 3/4] video: fbdev: remove set but not used variable 'vSyncPol' Message-Id: <20200119121730.10701-4-yukuai3@huawei.com> List-Id: References: <20200119121730.10701-1-yukuai3@huawei.com> In-Reply-To: <20200119121730.10701-1-yukuai3@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: benh@kernel.crashing.org, b.zolnierkie@samsung.com Cc: linux-fbdev@vger.kernel.org, yi.zhang@huawei.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, zhengbin13@huawei.com, yukuai3@huawei.com Fixes gcc '-Wunused-but-set-variable' warning: drivers/video/fbdev/aty/radeon_base.c: In function ‘radeonfb_set_par’: drivers/video/fbdev/aty/radeon_base.c:1653:48: warning: variable ‘cSync’ set but not used [-Wunused-but-set-variable] It is never used, and so can be removed. Signed-off-by: yu kuai --- drivers/video/fbdev/aty/radeon_base.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/video/fbdev/aty/radeon_base.c b/drivers/video/fbdev/aty/radeon_base.c index 0666f848bf70..7d2ee889ffcd 100644 --- a/drivers/video/fbdev/aty/radeon_base.c +++ b/drivers/video/fbdev/aty/radeon_base.c @@ -1650,7 +1650,7 @@ static int radeonfb_set_par(struct fb_info *info) struct fb_var_screeninfo *mode = &info->var; struct radeon_regs *newmode; int hTotal, vTotal, hSyncStart, hSyncEnd, - vSyncStart, vSyncEnd, cSync; + vSyncStart, vSyncEnd; u8 hsync_adj_tab[] = {0, 0x12, 9, 9, 6, 5}; u8 hsync_fudge_fp[] = {2, 2, 0, 0, 5, 5}; u32 sync, h_sync_pol, v_sync_pol, dotClock, pixClock; @@ -1730,8 +1730,6 @@ static int radeonfb_set_par(struct fb_info *info) else if (vsync_wid > 0x1f) /* max */ vsync_wid = 0x1f; - cSync = mode->sync & FB_SYNC_COMP_HIGH_ACT ? (1 << 4) : 0; - format = radeon_get_dstbpp(depth); bytpp = mode->bits_per_pixel >> 3; -- 2.17.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 041DBC33CBA for ; Mon, 20 Jan 2020 08:59:08 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DA6342077C for ; Mon, 20 Jan 2020 08:59:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA6342077C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DE59B6E875; Mon, 20 Jan 2020 08:58:39 +0000 (UTC) Received: from huawei.com (szxga05-in.huawei.com [45.249.212.191]) by gabe.freedesktop.org (Postfix) with ESMTPS id 30C8E6E35D for ; Sun, 19 Jan 2020 12:18:29 +0000 (UTC) Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id A6758F5E5F10B0003819; Sun, 19 Jan 2020 20:18:26 +0800 (CST) Received: from huawei.com (10.175.124.28) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.439.0; Sun, 19 Jan 2020 20:18:18 +0800 From: yu kuai To: , Subject: [PATCH 3/4] video: fbdev: remove set but not used variable 'vSyncPol' Date: Sun, 19 Jan 2020 20:17:29 +0800 Message-ID: <20200119121730.10701-4-yukuai3@huawei.com> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20200119121730.10701-1-yukuai3@huawei.com> References: <20200119121730.10701-1-yukuai3@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.124.28] X-CFilter-Loop: Reflected X-Mailman-Approved-At: Mon, 20 Jan 2020 08:58:36 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, yi.zhang@huawei.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, zhengbin13@huawei.com, yukuai3@huawei.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Rml4ZXMgZ2NjICctV3VudXNlZC1idXQtc2V0LXZhcmlhYmxlJyB3YXJuaW5nOgoKZHJpdmVycy92 aWRlby9mYmRldi9hdHkvcmFkZW9uX2Jhc2UuYzogSW4gZnVuY3Rpb24K4oCYcmFkZW9uZmJfc2V0 X3BhcuKAmToKZHJpdmVycy92aWRlby9mYmRldi9hdHkvcmFkZW9uX2Jhc2UuYzoxNjUzOjQ4OiB3 YXJuaW5nOiB2YXJpYWJsZQrigJhjU3luY+KAmSBzZXQgYnV0IG5vdCB1c2VkIFstV3VudXNlZC1i dXQtc2V0LXZhcmlhYmxlXQoKSXQgaXMgbmV2ZXIgdXNlZCwgYW5kIHNvIGNhbiBiZSByZW1vdmVk LgoKU2lnbmVkLW9mZi1ieTogeXUga3VhaSA8eXVrdWFpM0BodWF3ZWkuY29tPgotLS0KIGRyaXZl cnMvdmlkZW8vZmJkZXYvYXR5L3JhZGVvbl9iYXNlLmMgfCA0ICstLS0KIDEgZmlsZSBjaGFuZ2Vk LCAxIGluc2VydGlvbigrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL3Zp ZGVvL2ZiZGV2L2F0eS9yYWRlb25fYmFzZS5jIGIvZHJpdmVycy92aWRlby9mYmRldi9hdHkvcmFk ZW9uX2Jhc2UuYwppbmRleCAwNjY2Zjg0OGJmNzAuLjdkMmVlODg5ZmZjZCAxMDA2NDQKLS0tIGEv ZHJpdmVycy92aWRlby9mYmRldi9hdHkvcmFkZW9uX2Jhc2UuYworKysgYi9kcml2ZXJzL3ZpZGVv L2ZiZGV2L2F0eS9yYWRlb25fYmFzZS5jCkBAIC0xNjUwLDcgKzE2NTAsNyBAQCBzdGF0aWMgaW50 IHJhZGVvbmZiX3NldF9wYXIoc3RydWN0IGZiX2luZm8gKmluZm8pCiAJc3RydWN0IGZiX3Zhcl9z Y3JlZW5pbmZvICptb2RlID0gJmluZm8tPnZhcjsKIAlzdHJ1Y3QgcmFkZW9uX3JlZ3MgKm5ld21v ZGU7CiAJaW50IGhUb3RhbCwgdlRvdGFsLCBoU3luY1N0YXJ0LCBoU3luY0VuZCwKLQkgICAgdlN5 bmNTdGFydCwgdlN5bmNFbmQsIGNTeW5jOworCSAgICB2U3luY1N0YXJ0LCB2U3luY0VuZDsKIAl1 OCBoc3luY19hZGpfdGFiW10gPSB7MCwgMHgxMiwgOSwgOSwgNiwgNX07CiAJdTggaHN5bmNfZnVk Z2VfZnBbXSA9IHsyLCAyLCAwLCAwLCA1LCA1fTsKIAl1MzIgc3luYywgaF9zeW5jX3BvbCwgdl9z eW5jX3BvbCwgZG90Q2xvY2ssIHBpeENsb2NrOwpAQCAtMTczMCw4ICsxNzMwLDYgQEAgc3RhdGlj IGludCByYWRlb25mYl9zZXRfcGFyKHN0cnVjdCBmYl9pbmZvICppbmZvKQogCWVsc2UgaWYgKHZz eW5jX3dpZCA+IDB4MWYpCS8qIG1heCAqLwogCQl2c3luY193aWQgPSAweDFmOwogCi0JY1N5bmMg PSBtb2RlLT5zeW5jICYgRkJfU1lOQ19DT01QX0hJR0hfQUNUID8gKDEgPDwgNCkgOiAwOwotCiAJ Zm9ybWF0ID0gcmFkZW9uX2dldF9kc3RicHAoZGVwdGgpOwogCWJ5dHBwID0gbW9kZS0+Yml0c19w ZXJfcGl4ZWwgPj4gMzsKIAotLSAKMi4xNy4yCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWwK