From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A73BC33CB1 for ; Sun, 19 Jan 2020 12:50:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CED0C2072B for ; Sun, 19 Jan 2020 12:50:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579438229; bh=EpoPZpgS3rLbMCPJwdXNNLBTTwSV212aIU12MPC6Ui8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=OjHJ1TWsMtbFzOQ8Kq6lhvQViQh64UsYpV7zz6Qem7+UJIrqb95AgMaebanjDa2rt QNHkNm55b97nRXOq0ISFJkKVdZMRQ84hNYT21Sv1tOGwygD+S0EL6GKdwNpYB74Iw2 yABiW8nwzHyvbMt6nyn/NRiDMyrC5PN/LWIszniU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726925AbgASMu2 (ORCPT ); Sun, 19 Jan 2020 07:50:28 -0500 Received: from mail.kernel.org ([198.145.29.99]:35308 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726778AbgASMu2 (ORCPT ); Sun, 19 Jan 2020 07:50:28 -0500 Received: from localhost (lns-bzn-36-82-251-23-53.adsl.proxad.net [82.251.23.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6BAE620714; Sun, 19 Jan 2020 12:50:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579438228; bh=EpoPZpgS3rLbMCPJwdXNNLBTTwSV212aIU12MPC6Ui8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ujtTUo6hJ4L5DvNSqixpuZnGzqAOUpxnerJbRXd8SdGVbOYFBeqAeUMIZYkeQJzGg c0lhLppIOxwcmYL/mRRMrpv6yNgdh4Jz9NE0eG8CxAeYRscItR7TpQ4/w3cV2yEVZ7 ndbPVwrVfNR4pJ8+IHDIcneaV7NanEzxOz1OawlM= Date: Sun, 19 Jan 2020 13:50:24 +0100 From: Greg KH To: Simon Fong Cc: abbotti@mev.co.uk, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, colin.king@canonical.com Subject: Re: [PATCH 3/3] Staging: comedi: usbdux: cleanup long line and align it Message-ID: <20200119125024.GA149057@kroah.com> References: <20200119035243.7819-1-simon.fongnt@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200119035243.7819-1-simon.fongnt@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 19, 2020 at 11:52:43AM +0800, Simon Fong wrote: > Clean up long line and align it > > Signed-off-by: Simon Fong > --- > drivers/staging/comedi/drivers/usbdux.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/comedi/drivers/usbdux.c b/drivers/staging/comedi/drivers/usbdux.c > index 0350f303d557..b9c0b1a1d86e 100644 > --- a/drivers/staging/comedi/drivers/usbdux.c > +++ b/drivers/staging/comedi/drivers/usbdux.c > @@ -204,7 +204,8 @@ struct usbdux_private { > struct mutex mut; > }; > > -static void usbdux_unlink_urbs(struct urb **urbs, int num_urbs) > +static void usbdux_unlink_urbs(struct urb **urbs, > + int num_urbs) As Joe said, there is no reason to change this line that I can see, why do you want to do that? greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0643DC33CB1 for ; Sun, 19 Jan 2020 12:51:17 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CA17B20714 for ; Sun, 19 Jan 2020 12:51:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="ujtTUo6h" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CA17B20714 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 9FA0F8744A; Sun, 19 Jan 2020 12:51:15 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Wg8ASEF6b5Mt; Sun, 19 Jan 2020 12:51:13 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id 221548741F; Sun, 19 Jan 2020 12:51:13 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id B79411BF5A5 for ; Sun, 19 Jan 2020 12:51:11 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id AF782873E3 for ; Sun, 19 Jan 2020 12:51:11 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id O4rtNMH8N63g for ; Sun, 19 Jan 2020 12:50:58 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by hemlock.osuosl.org (Postfix) with ESMTPS id D8CBC8741F for ; Sun, 19 Jan 2020 12:50:28 +0000 (UTC) Received: from localhost (lns-bzn-36-82-251-23-53.adsl.proxad.net [82.251.23.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6BAE620714; Sun, 19 Jan 2020 12:50:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579438228; bh=EpoPZpgS3rLbMCPJwdXNNLBTTwSV212aIU12MPC6Ui8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ujtTUo6hJ4L5DvNSqixpuZnGzqAOUpxnerJbRXd8SdGVbOYFBeqAeUMIZYkeQJzGg c0lhLppIOxwcmYL/mRRMrpv6yNgdh4Jz9NE0eG8CxAeYRscItR7TpQ4/w3cV2yEVZ7 ndbPVwrVfNR4pJ8+IHDIcneaV7NanEzxOz1OawlM= Date: Sun, 19 Jan 2020 13:50:24 +0100 From: Greg KH To: Simon Fong Subject: Re: [PATCH 3/3] Staging: comedi: usbdux: cleanup long line and align it Message-ID: <20200119125024.GA149057@kroah.com> References: <20200119035243.7819-1-simon.fongnt@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200119035243.7819-1-simon.fongnt@gmail.com> X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, colin.king@canonical.com, abbotti@mev.co.uk, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Sun, Jan 19, 2020 at 11:52:43AM +0800, Simon Fong wrote: > Clean up long line and align it > > Signed-off-by: Simon Fong > --- > drivers/staging/comedi/drivers/usbdux.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/comedi/drivers/usbdux.c b/drivers/staging/comedi/drivers/usbdux.c > index 0350f303d557..b9c0b1a1d86e 100644 > --- a/drivers/staging/comedi/drivers/usbdux.c > +++ b/drivers/staging/comedi/drivers/usbdux.c > @@ -204,7 +204,8 @@ struct usbdux_private { > struct mutex mut; > }; > > -static void usbdux_unlink_urbs(struct urb **urbs, int num_urbs) > +static void usbdux_unlink_urbs(struct urb **urbs, > + int num_urbs) As Joe said, there is no reason to change this line that I can see, why do you want to do that? greg k-h _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel