From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F23E7C2D0DB for ; Mon, 20 Jan 2020 13:07:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D2A0C22314 for ; Mon, 20 Jan 2020 13:07:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729252AbgATNH2 (ORCPT ); Mon, 20 Jan 2020 08:07:28 -0500 Received: from mga12.intel.com ([192.55.52.136]:49971 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729014AbgATNHZ (ORCPT ); Mon, 20 Jan 2020 08:07:25 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Jan 2020 05:07:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,342,1574150400"; d="scan'208";a="275282211" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.163]) by fmsmga001.fm.intel.com with SMTP; 20 Jan 2020 05:07:19 -0800 Received: by lahna (sSMTP sendmail emulation); Mon, 20 Jan 2020 15:07:19 +0200 Date: Mon, 20 Jan 2020 15:07:19 +0200 From: Mika Westerberg To: Lee Jones Cc: Andy Shevchenko , Darren Hart , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , x86@kernel.org, Zha Qipeng , "David E . Box" , Guenter Roeck , Heikki Krogerus , Greg Kroah-Hartman , Wim Van Sebroeck , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 35/36] platform/x86: intel_pmc_ipc: Convert to MFD Message-ID: <20200120130719.GO2665@lahna.fi.intel.com> References: <20200113135623.56286-36-mika.westerberg@linux.intel.com> <20200116132108.GH325@dell> <20200116143730.GE2838@lahna.fi.intel.com> <20200117113202.GH15507@dell> <20200117142750.GP2838@lahna.fi.intel.com> <20200120081246.GS15507@dell> <20200120091258.GH2665@lahna.fi.intel.com> <20200120111450.GE15507@dell> <20200120112634.GN2665@lahna.fi.intel.com> <20200120125059.GF15507@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200120125059.GF15507@dell> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 20, 2020 at 12:50:59PM +0000, Lee Jones wrote: > On Mon, 20 Jan 2020, Mika Westerberg wrote: > > On Mon, Jan 20, 2020 at 11:14:50AM +0000, Lee Jones wrote: > > > On Mon, 20 Jan 2020, Mika Westerberg wrote: > > > > > > > On Mon, Jan 20, 2020 at 08:12:46AM +0000, Lee Jones wrote: > > > > > > Well, by "library" I mean that the SCU IPC itself does not bind to > > > > > > anything but instead it gets called by different drivers such as this > > > > > > one passing the device pointer that is the SCU IPC device. Here for > > > > > > example it is the platfrom device created from an ACPI description. > > > > > > > > > > Not keen on that at all. Why can it not be a platform device? > > > > > > > > We also call the same library from a PCI driver (intel_scu_pcidrv.c in > > > > this series) where the device is of type struct pci_dev. > > > > > > Not sure I understand the issue. > > > > You are asking why it cannot be a platform device. It cannot be because > > we are calling the same library from a PCI driver where there is no > > platform device available (only struct pci_dev). > > I'm asking why it needs to be called at all. Why can't it be probed > using the Device Driver API, like most other drivers? The PMC is a single device (either ACPI or PCI) that includes SCU IPC and zero or more child devices sharing the resources (hence I'm converting it to MFD in the first place). I want to use the same SCU IPC implementation from both the PCI driver (intel_scu_pcidrv.c) and the MFD driver (intel_pmc_bxt.c).