From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Mon, 20 Jan 2020 12:07:15 -0800 From: Bjorn Andersson Subject: Re: [PATCH v4 2/5] remoteproc: Add device-managed variants of rproc_alloc/rproc_add Message-ID: <20200120200711.GN1511@yoga> References: <20191210164014.50739-1-paul@crapouillou.net> <20191210164014.50739-2-paul@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191210164014.50739-2-paul@crapouillou.net> To: Paul Cercueil Cc: Ohad Ben-Cohen , Rob Herring , Mark Rutland , od@zcrc.me, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: On Tue 10 Dec 08:40 PST 2019, Paul Cercueil wrote: [..] > +/** > + * devm_rproc_add() - resource managed rproc_add() > + * @dev: the underlying device > + * @rproc: the remote processor handle to register > + * > + * This function performs like rproc_add() but the registered rproc device will > + * automatically be removed on driver detach. > + * > + * Returns 0 on success and an appropriate error code otherwise. The kerneldoc format is "Return: foo on bar...". So please update this to Return: 0 on success, negative errno on failure > + */ > +int devm_rproc_add(struct device *dev, struct rproc *rproc) > +{ [..] > +/** > + * devm_rproc_alloc() - resource managed rproc_alloc() > + * @dev: the underlying device > + * @name: name of this remote processor > + * @ops: platform-specific handlers (mainly start/stop) > + * @firmware: name of firmware file to load, can be NULL > + * @len: length of private data needed by the rproc driver (in bytes) > + * > + * This function performs like rproc_alloc() but the acuired rproc device will > + * automatically be released on driver detach. > + * > + * On success the new rproc is returned, and on failure, NULL. Return: new rproc instance, NULL on failure Regards, Bjorn From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 427A9C32771 for ; Mon, 20 Jan 2020 20:07:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 14E2D22527 for ; Mon, 20 Jan 2020 20:07:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JpzPvLHk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726951AbgATUHQ (ORCPT ); Mon, 20 Jan 2020 15:07:16 -0500 Received: from mail-pj1-f67.google.com ([209.85.216.67]:35574 "EHLO mail-pj1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726843AbgATUHQ (ORCPT ); Mon, 20 Jan 2020 15:07:16 -0500 Received: by mail-pj1-f67.google.com with SMTP id s7so270149pjc.0 for ; Mon, 20 Jan 2020 12:07:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=zBntqnBm/t/sr39kDrW9d8+cYZzx+y01IwKgpBCSFpE=; b=JpzPvLHk9iigjUBcm06AscUAH8za2VLTbotRHjz/miINfcJm++dyA1mNax2Yd4Z2Ai mC8OLsraPZ2nLGxkD+ljDmG7mQgBK+fl3LaK9KDtnkrCA8XWo6kAU7CttcER4JD2XTZu QPlal7GtBKYAyRi2FGy8rRP6cEkDSJiDt0HHCSsTyB0mfGDj0qCp7ti53VZ5jDFok/r8 5IfezClnVBFIXOQwLMp9rKANYbGxH3ZG0h/ap/8ebY1sCvGFYll+QxGgMuaeROoYh8ES 1Fm1umRye61ATiwbxUSMz8Zg0sp5jLHamxp9sqCvNjnTJ8mVLZL0EUBCvtK4sIjZOMmv Eejw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=zBntqnBm/t/sr39kDrW9d8+cYZzx+y01IwKgpBCSFpE=; b=CjVmZLVKveCyEU1i0WqmY5uA/8x7S2o2AhSAkVmlgebC695a3Iu3zAZXQ8ZvCK5u0A 1mhjNVk20KZ9v/n/iWiVLSgEBh/Mc81wq4H6u7OUBtAIWo+eM/Ciuum4D6IyUG52jBJf x+dwSgvjNXwj2aVFBeo0nZEr6quyNzQKh/qMlvHdHdbNnp4nhf/5Q8uY5qdDz5sH7oke 7RPEo9kE7UR9957e0lb0CrzRxWCUZKh3yRKpGqxOm/l25FPmA4dJ7hHTdMxxuBVMG3VB UIvCj8II8WI8PUmGJvvmD0UZ6odBNf+rNE7+vhuc7zdKjIH6eE7AdLIpnR3YTST5Dc3b nMFw== X-Gm-Message-State: APjAAAXx0803qaqyceClO8EUkDzVW5ra+DFzH66/a/UkYn7xY267HEmk Nu6ehHGlVO/NzorNAcch2sQqzg== X-Google-Smtp-Source: APXvYqzK9emDyuL+3sGE31QpUbs6KIbP+mVYE3WXgCXZ8T6ZTCLwzxOP0eDpWsawCgYdJamJrkqFgw== X-Received: by 2002:a17:902:8494:: with SMTP id c20mr1493284plo.189.1579550835246; Mon, 20 Jan 2020 12:07:15 -0800 (PST) Received: from yoga (wsip-184-181-24-67.sd.sd.cox.net. [184.181.24.67]) by smtp.gmail.com with ESMTPSA id s130sm39442278pgc.82.2020.01.20.12.07.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jan 2020 12:07:14 -0800 (PST) Date: Mon, 20 Jan 2020 12:07:11 -0800 From: Bjorn Andersson To: Paul Cercueil Cc: Ohad Ben-Cohen , Rob Herring , Mark Rutland , od@zcrc.me, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/5] remoteproc: Add device-managed variants of rproc_alloc/rproc_add Message-ID: <20200120200711.GN1511@yoga> References: <20191210164014.50739-1-paul@crapouillou.net> <20191210164014.50739-2-paul@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191210164014.50739-2-paul@crapouillou.net> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 10 Dec 08:40 PST 2019, Paul Cercueil wrote: [..] > +/** > + * devm_rproc_add() - resource managed rproc_add() > + * @dev: the underlying device > + * @rproc: the remote processor handle to register > + * > + * This function performs like rproc_add() but the registered rproc device will > + * automatically be removed on driver detach. > + * > + * Returns 0 on success and an appropriate error code otherwise. The kerneldoc format is "Return: foo on bar...". So please update this to Return: 0 on success, negative errno on failure > + */ > +int devm_rproc_add(struct device *dev, struct rproc *rproc) > +{ [..] > +/** > + * devm_rproc_alloc() - resource managed rproc_alloc() > + * @dev: the underlying device > + * @name: name of this remote processor > + * @ops: platform-specific handlers (mainly start/stop) > + * @firmware: name of firmware file to load, can be NULL > + * @len: length of private data needed by the rproc driver (in bytes) > + * > + * This function performs like rproc_alloc() but the acuired rproc device will > + * automatically be released on driver detach. > + * > + * On success the new rproc is returned, and on failure, NULL. Return: new rproc instance, NULL on failure Regards, Bjorn