From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0FE2C2D0CE for ; Tue, 21 Jan 2020 14:35:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9909924653 for ; Tue, 21 Jan 2020 14:35:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728978AbgAUOf3 (ORCPT ); Tue, 21 Jan 2020 09:35:29 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:38204 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727817AbgAUOf3 (ORCPT ); Tue, 21 Jan 2020 09:35:29 -0500 Received: from localhost (82-95-191-104.ip.xs4all.nl [82.95.191.104]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 1CA15153A4B96; Tue, 21 Jan 2020 06:35:26 -0800 (PST) Date: Tue, 21 Jan 2020 15:35:22 +0100 (CET) Message-Id: <20200121.153522.1248409324581446114.davem@davemloft.net> To: gautamramk@gmail.com Cc: netdev@vger.kernel.org, tahiliani@nitk.edu.in, jhs@mojatatu.com, dave.taht@gmail.com, toke@redhat.com, kuba@kernel.org, stephen@networkplumber.org, lesliemonis@gmail.com Subject: Re: [PATCH net-next v4 05/10] pie: rearrange structure members and their initializations From: David Miller In-Reply-To: <20200121141250.26989-6-gautamramk@gmail.com> References: <20200121141250.26989-1-gautamramk@gmail.com> <20200121141250.26989-6-gautamramk@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 21 Jan 2020 06:35:28 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: gautamramk@gmail.com Date: Tue, 21 Jan 2020 19:42:44 +0530 > From: "Mohit P. Tahiliani" > > Rearrange the members of the structures such that they appear in > order of their types. Also, change the order of their > initializations to match the order in which they appear in the > structures. This improves the code's readability and consistency. > > Signed-off-by: Mohit P. Tahiliani > Signed-off-by: Leslie Monis > Signed-off-by: Gautam Ramakrishnan What matters for structure member ordering is dense packing and grouping commonly-used-together elements for performance. "order of their types" are none of those things.