* [Intel-gfx] [PATCH RESEND] drm/i915: add display engine uncore helpers
@ 2020-01-21 11:39 Jani Nikula
2020-01-21 12:25 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
` (8 more replies)
0 siblings, 9 replies; 13+ messages in thread
From: Jani Nikula @ 2020-01-21 11:39 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula, Lucas De Marchi
Add convenience helpers for the most common uncore operations with
struct drm_i915_private * as context rather than struct intel_uncore *.
The goal is to replace all instances of I915_READ(),
I915_POSTING_READ(), I915_WRITE(), I915_READ_FW(), and I915_WRITE_FW()
in display/ with these, to finally be able to get rid of the implicit
dev_priv local parameter use.
The idea is that any non-u32 reads or writes are special enough that
they can use the intel_uncore_* functions directly.
v2:
- rename the file intel_de.h
- move intel_de_wait_for_* there too
- also add de fw helpers
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/display/intel_de.h | 72 +++++++++++++++++++
.../drm/i915/display/intel_display_types.h | 1 +
drivers/gpu/drm/i915/i915_drv.h | 14 ----
3 files changed, 73 insertions(+), 14 deletions(-)
create mode 100644 drivers/gpu/drm/i915/display/intel_de.h
diff --git a/drivers/gpu/drm/i915/display/intel_de.h b/drivers/gpu/drm/i915/display/intel_de.h
new file mode 100644
index 000000000000..00da10bf35f5
--- /dev/null
+++ b/drivers/gpu/drm/i915/display/intel_de.h
@@ -0,0 +1,72 @@
+/* SPDX-License-Identifier: MIT */
+/*
+ * Copyright © 2019 Intel Corporation
+ */
+
+#ifndef __INTEL_DE_H__
+#define __INTEL_DE_H__
+
+#include "i915_drv.h"
+#include "i915_reg.h"
+#include "intel_uncore.h"
+
+static inline u32
+intel_de_read(struct drm_i915_private *i915, i915_reg_t reg)
+{
+ return intel_uncore_read(&i915->uncore, reg);
+}
+
+static inline void
+intel_de_posting_read(struct drm_i915_private *i915, i915_reg_t reg)
+{
+ intel_uncore_posting_read(&i915->uncore, reg);
+}
+
+/* Note: read the warnings for intel_uncore_*_fw() functions! */
+static inline u32
+intel_de_read_fw(struct drm_i915_private *i915, i915_reg_t reg)
+{
+ return intel_uncore_read_fw(&i915->uncore, reg);
+}
+
+static inline void
+intel_de_write(struct drm_i915_private *i915, i915_reg_t reg, u32 val)
+{
+ intel_uncore_write(&i915->uncore, reg, val);
+}
+
+/* Note: read the warnings for intel_uncore_*_fw() functions! */
+static inline void
+intel_de_write_fw(struct drm_i915_private *i915, i915_reg_t reg, u32 val)
+{
+ intel_uncore_write_fw(&i915->uncore, reg, val);
+}
+
+static inline void
+intel_de_rmw(struct drm_i915_private *i915, i915_reg_t reg, u32 clear, u32 set)
+{
+ intel_uncore_rmw(&i915->uncore, reg, clear, set);
+}
+
+static inline int
+intel_de_wait_for_register(struct drm_i915_private *i915, i915_reg_t reg,
+ u32 mask, u32 value, unsigned int timeout)
+{
+ return intel_wait_for_register(&i915->uncore, reg, mask, value, timeout);
+}
+
+static inline int
+intel_de_wait_for_set(struct drm_i915_private *i915, i915_reg_t reg,
+ u32 mask, unsigned int timeout)
+{
+ return intel_de_wait_for_register(i915, reg, mask, mask, timeout);
+}
+
+static inline int
+intel_de_wait_for_clear(struct drm_i915_private *i915, i915_reg_t reg,
+ u32 mask, unsigned int timeout)
+{
+ return intel_de_wait_for_register(i915, reg, mask, 0, timeout);
+}
+
+#endif /* __INTEL_DE_H__ */
diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
index 155ce49ae764..0d7adc2c167a 100644
--- a/drivers/gpu/drm/i915/display/intel_display_types.h
+++ b/drivers/gpu/drm/i915/display/intel_display_types.h
@@ -44,6 +44,7 @@
#include <media/cec-notifier.h>
#include "i915_drv.h"
+#include "intel_de.h"
struct drm_printer;
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 077af22b8340..16f6e957f821 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -2010,20 +2010,6 @@ int i915_reg_read_ioctl(struct drm_device *dev, void *data,
#define I915_READ_FW(reg__) __I915_REG_OP(read_fw, dev_priv, (reg__))
#define I915_WRITE_FW(reg__, val__) __I915_REG_OP(write_fw, dev_priv, (reg__), (val__))
-/* register wait wrappers for display regs */
-#define intel_de_wait_for_register(dev_priv_, reg_, mask_, value_, timeout_) \
- intel_wait_for_register(&(dev_priv_)->uncore, \
- (reg_), (mask_), (value_), (timeout_))
-
-#define intel_de_wait_for_set(dev_priv_, reg_, mask_, timeout_) ({ \
- u32 mask__ = (mask_); \
- intel_de_wait_for_register((dev_priv_), (reg_), \
- mask__, mask__, (timeout_)); \
-})
-
-#define intel_de_wait_for_clear(dev_priv_, reg_, mask_, timeout_) \
- intel_de_wait_for_register((dev_priv_), (reg_), (mask_), 0, (timeout_))
-
/* i915_mm.c */
int remap_io_mapping(struct vm_area_struct *vma,
unsigned long addr, unsigned long pfn, unsigned long size,
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: add display engine uncore helpers
2020-01-21 11:39 [Intel-gfx] [PATCH RESEND] drm/i915: add display engine uncore helpers Jani Nikula
@ 2020-01-21 12:25 ` Patchwork
2020-01-21 12:55 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
` (7 subsequent siblings)
8 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2020-01-21 12:25 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: add display engine uncore helpers
URL : https://patchwork.freedesktop.org/series/72331/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
2cd270746904 drm/i915: add display engine uncore helpers
-:34: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#34:
new file mode 100644
total: 0 errors, 1 warnings, 0 checks, 99 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: add display engine uncore helpers
2020-01-21 11:39 [Intel-gfx] [PATCH RESEND] drm/i915: add display engine uncore helpers Jani Nikula
2020-01-21 12:25 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
@ 2020-01-21 12:55 ` Patchwork
2020-01-21 13:03 ` [Intel-gfx] [PATCH RESEND] " Chris Wilson
` (6 subsequent siblings)
8 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2020-01-21 12:55 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: add display engine uncore helpers
URL : https://patchwork.freedesktop.org/series/72331/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7783 -> Patchwork_16187
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_16187 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_16187, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16187/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_16187:
### IGT changes ###
#### Possible regressions ####
* igt@runner@aborted:
- fi-cfl-guc: NOTRUN -> [FAIL][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16187/fi-cfl-guc/igt@runner@aborted.html
Known issues
------------
Here are the changes found in Patchwork_16187 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_close_race@basic-threads:
- fi-byt-j1900: [PASS][2] -> [TIMEOUT][3] ([fdo#112271] / [i915#816])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7783/fi-byt-j1900/igt@gem_close_race@basic-threads.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16187/fi-byt-j1900/igt@gem_close_race@basic-threads.html
* igt@i915_module_load@reload-with-fault-injection:
- fi-cfl-guc: [PASS][4] -> [DMESG-WARN][5] ([i915#889])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7783/fi-cfl-guc/igt@i915_module_load@reload-with-fault-injection.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16187/fi-cfl-guc/igt@i915_module_load@reload-with-fault-injection.html
* igt@i915_selftest@live_blt:
- fi-hsw-4770: [PASS][6] -> [DMESG-FAIL][7] ([i915#553] / [i915#725])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7783/fi-hsw-4770/igt@i915_selftest@live_blt.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16187/fi-hsw-4770/igt@i915_selftest@live_blt.html
* igt@i915_selftest@live_gem_contexts:
- fi-cfl-8700k: [PASS][8] -> [INCOMPLETE][9] ([i915#424])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7783/fi-cfl-8700k/igt@i915_selftest@live_gem_contexts.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16187/fi-cfl-8700k/igt@i915_selftest@live_gem_contexts.html
* igt@kms_chamelium@dp-crc-fast:
- fi-cml-u2: [PASS][10] -> [FAIL][11] ([i915#262])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7783/fi-cml-u2/igt@kms_chamelium@dp-crc-fast.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16187/fi-cml-u2/igt@kms_chamelium@dp-crc-fast.html
* igt@kms_chamelium@hdmi-edid-read:
- fi-icl-u2: [PASS][12] -> [FAIL][13] ([i915#217])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7783/fi-icl-u2/igt@kms_chamelium@hdmi-edid-read.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16187/fi-icl-u2/igt@kms_chamelium@hdmi-edid-read.html
#### Possible fixes ####
* igt@i915_module_load@reload-with-fault-injection:
- fi-cfl-8700k: [DMESG-WARN][14] ([i915#889]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7783/fi-cfl-8700k/igt@i915_module_load@reload-with-fault-injection.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16187/fi-cfl-8700k/igt@i915_module_load@reload-with-fault-injection.html
- fi-skl-6700k2: [INCOMPLETE][16] ([i915#671]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7783/fi-skl-6700k2/igt@i915_module_load@reload-with-fault-injection.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16187/fi-skl-6700k2/igt@i915_module_load@reload-with-fault-injection.html
- fi-kbl-x1275: [DMESG-WARN][18] ([i915#889]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7783/fi-kbl-x1275/igt@i915_module_load@reload-with-fault-injection.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16187/fi-kbl-x1275/igt@i915_module_load@reload-with-fault-injection.html
* igt@i915_pm_rpm@module-reload:
- fi-kbl-x1275: [INCOMPLETE][20] ([i915#151]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7783/fi-kbl-x1275/igt@i915_pm_rpm@module-reload.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16187/fi-kbl-x1275/igt@i915_pm_rpm@module-reload.html
#### Warnings ####
* igt@gem_exec_parallel@contexts:
- fi-byt-n2820: [INCOMPLETE][22] ([i915#45] / [i915#999]) -> [TIMEOUT][23] ([fdo#112271])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7783/fi-byt-n2820/igt@gem_exec_parallel@contexts.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16187/fi-byt-n2820/igt@gem_exec_parallel@contexts.html
[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
[i915#151]: https://gitlab.freedesktop.org/drm/intel/issues/151
[i915#217]: https://gitlab.freedesktop.org/drm/intel/issues/217
[i915#262]: https://gitlab.freedesktop.org/drm/intel/issues/262
[i915#424]: https://gitlab.freedesktop.org/drm/intel/issues/424
[i915#45]: https://gitlab.freedesktop.org/drm/intel/issues/45
[i915#553]: https://gitlab.freedesktop.org/drm/intel/issues/553
[i915#671]: https://gitlab.freedesktop.org/drm/intel/issues/671
[i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725
[i915#816]: https://gitlab.freedesktop.org/drm/intel/issues/816
[i915#889]: https://gitlab.freedesktop.org/drm/intel/issues/889
[i915#999]: https://gitlab.freedesktop.org/drm/intel/issues/999
Participating hosts (44 -> 44)
------------------------------
Additional (6): fi-glk-dsi fi-gdg-551 fi-bsw-kefka fi-kbl-7560u fi-bsw-nick fi-snb-2600
Missing (6): fi-ilk-m540 fi-ehl-1 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7783 -> Patchwork_16187
CI-20190529: 20190529
CI_DRM_7783: 3ee976286895f0bd54388efc16b12f62c624ff19 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5376: 5cf58d947a02379d2885d6dd4f8bb487cfc3eed2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_16187: 2cd270746904178903db5dcda75726a6608df976 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
2cd270746904 drm/i915: add display engine uncore helpers
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16187/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH RESEND] drm/i915: add display engine uncore helpers
2020-01-21 11:39 [Intel-gfx] [PATCH RESEND] drm/i915: add display engine uncore helpers Jani Nikula
2020-01-21 12:25 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2020-01-21 12:55 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
@ 2020-01-21 13:03 ` Chris Wilson
2020-01-21 13:58 ` Jani Nikula
2020-01-21 15:10 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: add display engine uncore helpers (rev2) Patchwork
` (5 subsequent siblings)
8 siblings, 1 reply; 13+ messages in thread
From: Chris Wilson @ 2020-01-21 13:03 UTC (permalink / raw)
To: Jani Nikula, intel-gfx; +Cc: Jani Nikula, Lucas De Marchi
Quoting Jani Nikula (2020-01-21 11:39:15)
> Add convenience helpers for the most common uncore operations with
> struct drm_i915_private * as context rather than struct intel_uncore *.
>
> The goal is to replace all instances of I915_READ(),
> I915_POSTING_READ(), I915_WRITE(), I915_READ_FW(), and I915_WRITE_FW()
> in display/ with these, to finally be able to get rid of the implicit
> dev_priv local parameter use.
>
> The idea is that any non-u32 reads or writes are special enough that
> they can use the intel_uncore_* functions directly.
>
> v2:
> - rename the file intel_de.h
> - move intel_de_wait_for_* there too
> - also add de fw helpers
>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_de.h | 72 +++++++++++++++++++
> .../drm/i915/display/intel_display_types.h | 1 +
> drivers/gpu/drm/i915/i915_drv.h | 14 ----
> 3 files changed, 73 insertions(+), 14 deletions(-)
> create mode 100644 drivers/gpu/drm/i915/display/intel_de.h
>
> diff --git a/drivers/gpu/drm/i915/display/intel_de.h b/drivers/gpu/drm/i915/display/intel_de.h
> new file mode 100644
> index 000000000000..00da10bf35f5
> --- /dev/null
> +++ b/drivers/gpu/drm/i915/display/intel_de.h
> @@ -0,0 +1,72 @@
> +/* SPDX-License-Identifier: MIT */
> +/*
> + * Copyright © 2019 Intel Corporation
> + */
> +
> +#ifndef __INTEL_DE_H__
> +#define __INTEL_DE_H__
> +
> +#include "i915_drv.h"
> +#include "i915_reg.h"
> +#include "intel_uncore.h"
> +
> +static inline u32
> +intel_de_read(struct drm_i915_private *i915, i915_reg_t reg)
> +{
> + return intel_uncore_read(&i915->uncore, reg);
> +}
> +
> +static inline void
> +intel_de_posting_read(struct drm_i915_private *i915, i915_reg_t reg)
> +{
> + intel_uncore_posting_read(&i915->uncore, reg);
> +}
> +
> +/* Note: read the warnings for intel_uncore_*_fw() functions! */
> +static inline u32
> +intel_de_read_fw(struct drm_i915_private *i915, i915_reg_t reg)
> +{
> + return intel_uncore_read_fw(&i915->uncore, reg);
> +}
> +
> +static inline void
> +intel_de_write(struct drm_i915_private *i915, i915_reg_t reg, u32 val)
> +{
> + intel_uncore_write(&i915->uncore, reg, val);
> +}
> +
> +/* Note: read the warnings for intel_uncore_*_fw() functions! */
> +static inline void
> +intel_de_write_fw(struct drm_i915_private *i915, i915_reg_t reg, u32 val)
> +{
> + intel_uncore_write_fw(&i915->uncore, reg, val);
> +}
> +
> +static inline void
> +intel_de_rmw(struct drm_i915_private *i915, i915_reg_t reg, u32 clear, u32 set)
> +{
> + intel_uncore_rmw(&i915->uncore, reg, clear, set);
> +}
> +
> +static inline int
> +intel_de_wait_for_register(struct drm_i915_private *i915, i915_reg_t reg,
> + u32 mask, u32 value, unsigned int timeout)
> +{
> + return intel_wait_for_register(&i915->uncore, reg, mask, value, timeout);
> +}
> +
> +static inline int
> +intel_de_wait_for_set(struct drm_i915_private *i915, i915_reg_t reg,
> + u32 mask, unsigned int timeout)
> +{
> + return intel_de_wait_for_register(i915, reg, mask, mask, timeout);
> +}
> +
> +static inline int
> +intel_de_wait_for_clear(struct drm_i915_private *i915, i915_reg_t reg,
> + u32 mask, unsigned int timeout)
> +{
> + return intel_de_wait_for_register(i915, reg, mask, 0, timeout);
> +}
> +
> +#endif /* __INTEL_DE_H__ */
> diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
> index 155ce49ae764..0d7adc2c167a 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_types.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
> @@ -44,6 +44,7 @@
> #include <media/cec-notifier.h>
>
> #include "i915_drv.h"
> +#include "intel_de.h"
I don't think you want to include it from types.h though -- I think you
want to avoid inlines (at least inlines that depend upon external types)
away from the types.h so you can avoid the dreaded cycles.
So other than that,
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Or you may want to make the placement of the final include(s) a
separate patch.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH RESEND] drm/i915: add display engine uncore helpers
2020-01-21 13:03 ` [Intel-gfx] [PATCH RESEND] " Chris Wilson
@ 2020-01-21 13:58 ` Jani Nikula
2020-01-21 14:11 ` Chris Wilson
0 siblings, 1 reply; 13+ messages in thread
From: Jani Nikula @ 2020-01-21 13:58 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: Lucas De Marchi
On Tue, 21 Jan 2020, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Jani Nikula (2020-01-21 11:39:15)
>> Add convenience helpers for the most common uncore operations with
>> struct drm_i915_private * as context rather than struct intel_uncore *.
>>
>> The goal is to replace all instances of I915_READ(),
>> I915_POSTING_READ(), I915_WRITE(), I915_READ_FW(), and I915_WRITE_FW()
>> in display/ with these, to finally be able to get rid of the implicit
>> dev_priv local parameter use.
>>
>> The idea is that any non-u32 reads or writes are special enough that
>> they can use the intel_uncore_* functions directly.
>>
>> v2:
>> - rename the file intel_de.h
>> - move intel_de_wait_for_* there too
>> - also add de fw helpers
>>
>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
>> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>> drivers/gpu/drm/i915/display/intel_de.h | 72 +++++++++++++++++++
>> .../drm/i915/display/intel_display_types.h | 1 +
>> drivers/gpu/drm/i915/i915_drv.h | 14 ----
>> 3 files changed, 73 insertions(+), 14 deletions(-)
>> create mode 100644 drivers/gpu/drm/i915/display/intel_de.h
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_de.h b/drivers/gpu/drm/i915/display/intel_de.h
>> new file mode 100644
>> index 000000000000..00da10bf35f5
>> --- /dev/null
>> +++ b/drivers/gpu/drm/i915/display/intel_de.h
>> @@ -0,0 +1,72 @@
>> +/* SPDX-License-Identifier: MIT */
>> +/*
>> + * Copyright © 2019 Intel Corporation
>> + */
>> +
>> +#ifndef __INTEL_DE_H__
>> +#define __INTEL_DE_H__
>> +
>> +#include "i915_drv.h"
>> +#include "i915_reg.h"
>> +#include "intel_uncore.h"
>> +
>> +static inline u32
>> +intel_de_read(struct drm_i915_private *i915, i915_reg_t reg)
>> +{
>> + return intel_uncore_read(&i915->uncore, reg);
>> +}
>> +
>> +static inline void
>> +intel_de_posting_read(struct drm_i915_private *i915, i915_reg_t reg)
>> +{
>> + intel_uncore_posting_read(&i915->uncore, reg);
>> +}
>> +
>> +/* Note: read the warnings for intel_uncore_*_fw() functions! */
>> +static inline u32
>> +intel_de_read_fw(struct drm_i915_private *i915, i915_reg_t reg)
>> +{
>> + return intel_uncore_read_fw(&i915->uncore, reg);
>> +}
>> +
>> +static inline void
>> +intel_de_write(struct drm_i915_private *i915, i915_reg_t reg, u32 val)
>> +{
>> + intel_uncore_write(&i915->uncore, reg, val);
>> +}
>> +
>> +/* Note: read the warnings for intel_uncore_*_fw() functions! */
>> +static inline void
>> +intel_de_write_fw(struct drm_i915_private *i915, i915_reg_t reg, u32 val)
>> +{
>> + intel_uncore_write_fw(&i915->uncore, reg, val);
>> +}
>> +
>> +static inline void
>> +intel_de_rmw(struct drm_i915_private *i915, i915_reg_t reg, u32 clear, u32 set)
>> +{
>> + intel_uncore_rmw(&i915->uncore, reg, clear, set);
>> +}
>> +
>> +static inline int
>> +intel_de_wait_for_register(struct drm_i915_private *i915, i915_reg_t reg,
>> + u32 mask, u32 value, unsigned int timeout)
>> +{
>> + return intel_wait_for_register(&i915->uncore, reg, mask, value, timeout);
>> +}
>> +
>> +static inline int
>> +intel_de_wait_for_set(struct drm_i915_private *i915, i915_reg_t reg,
>> + u32 mask, unsigned int timeout)
>> +{
>> + return intel_de_wait_for_register(i915, reg, mask, mask, timeout);
>> +}
>> +
>> +static inline int
>> +intel_de_wait_for_clear(struct drm_i915_private *i915, i915_reg_t reg,
>> + u32 mask, unsigned int timeout)
>> +{
>> + return intel_de_wait_for_register(i915, reg, mask, 0, timeout);
>> +}
>> +
>> +#endif /* __INTEL_DE_H__ */
>> diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
>> index 155ce49ae764..0d7adc2c167a 100644
>> --- a/drivers/gpu/drm/i915/display/intel_display_types.h
>> +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
>> @@ -44,6 +44,7 @@
>> #include <media/cec-notifier.h>
>>
>> #include "i915_drv.h"
>> +#include "intel_de.h"
>
> I don't think you want to include it from types.h though -- I think you
> want to avoid inlines (at least inlines that depend upon external types)
> away from the types.h so you can avoid the dreaded cycles.
Eventually yes, but I also don't want to splatter #include "intel_de.h"
everywhere just yet... this seemed to fit the bill. ;)
> So other than that,
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> Or you may want to make the placement of the final include(s) a
> separate patch.
Thanks for the review. Do you insist on a re-spin with the includes
sorted out before merge?
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH RESEND] drm/i915: add display engine uncore helpers
2020-01-21 13:58 ` Jani Nikula
@ 2020-01-21 14:11 ` Chris Wilson
2020-01-23 9:36 ` Jani Nikula
0 siblings, 1 reply; 13+ messages in thread
From: Chris Wilson @ 2020-01-21 14:11 UTC (permalink / raw)
To: Jani Nikula, intel-gfx; +Cc: Lucas De Marchi
Quoting Jani Nikula (2020-01-21 13:58:08)
> On Tue, 21 Jan 2020, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > Quoting Jani Nikula (2020-01-21 11:39:15)
> >> Add convenience helpers for the most common uncore operations with
> >> struct drm_i915_private * as context rather than struct intel_uncore *.
> >>
> >> The goal is to replace all instances of I915_READ(),
> >> I915_POSTING_READ(), I915_WRITE(), I915_READ_FW(), and I915_WRITE_FW()
> >> in display/ with these, to finally be able to get rid of the implicit
> >> dev_priv local parameter use.
> >>
> >> The idea is that any non-u32 reads or writes are special enough that
> >> they can use the intel_uncore_* functions directly.
> >>
> >> v2:
> >> - rename the file intel_de.h
> >> - move intel_de_wait_for_* there too
> >> - also add de fw helpers
> >>
> >> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> >> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> >> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> >> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> >> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> >> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> >> ---
> >> drivers/gpu/drm/i915/display/intel_de.h | 72 +++++++++++++++++++
> >> .../drm/i915/display/intel_display_types.h | 1 +
> >> drivers/gpu/drm/i915/i915_drv.h | 14 ----
> >> 3 files changed, 73 insertions(+), 14 deletions(-)
> >> create mode 100644 drivers/gpu/drm/i915/display/intel_de.h
> >>
> >> diff --git a/drivers/gpu/drm/i915/display/intel_de.h b/drivers/gpu/drm/i915/display/intel_de.h
> >> new file mode 100644
> >> index 000000000000..00da10bf35f5
> >> --- /dev/null
> >> +++ b/drivers/gpu/drm/i915/display/intel_de.h
> >> @@ -0,0 +1,72 @@
> >> +/* SPDX-License-Identifier: MIT */
> >> +/*
> >> + * Copyright © 2019 Intel Corporation
> >> + */
> >> +
> >> +#ifndef __INTEL_DE_H__
> >> +#define __INTEL_DE_H__
> >> +
> >> +#include "i915_drv.h"
> >> +#include "i915_reg.h"
> >> +#include "intel_uncore.h"
> >> +
> >> +static inline u32
> >> +intel_de_read(struct drm_i915_private *i915, i915_reg_t reg)
> >> +{
> >> + return intel_uncore_read(&i915->uncore, reg);
> >> +}
> >> +
> >> +static inline void
> >> +intel_de_posting_read(struct drm_i915_private *i915, i915_reg_t reg)
> >> +{
> >> + intel_uncore_posting_read(&i915->uncore, reg);
> >> +}
> >> +
> >> +/* Note: read the warnings for intel_uncore_*_fw() functions! */
> >> +static inline u32
> >> +intel_de_read_fw(struct drm_i915_private *i915, i915_reg_t reg)
> >> +{
> >> + return intel_uncore_read_fw(&i915->uncore, reg);
> >> +}
> >> +
> >> +static inline void
> >> +intel_de_write(struct drm_i915_private *i915, i915_reg_t reg, u32 val)
> >> +{
> >> + intel_uncore_write(&i915->uncore, reg, val);
> >> +}
> >> +
> >> +/* Note: read the warnings for intel_uncore_*_fw() functions! */
> >> +static inline void
> >> +intel_de_write_fw(struct drm_i915_private *i915, i915_reg_t reg, u32 val)
> >> +{
> >> + intel_uncore_write_fw(&i915->uncore, reg, val);
> >> +}
> >> +
> >> +static inline void
> >> +intel_de_rmw(struct drm_i915_private *i915, i915_reg_t reg, u32 clear, u32 set)
> >> +{
> >> + intel_uncore_rmw(&i915->uncore, reg, clear, set);
> >> +}
> >> +
> >> +static inline int
> >> +intel_de_wait_for_register(struct drm_i915_private *i915, i915_reg_t reg,
> >> + u32 mask, u32 value, unsigned int timeout)
> >> +{
> >> + return intel_wait_for_register(&i915->uncore, reg, mask, value, timeout);
> >> +}
> >> +
> >> +static inline int
> >> +intel_de_wait_for_set(struct drm_i915_private *i915, i915_reg_t reg,
> >> + u32 mask, unsigned int timeout)
> >> +{
> >> + return intel_de_wait_for_register(i915, reg, mask, mask, timeout);
> >> +}
> >> +
> >> +static inline int
> >> +intel_de_wait_for_clear(struct drm_i915_private *i915, i915_reg_t reg,
> >> + u32 mask, unsigned int timeout)
> >> +{
> >> + return intel_de_wait_for_register(i915, reg, mask, 0, timeout);
> >> +}
> >> +
> >> +#endif /* __INTEL_DE_H__ */
> >> diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
> >> index 155ce49ae764..0d7adc2c167a 100644
> >> --- a/drivers/gpu/drm/i915/display/intel_display_types.h
> >> +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
> >> @@ -44,6 +44,7 @@
> >> #include <media/cec-notifier.h>
> >>
> >> #include "i915_drv.h"
> >> +#include "intel_de.h"
> >
> > I don't think you want to include it from types.h though -- I think you
> > want to avoid inlines (at least inlines that depend upon external types)
> > away from the types.h so you can avoid the dreaded cycles.
>
> Eventually yes, but I also don't want to splatter #include "intel_de.h"
> everywhere just yet... this seemed to fit the bill. ;)
>
> > So other than that,
> > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> >
> > Or you may want to make the placement of the final include(s) a
> > separate patch.
>
> Thanks for the review. Do you insist on a re-spin with the includes
> sorted out before merge?
Nope. So long as you are aware that the current placement can easily lead
into a trap, fine.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: add display engine uncore helpers (rev2)
2020-01-21 11:39 [Intel-gfx] [PATCH RESEND] drm/i915: add display engine uncore helpers Jani Nikula
` (2 preceding siblings ...)
2020-01-21 13:03 ` [Intel-gfx] [PATCH RESEND] " Chris Wilson
@ 2020-01-21 15:10 ` Patchwork
2020-01-21 15:37 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
` (4 subsequent siblings)
8 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2020-01-21 15:10 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: add display engine uncore helpers (rev2)
URL : https://patchwork.freedesktop.org/series/72331/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
21a0a18251df drm/i915: add display engine uncore helpers
-:35: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#35:
new file mode 100644
total: 0 errors, 1 warnings, 0 checks, 99 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: add display engine uncore helpers (rev2)
2020-01-21 11:39 [Intel-gfx] [PATCH RESEND] drm/i915: add display engine uncore helpers Jani Nikula
` (3 preceding siblings ...)
2020-01-21 15:10 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: add display engine uncore helpers (rev2) Patchwork
@ 2020-01-21 15:37 ` Patchwork
2020-01-21 18:54 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: add display engine uncore helpers (rev3) Patchwork
` (3 subsequent siblings)
8 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2020-01-21 15:37 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: add display engine uncore helpers (rev2)
URL : https://patchwork.freedesktop.org/series/72331/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7783 -> Patchwork_16190
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_16190 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_16190, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16190/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_16190:
### IGT changes ###
#### Possible regressions ####
* igt@runner@aborted:
- fi-hsw-peppy: NOTRUN -> [FAIL][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16190/fi-hsw-peppy/igt@runner@aborted.html
Known issues
------------
Here are the changes found in Patchwork_16190 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_create@basic-files:
- fi-icl-u3: [PASS][2] -> [INCOMPLETE][3] ([fdo#109100] / [i915#140])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7783/fi-icl-u3/igt@gem_ctx_create@basic-files.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16190/fi-icl-u3/igt@gem_ctx_create@basic-files.html
* igt@gem_exec_parallel@fds:
- fi-hsw-peppy: [PASS][4] -> [TIMEOUT][5] ([fdo#112271])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7783/fi-hsw-peppy/igt@gem_exec_parallel@fds.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16190/fi-hsw-peppy/igt@gem_exec_parallel@fds.html
* igt@gem_exec_suspend@basic-s4-devices:
- fi-kbl-7500u: [PASS][6] -> [DMESG-WARN][7] ([fdo#107139])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7783/fi-kbl-7500u/igt@gem_exec_suspend@basic-s4-devices.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16190/fi-kbl-7500u/igt@gem_exec_suspend@basic-s4-devices.html
* igt@i915_module_load@reload-with-fault-injection:
- fi-skl-lmem: [PASS][8] -> [INCOMPLETE][9] ([i915#671] / [i915#971])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7783/fi-skl-lmem/igt@i915_module_load@reload-with-fault-injection.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16190/fi-skl-lmem/igt@i915_module_load@reload-with-fault-injection.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [PASS][10] -> [FAIL][11] ([fdo#111096] / [i915#323])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7783/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16190/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
#### Possible fixes ####
* igt@gem_exec_parallel@contexts:
- fi-byt-n2820: [INCOMPLETE][12] ([i915#45] / [i915#999]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7783/fi-byt-n2820/igt@gem_exec_parallel@contexts.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16190/fi-byt-n2820/igt@gem_exec_parallel@contexts.html
- {fi-ehl-1}: [INCOMPLETE][14] ([i915#937]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7783/fi-ehl-1/igt@gem_exec_parallel@contexts.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16190/fi-ehl-1/igt@gem_exec_parallel@contexts.html
* igt@i915_module_load@reload-with-fault-injection:
- fi-cfl-8700k: [DMESG-WARN][16] ([i915#889]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7783/fi-cfl-8700k/igt@i915_module_load@reload-with-fault-injection.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16190/fi-cfl-8700k/igt@i915_module_load@reload-with-fault-injection.html
- fi-skl-6700k2: [INCOMPLETE][18] ([i915#671]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7783/fi-skl-6700k2/igt@i915_module_load@reload-with-fault-injection.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16190/fi-skl-6700k2/igt@i915_module_load@reload-with-fault-injection.html
- fi-kbl-x1275: [DMESG-WARN][20] ([i915#889]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7783/fi-kbl-x1275/igt@i915_module_load@reload-with-fault-injection.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16190/fi-kbl-x1275/igt@i915_module_load@reload-with-fault-injection.html
* igt@i915_pm_rpm@module-reload:
- fi-kbl-x1275: [INCOMPLETE][22] ([i915#151]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7783/fi-kbl-x1275/igt@i915_pm_rpm@module-reload.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16190/fi-kbl-x1275/igt@i915_pm_rpm@module-reload.html
#### Warnings ####
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-bxt-dsi: [SKIP][24] ([fdo#109271]) -> [SKIP][25] ([fdo#109271] / [fdo#111827]) +8 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7783/fi-bxt-dsi/igt@kms_chamelium@common-hpd-after-suspend.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16190/fi-bxt-dsi/igt@kms_chamelium@common-hpd-after-suspend.html
- fi-hsw-4770: [SKIP][26] ([fdo#109271]) -> [SKIP][27] ([fdo#109271] / [fdo#111827]) +8 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7783/fi-hsw-4770/igt@kms_chamelium@common-hpd-after-suspend.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16190/fi-hsw-4770/igt@kms_chamelium@common-hpd-after-suspend.html
- fi-kbl-soraka: [SKIP][28] ([fdo#109271]) -> [SKIP][29] ([fdo#109271] / [fdo#111827]) +8 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7783/fi-kbl-soraka/igt@kms_chamelium@common-hpd-after-suspend.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16190/fi-kbl-soraka/igt@kms_chamelium@common-hpd-after-suspend.html
- fi-whl-u: [SKIP][30] ([fdo#109271]) -> [SKIP][31] ([fdo#109271] / [fdo#111827]) +8 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7783/fi-whl-u/igt@kms_chamelium@common-hpd-after-suspend.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16190/fi-whl-u/igt@kms_chamelium@common-hpd-after-suspend.html
- fi-pnv-d510: [SKIP][32] ([fdo#109271]) -> [SKIP][33] ([fdo#109271] / [fdo#111827]) +8 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7783/fi-pnv-d510/igt@kms_chamelium@common-hpd-after-suspend.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16190/fi-pnv-d510/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_chamelium@dp-crc-fast:
- fi-icl-dsi: [SKIP][34] ([fdo#109284]) -> [SKIP][35] ([fdo#109284] / [fdo#111827]) +8 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7783/fi-icl-dsi/igt@kms_chamelium@dp-crc-fast.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16190/fi-icl-dsi/igt@kms_chamelium@dp-crc-fast.html
- fi-skl-guc: [SKIP][36] ([fdo#109271]) -> [SKIP][37] ([fdo#109271] / [fdo#111827]) +8 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7783/fi-skl-guc/igt@kms_chamelium@dp-crc-fast.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16190/fi-skl-guc/igt@kms_chamelium@dp-crc-fast.html
- fi-bwr-2160: [SKIP][38] ([fdo#109271]) -> [SKIP][39] ([fdo#109271] / [fdo#111827]) +8 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7783/fi-bwr-2160/igt@kms_chamelium@dp-crc-fast.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16190/fi-bwr-2160/igt@kms_chamelium@dp-crc-fast.html
- fi-bdw-5557u: [SKIP][40] ([fdo#109271]) -> [SKIP][41] ([fdo#109271] / [fdo#111827]) +8 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7783/fi-bdw-5557u/igt@kms_chamelium@dp-crc-fast.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16190/fi-bdw-5557u/igt@kms_chamelium@dp-crc-fast.html
- fi-icl-y: [SKIP][42] ([fdo#109284]) -> [SKIP][43] ([fdo#109284] / [fdo#111827]) +8 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7783/fi-icl-y/igt@kms_chamelium@dp-crc-fast.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16190/fi-icl-y/igt@kms_chamelium@dp-crc-fast.html
* igt@kms_chamelium@dp-edid-read:
- fi-cfl-guc: [SKIP][44] ([fdo#109271]) -> [SKIP][45] ([fdo#109271] / [fdo#111827]) +8 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7783/fi-cfl-guc/igt@kms_chamelium@dp-edid-read.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16190/fi-cfl-guc/igt@kms_chamelium@dp-edid-read.html
- fi-icl-guc: [SKIP][46] ([fdo#109284]) -> [SKIP][47] ([fdo#109284] / [fdo#111827]) +8 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7783/fi-icl-guc/igt@kms_chamelium@dp-edid-read.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16190/fi-icl-guc/igt@kms_chamelium@dp-edid-read.html
- fi-elk-e7500: [SKIP][48] ([fdo#109271]) -> [SKIP][49] ([fdo#109271] / [fdo#111827]) +8 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7783/fi-elk-e7500/igt@kms_chamelium@dp-edid-read.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16190/fi-elk-e7500/igt@kms_chamelium@dp-edid-read.html
* igt@kms_chamelium@dp-hpd-fast:
- fi-ilk-650: [SKIP][50] ([fdo#109271]) -> [SKIP][51] ([fdo#109271] / [fdo#111827]) +8 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7783/fi-ilk-650/igt@kms_chamelium@dp-hpd-fast.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16190/fi-ilk-650/igt@kms_chamelium@dp-hpd-fast.html
- fi-ivb-3770: [SKIP][52] ([fdo#109271]) -> [SKIP][53] ([fdo#109271] / [fdo#111827]) +8 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7783/fi-ivb-3770/igt@kms_chamelium@dp-hpd-fast.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16190/fi-ivb-3770/igt@kms_chamelium@dp-hpd-fast.html
* igt@kms_chamelium@hdmi-crc-fast:
- fi-skl-lmem: [SKIP][54] ([fdo#109271]) -> [SKIP][55] ([fdo#109271] / [fdo#111827]) +8 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7783/fi-skl-lmem/igt@kms_chamelium@hdmi-crc-fast.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16190/fi-skl-lmem/igt@kms_chamelium@hdmi-crc-fast.html
- fi-kbl-x1275: [SKIP][56] ([fdo#109271]) -> [SKIP][57] ([fdo#109271] / [fdo#111827]) +8 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7783/fi-kbl-x1275/igt@kms_chamelium@hdmi-crc-fast.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16190/fi-kbl-x1275/igt@kms_chamelium@hdmi-crc-fast.html
* igt@kms_chamelium@hdmi-edid-read:
- fi-blb-e6850: [SKIP][58] ([fdo#109271]) -> [SKIP][59] ([fdo#109271] / [fdo#111827]) +8 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7783/fi-blb-e6850/igt@kms_chamelium@hdmi-edid-read.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16190/fi-blb-e6850/igt@kms_chamelium@hdmi-edid-read.html
- fi-kbl-8809g: [SKIP][60] ([fdo#109271]) -> [SKIP][61] ([fdo#109271] / [fdo#111827]) +8 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7783/fi-kbl-8809g/igt@kms_chamelium@hdmi-edid-read.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16190/fi-kbl-8809g/igt@kms_chamelium@hdmi-edid-read.html
- fi-kbl-r: [SKIP][62] ([fdo#109271]) -> [SKIP][63] ([fdo#109271] / [fdo#111827]) +8 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7783/fi-kbl-r/igt@kms_chamelium@hdmi-edid-read.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16190/fi-kbl-r/igt@kms_chamelium@hdmi-edid-read.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-apl-guc: [SKIP][64] ([fdo#109271]) -> [SKIP][65] ([fdo#109271] / [fdo#111827]) +8 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7783/fi-apl-guc/igt@kms_chamelium@hdmi-hpd-fast.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16190/fi-apl-guc/igt@kms_chamelium@hdmi-hpd-fast.html
- fi-snb-2520m: [SKIP][66] ([fdo#109271]) -> [SKIP][67] ([fdo#109271] / [fdo#111827]) +8 similar issues
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7783/fi-snb-2520m/igt@kms_chamelium@hdmi-hpd-fast.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16190/fi-snb-2520m/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@kms_chamelium@vga-edid-read:
- fi-cfl-8700k: [SKIP][68] ([fdo#109271]) -> [SKIP][69] ([fdo#109271] / [fdo#111827]) +8 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7783/fi-cfl-8700k/igt@kms_chamelium@vga-edid-read.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16190/fi-cfl-8700k/igt@kms_chamelium@vga-edid-read.html
- fi-hsw-4770r: [SKIP][70] ([fdo#109271]) -> [SKIP][71] ([fdo#109271] / [fdo#111827]) +8 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7783/fi-hsw-4770r/igt@kms_chamelium@vga-edid-read.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16190/fi-hsw-4770r/igt@kms_chamelium@vga-edid-read.html
- fi-skl-6600u: [SKIP][72] ([fdo#109271]) -> [SKIP][73] ([fdo#109271] / [fdo#111827]) +8 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7783/fi-skl-6600u/igt@kms_chamelium@vga-edid-read.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16190/fi-skl-6600u/igt@kms_chamelium@vga-edid-read.html
* igt@kms_chamelium@vga-hpd-fast:
- fi-kbl-guc: [SKIP][74] ([fdo#109271]) -> [SKIP][75] ([fdo#109271] / [fdo#111827]) +8 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7783/fi-kbl-guc/igt@kms_chamelium@vga-hpd-fast.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16190/fi-kbl-guc/igt@kms_chamelium@vga-hpd-fast.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#107139]: https://bugs.freedesktop.org/show_bug.cgi?id=107139
[fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
[i915#140]: https://gitlab.freedesktop.org/drm/intel/issues/140
[i915#151]: https://gitlab.freedesktop.org/drm/intel/issues/151
[i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323
[i915#45]: https://gitlab.freedesktop.org/drm/intel/issues/45
[i915#671]: https://gitlab.freedesktop.org/drm/intel/issues/671
[i915#889]: https://gitlab.freedesktop.org/drm/intel/issues/889
[i915#937]: https://gitlab.freedesktop.org/drm/intel/issues/937
[i915#971]: https://gitlab.freedesktop.org/drm/intel/issues/971
[i915#999]: https://gitlab.freedesktop.org/drm/intel/issues/999
Participating hosts (44 -> 43)
------------------------------
Additional (4): fi-bsw-kefka fi-glk-dsi fi-bsw-nick fi-snb-2600
Missing (5): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7783 -> Patchwork_16190
CI-20190529: 20190529
CI_DRM_7783: 3ee976286895f0bd54388efc16b12f62c624ff19 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5376: 5cf58d947a02379d2885d6dd4f8bb487cfc3eed2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_16190: 21a0a18251dfd4806bbe24ec9134b4b062a8f267 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
21a0a18251df drm/i915: add display engine uncore helpers
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16190/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: add display engine uncore helpers (rev3)
2020-01-21 11:39 [Intel-gfx] [PATCH RESEND] drm/i915: add display engine uncore helpers Jani Nikula
` (4 preceding siblings ...)
2020-01-21 15:37 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
@ 2020-01-21 18:54 ` Patchwork
2020-01-21 19:18 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
` (2 subsequent siblings)
8 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2020-01-21 18:54 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: add display engine uncore helpers (rev3)
URL : https://patchwork.freedesktop.org/series/72331/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
50c85a55b8d5 drm/i915: add display engine uncore helpers
-:35: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#35:
new file mode 100644
total: 0 errors, 1 warnings, 0 checks, 99 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: add display engine uncore helpers (rev3)
2020-01-21 11:39 [Intel-gfx] [PATCH RESEND] drm/i915: add display engine uncore helpers Jani Nikula
` (5 preceding siblings ...)
2020-01-21 18:54 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: add display engine uncore helpers (rev3) Patchwork
@ 2020-01-21 19:18 ` Patchwork
2020-01-23 1:14 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-01-23 18:00 ` [Intel-gfx] ✓ Fi.CI.IGT: success " Patchwork
8 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2020-01-21 19:18 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: add display engine uncore helpers (rev3)
URL : https://patchwork.freedesktop.org/series/72331/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7786 -> Patchwork_16193
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/index.html
Known issues
------------
Here are the changes found in Patchwork_16193 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_exec@basic:
- fi-icl-dsi: [PASS][1] -> [DMESG-WARN][2] ([i915#109])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/fi-icl-dsi/igt@gem_ctx_exec@basic.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/fi-icl-dsi/igt@gem_ctx_exec@basic.html
* igt@i915_selftest@live_mman:
- fi-bxt-dsi: [PASS][3] -> [DMESG-WARN][4] ([i915#889]) +23 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/fi-bxt-dsi/igt@i915_selftest@live_mman.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/fi-bxt-dsi/igt@i915_selftest@live_mman.html
* igt@i915_selftest@live_reset:
- fi-bxt-dsi: [PASS][5] -> [DMESG-FAIL][6] ([i915#889]) +7 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/fi-bxt-dsi/igt@i915_selftest@live_reset.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/fi-bxt-dsi/igt@i915_selftest@live_reset.html
#### Possible fixes ####
* igt@i915_selftest@live_blt:
- fi-hsw-4770: [DMESG-FAIL][7] ([i915#563]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/fi-hsw-4770/igt@i915_selftest@live_blt.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/fi-hsw-4770/igt@i915_selftest@live_blt.html
#### Warnings ####
* igt@i915_selftest@live_blt:
- fi-hsw-4770r: [DMESG-FAIL][9] ([i915#770]) -> [DMESG-FAIL][10] ([i915#725])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/fi-hsw-4770r/igt@i915_selftest@live_blt.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/fi-hsw-4770r/igt@i915_selftest@live_blt.html
* igt@i915_selftest@live_gem_contexts:
- fi-cfl-8700k: [INCOMPLETE][11] ([CI#80] / [i915#424]) -> [INCOMPLETE][12] ([i915#424])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/fi-cfl-8700k/igt@i915_selftest@live_gem_contexts.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/fi-cfl-8700k/igt@i915_selftest@live_gem_contexts.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[CI#80]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/80
[i915#109]: https://gitlab.freedesktop.org/drm/intel/issues/109
[i915#424]: https://gitlab.freedesktop.org/drm/intel/issues/424
[i915#563]: https://gitlab.freedesktop.org/drm/intel/issues/563
[i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725
[i915#770]: https://gitlab.freedesktop.org/drm/intel/issues/770
[i915#889]: https://gitlab.freedesktop.org/drm/intel/issues/889
[i915#937]: https://gitlab.freedesktop.org/drm/intel/issues/937
Participating hosts (45 -> 40)
------------------------------
Additional (3): fi-hsw-peppy fi-kbl-7560u fi-skl-6600u
Missing (8): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-bsw-kefka fi-byt-clapper
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7786 -> Patchwork_16193
CI-20190529: 20190529
CI_DRM_7786: 72275204176397fc718218335edabb840f520024 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5376: 5cf58d947a02379d2885d6dd4f8bb487cfc3eed2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_16193: 50c85a55b8d5f6eda0b137d315561c8b949ed524 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
50c85a55b8d5 drm/i915: add display engine uncore helpers
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: add display engine uncore helpers (rev3)
2020-01-21 11:39 [Intel-gfx] [PATCH RESEND] drm/i915: add display engine uncore helpers Jani Nikula
` (6 preceding siblings ...)
2020-01-21 19:18 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2020-01-23 1:14 ` Patchwork
2020-01-23 18:00 ` [Intel-gfx] ✓ Fi.CI.IGT: success " Patchwork
8 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2020-01-23 1:14 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: add display engine uncore helpers (rev3)
URL : https://patchwork.freedesktop.org/series/72331/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7786_full -> Patchwork_16193_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_16193_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_16193_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_16193_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_atomic_transition@5x-modeset-transitions-fencing:
- shard-tglb: NOTRUN -> [SKIP][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-tglb8/igt@kms_atomic_transition@5x-modeset-transitions-fencing.html
Known issues
------------
Here are the changes found in Patchwork_16193_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@bcs0-s3:
- shard-kbl: [PASS][2] -> [DMESG-WARN][3] ([i915#180]) +4 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-kbl1/igt@gem_ctx_isolation@bcs0-s3.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-kbl1/igt@gem_ctx_isolation@bcs0-s3.html
* igt@gem_ctx_isolation@rcs0-s3:
- shard-skl: [PASS][4] -> [INCOMPLETE][5] ([i915#69])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-skl4/igt@gem_ctx_isolation@rcs0-s3.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-skl7/igt@gem_ctx_isolation@rcs0-s3.html
* igt@gem_eio@in-flight-contexts-1us:
- shard-snb: [PASS][6] -> [FAIL][7] ([i915#490])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-snb6/igt@gem_eio@in-flight-contexts-1us.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-snb2/igt@gem_eio@in-flight-contexts-1us.html
* igt@gem_exec_schedule@pi-distinct-iova-bsd:
- shard-iclb: [PASS][8] -> [SKIP][9] ([i915#677])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-iclb7/igt@gem_exec_schedule@pi-distinct-iova-bsd.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-iclb2/igt@gem_exec_schedule@pi-distinct-iova-bsd.html
* igt@gem_exec_schedule@preempt-hang-bsd:
- shard-iclb: [PASS][10] -> [SKIP][11] ([fdo#112146])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-iclb7/igt@gem_exec_schedule@preempt-hang-bsd.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-iclb2/igt@gem_exec_schedule@preempt-hang-bsd.html
* igt@gem_exec_schedule@promotion-bsd1:
- shard-iclb: [PASS][12] -> [SKIP][13] ([fdo#109276]) +2 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-iclb1/igt@gem_exec_schedule@promotion-bsd1.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-iclb8/igt@gem_exec_schedule@promotion-bsd1.html
* igt@gem_exec_store@basic-vcs1:
- shard-iclb: [PASS][14] -> [SKIP][15] ([fdo#112080]) +1 similar issue
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-iclb2/igt@gem_exec_store@basic-vcs1.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-iclb6/igt@gem_exec_store@basic-vcs1.html
* igt@gem_persistent_relocs@forked-faulting-reloc-thrashing:
- shard-kbl: [PASS][16] -> [INCOMPLETE][17] ([fdo#103665] / [i915#530])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-kbl2/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-kbl6/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html
* igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing:
- shard-apl: [PASS][18] -> [TIMEOUT][19] ([fdo#112271] / [i915#530]) +2 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-apl2/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-apl7/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
* igt@gem_persistent_relocs@forked-interruptible-thrashing:
- shard-kbl: [PASS][20] -> [TIMEOUT][21] ([fdo#112271] / [i915#530])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-kbl3/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-kbl1/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
* igt@gem_ppgtt@flink-and-close-vma-leak:
- shard-glk: [PASS][22] -> [FAIL][23] ([i915#644])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-glk3/igt@gem_ppgtt@flink-and-close-vma-leak.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-glk1/igt@gem_ppgtt@flink-and-close-vma-leak.html
* igt@gem_tiled_blits@interruptible:
- shard-hsw: [PASS][24] -> [FAIL][25] ([i915#694])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-hsw4/igt@gem_tiled_blits@interruptible.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-hsw2/igt@gem_tiled_blits@interruptible.html
* igt@i915_pm_rps@waitboost:
- shard-tglb: [PASS][26] -> [FAIL][27] ([i915#413])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-tglb7/igt@i915_pm_rps@waitboost.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-tglb1/igt@i915_pm_rps@waitboost.html
* igt@i915_selftest@mock_requests:
- shard-tglb: [PASS][28] -> [INCOMPLETE][29] ([i915#472])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-tglb1/igt@i915_selftest@mock_requests.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-tglb1/igt@i915_selftest@mock_requests.html
- shard-hsw: [PASS][30] -> [INCOMPLETE][31] ([i915#61])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-hsw2/igt@i915_selftest@mock_requests.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-hsw4/igt@i915_selftest@mock_requests.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-skl: [PASS][32] -> [INCOMPLETE][33] ([i915#221])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-skl7/igt@kms_flip@flip-vs-suspend-interruptible.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-skl8/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-stridechange:
- shard-tglb: [PASS][34] -> [FAIL][35] ([i915#49]) +3 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-tglb3/igt@kms_frontbuffer_tracking@fbc-stridechange.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-stridechange.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][36] -> [FAIL][37] ([fdo#108145] / [i915#265])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-skl2/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-skl8/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_setmode@basic:
- shard-skl: [PASS][38] -> [FAIL][39] ([i915#31])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-skl7/igt@kms_setmode@basic.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-skl8/igt@kms_setmode@basic.html
#### Possible fixes ####
* igt@gem_ctx_isolation@vcs1-clean:
- shard-iclb: [SKIP][40] ([fdo#109276] / [fdo#112080]) -> [PASS][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-iclb3/igt@gem_ctx_isolation@vcs1-clean.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-iclb1/igt@gem_ctx_isolation@vcs1-clean.html
* igt@gem_ctx_persistence@processes:
- shard-skl: [FAIL][42] ([i915#570]) -> [PASS][43]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-skl1/igt@gem_ctx_persistence@processes.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-skl9/igt@gem_ctx_persistence@processes.html
* igt@gem_exec_parallel@bcs0-fds:
- shard-hsw: [INCOMPLETE][44] ([i915#61]) -> [PASS][45] +1 similar issue
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-hsw6/igt@gem_exec_parallel@bcs0-fds.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-hsw2/igt@gem_exec_parallel@bcs0-fds.html
* igt@gem_exec_schedule@preempt-contexts-bsd1:
- shard-iclb: [SKIP][46] ([fdo#109276]) -> [PASS][47] +2 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-iclb3/igt@gem_exec_schedule@preempt-contexts-bsd1.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-iclb1/igt@gem_exec_schedule@preempt-contexts-bsd1.html
* igt@gem_exec_schedule@preemptive-hang-bsd:
- shard-iclb: [SKIP][48] ([fdo#112146]) -> [PASS][49]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-iclb1/igt@gem_exec_schedule@preemptive-hang-bsd.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-iclb8/igt@gem_exec_schedule@preemptive-hang-bsd.html
* igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive:
- shard-kbl: [TIMEOUT][50] ([fdo#112271] / [i915#530]) -> [PASS][51]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-kbl3/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-kbl4/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive.html
* igt@gem_persistent_relocs@forked-interruptible-thrashing:
- shard-tglb: [TIMEOUT][52] ([fdo#112126] / [fdo#112271] / [i915#530]) -> [PASS][53]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-tglb8/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-tglb4/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
* igt@gem_persistent_relocs@forked-thrash-inactive:
- shard-glk: [TIMEOUT][54] ([fdo#112271] / [i915#530]) -> [PASS][55]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-glk6/igt@gem_persistent_relocs@forked-thrash-inactive.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-glk9/igt@gem_persistent_relocs@forked-thrash-inactive.html
* igt@i915_hangman@error-state-capture-vcs1:
- shard-iclb: [SKIP][56] ([fdo#112080]) -> [PASS][57] +5 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-iclb3/igt@i915_hangman@error-state-capture-vcs1.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-iclb1/igt@i915_hangman@error-state-capture-vcs1.html
* igt@i915_selftest@mock_requests:
- shard-snb: [INCOMPLETE][58] ([i915#82]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-snb4/igt@i915_selftest@mock_requests.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-snb2/igt@i915_selftest@mock_requests.html
- shard-apl: [INCOMPLETE][60] ([fdo#103927]) -> [PASS][61]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-apl6/igt@i915_selftest@mock_requests.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-apl7/igt@i915_selftest@mock_requests.html
* igt@kms_color@pipe-a-ctm-0-75:
- shard-skl: [DMESG-WARN][62] ([i915#109]) -> [PASS][63]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-skl8/igt@kms_color@pipe-a-ctm-0-75.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-skl4/igt@kms_color@pipe-a-ctm-0-75.html
* igt@kms_flip@2x-flip-vs-expired-vblank:
- shard-glk: [FAIL][64] ([i915#79]) -> [PASS][65]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-glk6/igt@kms_flip@2x-flip-vs-expired-vblank.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-glk2/igt@kms_flip@2x-flip-vs-expired-vblank.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-skl: [FAIL][66] ([i915#79]) -> [PASS][67]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-skl1/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-skl10/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
* igt@kms_flip@flip-vs-suspend:
- shard-skl: [INCOMPLETE][68] ([i915#221]) -> [PASS][69]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-skl6/igt@kms_flip@flip-vs-suspend.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-skl7/igt@kms_flip@flip-vs-suspend.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-apl: [DMESG-WARN][70] ([i915#180]) -> [PASS][71] +2 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-apl1/igt@kms_flip@flip-vs-suspend-interruptible.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-apl7/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible:
- shard-skl: [FAIL][72] ([i915#34]) -> [PASS][73]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-skl3/igt@kms_flip@plain-flip-fb-recreate-interruptible.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-skl10/igt@kms_flip@plain-flip-fb-recreate-interruptible.html
* igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-mmap-wc:
- shard-tglb: [FAIL][74] ([i915#49]) -> [PASS][75] +3 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-mmap-wc.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-mmap-wc.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-kbl: [DMESG-WARN][76] ([i915#180]) -> [PASS][77] +1 similar issue
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-kbl2/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-kbl2/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
* igt@kms_psr@psr2_cursor_plane_onoff:
- shard-iclb: [SKIP][78] ([fdo#109441]) -> [PASS][79]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-iclb7/igt@kms_psr@psr2_cursor_plane_onoff.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html
* igt@kms_sequence@get-forked-busy:
- shard-snb: [SKIP][80] ([fdo#109271]) -> [PASS][81]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-snb2/igt@kms_sequence@get-forked-busy.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-snb6/igt@kms_sequence@get-forked-busy.html
* igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend:
- shard-iclb: [DMESG-WARN][82] ([fdo#111764]) -> [PASS][83]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-iclb4/igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-iclb5/igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend.html
#### Warnings ####
* igt@gem_ctx_isolation@vcs1-nonpriv-switch:
- shard-iclb: [FAIL][84] ([IGT#28]) -> [SKIP][85] ([fdo#109276] / [fdo#112080])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-iclb4/igt@gem_ctx_isolation@vcs1-nonpriv-switch.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-iclb5/igt@gem_ctx_isolation@vcs1-nonpriv-switch.html
* igt@gem_eio@kms:
- shard-snb: [INCOMPLETE][86] ([i915#82]) -> [DMESG-WARN][87] ([i915#443] / [i915#444])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-snb2/igt@gem_eio@kms.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-snb4/igt@gem_eio@kms.html
* igt@i915_pm_rpm@modeset-pc8-residency-stress:
- shard-snb: [INCOMPLETE][88] ([i915#82]) -> [SKIP][89] ([fdo#109271])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-snb2/igt@i915_pm_rpm@modeset-pc8-residency-stress.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-snb2/igt@i915_pm_rpm@modeset-pc8-residency-stress.html
[IGT#28]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/28
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#111764]: https://bugs.freedesktop.org/show_bug.cgi?id=111764
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[fdo#112126]: https://bugs.freedesktop.org/show_bug.cgi?id=112126
[fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
[i915#109]: https://gitlab.freedesktop.org/drm/intel/issues/109
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#221]: https://gitlab.freedesktop.org/drm/intel/issues/221
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#34]: https://gitlab.freedesktop.org/drm/intel/issues/34
[i915#413]: https://gitlab.freedesktop.org/drm/intel/issues/413
[i915#443]: https://gitlab.freedesktop.org/drm/intel/issues/443
[i915#444]: https://gitlab.freedesktop.org/drm/intel/issues/444
[i915#472]: https://gitlab.freedesktop.org/drm/intel/issues/472
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#490]: https://gitlab.freedesktop.org/drm/intel/issues/490
[i915#530]: https://gitlab.freedesktop.org/drm/intel/issues/530
[i915#570]: https://gitlab.freedesktop.org/drm/intel/issues/570
[i915#61]: https://gitlab.freedesktop.org/drm/intel/issues/61
[i915#644]: https://gitlab.freedesktop.org/drm/intel/issues/644
[i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677
[i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69
[i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7786 -> Patchwork_16193
CI-20190529: 20190529
CI_DRM_7786: 72275204176397fc718218335edabb840f520024 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5376: 5cf58d947a02379d2885d6dd4f8bb487cfc3eed2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_16193: 50c85a55b8d5f6eda0b137d315561c8b949ed524 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH RESEND] drm/i915: add display engine uncore helpers
2020-01-21 14:11 ` Chris Wilson
@ 2020-01-23 9:36 ` Jani Nikula
0 siblings, 0 replies; 13+ messages in thread
From: Jani Nikula @ 2020-01-23 9:36 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: Lucas De Marchi
On Tue, 21 Jan 2020, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Jani Nikula (2020-01-21 13:58:08)
>> On Tue, 21 Jan 2020, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>> > Quoting Jani Nikula (2020-01-21 11:39:15)
>> >> Add convenience helpers for the most common uncore operations with
>> >> struct drm_i915_private * as context rather than struct intel_uncore *.
>> >>
>> >> The goal is to replace all instances of I915_READ(),
>> >> I915_POSTING_READ(), I915_WRITE(), I915_READ_FW(), and I915_WRITE_FW()
>> >> in display/ with these, to finally be able to get rid of the implicit
>> >> dev_priv local parameter use.
>> >>
>> >> The idea is that any non-u32 reads or writes are special enough that
>> >> they can use the intel_uncore_* functions directly.
>> >>
>> >> v2:
>> >> - rename the file intel_de.h
>> >> - move intel_de_wait_for_* there too
>> >> - also add de fw helpers
>> >>
>> >> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>> >> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
>> >> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>> >> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>> >> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> >> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> >> ---
>> >> drivers/gpu/drm/i915/display/intel_de.h | 72 +++++++++++++++++++
>> >> .../drm/i915/display/intel_display_types.h | 1 +
>> >> drivers/gpu/drm/i915/i915_drv.h | 14 ----
>> >> 3 files changed, 73 insertions(+), 14 deletions(-)
>> >> create mode 100644 drivers/gpu/drm/i915/display/intel_de.h
>> >>
>> >> diff --git a/drivers/gpu/drm/i915/display/intel_de.h b/drivers/gpu/drm/i915/display/intel_de.h
>> >> new file mode 100644
>> >> index 000000000000..00da10bf35f5
>> >> --- /dev/null
>> >> +++ b/drivers/gpu/drm/i915/display/intel_de.h
>> >> @@ -0,0 +1,72 @@
>> >> +/* SPDX-License-Identifier: MIT */
>> >> +/*
>> >> + * Copyright © 2019 Intel Corporation
>> >> + */
>> >> +
>> >> +#ifndef __INTEL_DE_H__
>> >> +#define __INTEL_DE_H__
>> >> +
>> >> +#include "i915_drv.h"
>> >> +#include "i915_reg.h"
>> >> +#include "intel_uncore.h"
>> >> +
>> >> +static inline u32
>> >> +intel_de_read(struct drm_i915_private *i915, i915_reg_t reg)
>> >> +{
>> >> + return intel_uncore_read(&i915->uncore, reg);
>> >> +}
>> >> +
>> >> +static inline void
>> >> +intel_de_posting_read(struct drm_i915_private *i915, i915_reg_t reg)
>> >> +{
>> >> + intel_uncore_posting_read(&i915->uncore, reg);
>> >> +}
>> >> +
>> >> +/* Note: read the warnings for intel_uncore_*_fw() functions! */
>> >> +static inline u32
>> >> +intel_de_read_fw(struct drm_i915_private *i915, i915_reg_t reg)
>> >> +{
>> >> + return intel_uncore_read_fw(&i915->uncore, reg);
>> >> +}
>> >> +
>> >> +static inline void
>> >> +intel_de_write(struct drm_i915_private *i915, i915_reg_t reg, u32 val)
>> >> +{
>> >> + intel_uncore_write(&i915->uncore, reg, val);
>> >> +}
>> >> +
>> >> +/* Note: read the warnings for intel_uncore_*_fw() functions! */
>> >> +static inline void
>> >> +intel_de_write_fw(struct drm_i915_private *i915, i915_reg_t reg, u32 val)
>> >> +{
>> >> + intel_uncore_write_fw(&i915->uncore, reg, val);
>> >> +}
>> >> +
>> >> +static inline void
>> >> +intel_de_rmw(struct drm_i915_private *i915, i915_reg_t reg, u32 clear, u32 set)
>> >> +{
>> >> + intel_uncore_rmw(&i915->uncore, reg, clear, set);
>> >> +}
>> >> +
>> >> +static inline int
>> >> +intel_de_wait_for_register(struct drm_i915_private *i915, i915_reg_t reg,
>> >> + u32 mask, u32 value, unsigned int timeout)
>> >> +{
>> >> + return intel_wait_for_register(&i915->uncore, reg, mask, value, timeout);
>> >> +}
>> >> +
>> >> +static inline int
>> >> +intel_de_wait_for_set(struct drm_i915_private *i915, i915_reg_t reg,
>> >> + u32 mask, unsigned int timeout)
>> >> +{
>> >> + return intel_de_wait_for_register(i915, reg, mask, mask, timeout);
>> >> +}
>> >> +
>> >> +static inline int
>> >> +intel_de_wait_for_clear(struct drm_i915_private *i915, i915_reg_t reg,
>> >> + u32 mask, unsigned int timeout)
>> >> +{
>> >> + return intel_de_wait_for_register(i915, reg, mask, 0, timeout);
>> >> +}
>> >> +
>> >> +#endif /* __INTEL_DE_H__ */
>> >> diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
>> >> index 155ce49ae764..0d7adc2c167a 100644
>> >> --- a/drivers/gpu/drm/i915/display/intel_display_types.h
>> >> +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
>> >> @@ -44,6 +44,7 @@
>> >> #include <media/cec-notifier.h>
>> >>
>> >> #include "i915_drv.h"
>> >> +#include "intel_de.h"
>> >
>> > I don't think you want to include it from types.h though -- I think you
>> > want to avoid inlines (at least inlines that depend upon external types)
>> > away from the types.h so you can avoid the dreaded cycles.
>>
>> Eventually yes, but I also don't want to splatter #include "intel_de.h"
>> everywhere just yet... this seemed to fit the bill. ;)
>>
>> > So other than that,
>> > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
>> >
>> > Or you may want to make the placement of the final include(s) a
>> > separate patch.
>>
>> Thanks for the review. Do you insist on a re-spin with the includes
>> sorted out before merge?
>
> Nope. So long as you are aware that the current placement can easily lead
> into a trap, fine.
Thanks, and pushed to dinq.
Time to unleash cocci to rid us of I915_READ, I915_WRITE, and friends
also in display/.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: add display engine uncore helpers (rev3)
2020-01-21 11:39 [Intel-gfx] [PATCH RESEND] drm/i915: add display engine uncore helpers Jani Nikula
` (7 preceding siblings ...)
2020-01-23 1:14 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
@ 2020-01-23 18:00 ` Patchwork
8 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2020-01-23 18:00 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: add display engine uncore helpers (rev3)
URL : https://patchwork.freedesktop.org/series/72331/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7786_full -> Patchwork_16193_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_16193_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@bcs0-s3:
- shard-kbl: [PASS][1] -> [DMESG-WARN][2] ([i915#180]) +4 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-kbl1/igt@gem_ctx_isolation@bcs0-s3.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-kbl1/igt@gem_ctx_isolation@bcs0-s3.html
* igt@gem_ctx_isolation@rcs0-s3:
- shard-skl: [PASS][3] -> [INCOMPLETE][4] ([i915#69])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-skl4/igt@gem_ctx_isolation@rcs0-s3.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-skl7/igt@gem_ctx_isolation@rcs0-s3.html
* igt@gem_eio@in-flight-contexts-1us:
- shard-snb: [PASS][5] -> [FAIL][6] ([i915#490])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-snb6/igt@gem_eio@in-flight-contexts-1us.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-snb2/igt@gem_eio@in-flight-contexts-1us.html
* igt@gem_exec_schedule@pi-distinct-iova-bsd:
- shard-iclb: [PASS][7] -> [SKIP][8] ([i915#677])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-iclb7/igt@gem_exec_schedule@pi-distinct-iova-bsd.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-iclb2/igt@gem_exec_schedule@pi-distinct-iova-bsd.html
* igt@gem_exec_schedule@preempt-hang-bsd:
- shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#112146])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-iclb7/igt@gem_exec_schedule@preempt-hang-bsd.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-iclb2/igt@gem_exec_schedule@preempt-hang-bsd.html
* igt@gem_exec_schedule@promotion-bsd1:
- shard-iclb: [PASS][11] -> [SKIP][12] ([fdo#109276]) +2 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-iclb1/igt@gem_exec_schedule@promotion-bsd1.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-iclb8/igt@gem_exec_schedule@promotion-bsd1.html
* igt@gem_exec_store@basic-vcs1:
- shard-iclb: [PASS][13] -> [SKIP][14] ([fdo#112080]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-iclb2/igt@gem_exec_store@basic-vcs1.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-iclb6/igt@gem_exec_store@basic-vcs1.html
* igt@gem_persistent_relocs@forked-faulting-reloc-thrashing:
- shard-kbl: [PASS][15] -> [INCOMPLETE][16] ([fdo#103665] / [i915#530])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-kbl2/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-kbl6/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html
* igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing:
- shard-apl: [PASS][17] -> [TIMEOUT][18] ([fdo#112271] / [i915#530]) +2 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-apl2/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-apl7/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
* igt@gem_persistent_relocs@forked-interruptible-thrashing:
- shard-kbl: [PASS][19] -> [TIMEOUT][20] ([fdo#112271] / [i915#530])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-kbl3/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-kbl1/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
* igt@gem_ppgtt@flink-and-close-vma-leak:
- shard-glk: [PASS][21] -> [FAIL][22] ([i915#644])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-glk3/igt@gem_ppgtt@flink-and-close-vma-leak.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-glk1/igt@gem_ppgtt@flink-and-close-vma-leak.html
* igt@gem_tiled_blits@interruptible:
- shard-hsw: [PASS][23] -> [FAIL][24] ([i915#694])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-hsw4/igt@gem_tiled_blits@interruptible.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-hsw2/igt@gem_tiled_blits@interruptible.html
* igt@i915_pm_rps@waitboost:
- shard-tglb: [PASS][25] -> [FAIL][26] ([i915#413])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-tglb7/igt@i915_pm_rps@waitboost.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-tglb1/igt@i915_pm_rps@waitboost.html
* igt@i915_selftest@mock_requests:
- shard-tglb: [PASS][27] -> [INCOMPLETE][28] ([i915#472])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-tglb1/igt@i915_selftest@mock_requests.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-tglb1/igt@i915_selftest@mock_requests.html
- shard-hsw: [PASS][29] -> [INCOMPLETE][30] ([i915#61])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-hsw2/igt@i915_selftest@mock_requests.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-hsw4/igt@i915_selftest@mock_requests.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-skl: [PASS][31] -> [INCOMPLETE][32] ([i915#221])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-skl7/igt@kms_flip@flip-vs-suspend-interruptible.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-skl8/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-stridechange:
- shard-tglb: [PASS][33] -> [FAIL][34] ([i915#49]) +3 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-tglb3/igt@kms_frontbuffer_tracking@fbc-stridechange.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-stridechange.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][35] -> [FAIL][36] ([fdo#108145] / [i915#265])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-skl2/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-skl8/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_setmode@basic:
- shard-skl: [PASS][37] -> [FAIL][38] ([i915#31])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-skl7/igt@kms_setmode@basic.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-skl8/igt@kms_setmode@basic.html
#### Possible fixes ####
* igt@gem_ctx_isolation@vcs1-clean:
- shard-iclb: [SKIP][39] ([fdo#109276] / [fdo#112080]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-iclb3/igt@gem_ctx_isolation@vcs1-clean.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-iclb1/igt@gem_ctx_isolation@vcs1-clean.html
* igt@gem_ctx_persistence@processes:
- shard-skl: [FAIL][41] ([i915#570]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-skl1/igt@gem_ctx_persistence@processes.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-skl9/igt@gem_ctx_persistence@processes.html
* igt@gem_exec_parallel@bcs0-fds:
- shard-hsw: [INCOMPLETE][43] ([i915#61]) -> [PASS][44] +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-hsw6/igt@gem_exec_parallel@bcs0-fds.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-hsw2/igt@gem_exec_parallel@bcs0-fds.html
* igt@gem_exec_schedule@preempt-contexts-bsd1:
- shard-iclb: [SKIP][45] ([fdo#109276]) -> [PASS][46] +2 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-iclb3/igt@gem_exec_schedule@preempt-contexts-bsd1.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-iclb1/igt@gem_exec_schedule@preempt-contexts-bsd1.html
* igt@gem_exec_schedule@preemptive-hang-bsd:
- shard-iclb: [SKIP][47] ([fdo#112146]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-iclb1/igt@gem_exec_schedule@preemptive-hang-bsd.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-iclb8/igt@gem_exec_schedule@preemptive-hang-bsd.html
* igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive:
- shard-kbl: [TIMEOUT][49] ([fdo#112271] / [i915#530]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-kbl3/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-kbl4/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive.html
* igt@gem_persistent_relocs@forked-interruptible-thrashing:
- shard-tglb: [TIMEOUT][51] ([fdo#112126] / [fdo#112271] / [i915#530]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-tglb8/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-tglb4/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
* igt@gem_persistent_relocs@forked-thrash-inactive:
- shard-glk: [TIMEOUT][53] ([fdo#112271] / [i915#530]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-glk6/igt@gem_persistent_relocs@forked-thrash-inactive.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-glk9/igt@gem_persistent_relocs@forked-thrash-inactive.html
* igt@i915_hangman@error-state-capture-vcs1:
- shard-iclb: [SKIP][55] ([fdo#112080]) -> [PASS][56] +5 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-iclb3/igt@i915_hangman@error-state-capture-vcs1.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-iclb1/igt@i915_hangman@error-state-capture-vcs1.html
* igt@i915_selftest@mock_requests:
- shard-snb: [INCOMPLETE][57] ([i915#82]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-snb4/igt@i915_selftest@mock_requests.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-snb2/igt@i915_selftest@mock_requests.html
- shard-apl: [INCOMPLETE][59] ([fdo#103927]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-apl6/igt@i915_selftest@mock_requests.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-apl7/igt@i915_selftest@mock_requests.html
* igt@kms_color@pipe-a-ctm-0-75:
- shard-skl: [DMESG-WARN][61] ([i915#109]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-skl8/igt@kms_color@pipe-a-ctm-0-75.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-skl4/igt@kms_color@pipe-a-ctm-0-75.html
* igt@kms_flip@2x-flip-vs-expired-vblank:
- shard-glk: [FAIL][63] ([i915#79]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-glk6/igt@kms_flip@2x-flip-vs-expired-vblank.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-glk2/igt@kms_flip@2x-flip-vs-expired-vblank.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-skl: [FAIL][65] ([i915#79]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-skl1/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-skl10/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
* igt@kms_flip@flip-vs-suspend:
- shard-skl: [INCOMPLETE][67] ([i915#221]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-skl6/igt@kms_flip@flip-vs-suspend.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-skl7/igt@kms_flip@flip-vs-suspend.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-apl: [DMESG-WARN][69] ([i915#180]) -> [PASS][70] +2 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-apl1/igt@kms_flip@flip-vs-suspend-interruptible.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-apl7/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible:
- shard-skl: [FAIL][71] ([i915#34]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-skl3/igt@kms_flip@plain-flip-fb-recreate-interruptible.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-skl10/igt@kms_flip@plain-flip-fb-recreate-interruptible.html
* igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-mmap-wc:
- shard-tglb: [FAIL][73] ([i915#49]) -> [PASS][74] +3 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-mmap-wc.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-mmap-wc.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-kbl: [DMESG-WARN][75] ([i915#180]) -> [PASS][76] +1 similar issue
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-kbl2/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-kbl2/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
* igt@kms_psr@psr2_cursor_plane_onoff:
- shard-iclb: [SKIP][77] ([fdo#109441]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-iclb7/igt@kms_psr@psr2_cursor_plane_onoff.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html
* igt@kms_sequence@get-forked-busy:
- shard-snb: [SKIP][79] ([fdo#109271]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-snb2/igt@kms_sequence@get-forked-busy.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-snb6/igt@kms_sequence@get-forked-busy.html
* igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend:
- shard-iclb: [DMESG-WARN][81] ([fdo#111764]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-iclb4/igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-iclb5/igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend.html
#### Warnings ####
* igt@gem_ctx_isolation@vcs1-nonpriv-switch:
- shard-iclb: [FAIL][83] ([IGT#28]) -> [SKIP][84] ([fdo#109276] / [fdo#112080])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-iclb4/igt@gem_ctx_isolation@vcs1-nonpriv-switch.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-iclb5/igt@gem_ctx_isolation@vcs1-nonpriv-switch.html
* igt@gem_eio@kms:
- shard-snb: [INCOMPLETE][85] ([i915#82]) -> [DMESG-WARN][86] ([i915#443] / [i915#444])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-snb2/igt@gem_eio@kms.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-snb4/igt@gem_eio@kms.html
* igt@i915_pm_rpm@modeset-pc8-residency-stress:
- shard-snb: [INCOMPLETE][87] ([i915#82]) -> [SKIP][88] ([fdo#109271])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/shard-snb2/igt@i915_pm_rpm@modeset-pc8-residency-stress.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/shard-snb2/igt@i915_pm_rpm@modeset-pc8-residency-stress.html
[IGT#28]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/28
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#111764]: https://bugs.freedesktop.org/show_bug.cgi?id=111764
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[fdo#112126]: https://bugs.freedesktop.org/show_bug.cgi?id=112126
[fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
[i915#109]: https://gitlab.freedesktop.org/drm/intel/issues/109
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#221]: https://gitlab.freedesktop.org/drm/intel/issues/221
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#34]: https://gitlab.freedesktop.org/drm/intel/issues/34
[i915#413]: https://gitlab.freedesktop.org/drm/intel/issues/413
[i915#443]: https://gitlab.freedesktop.org/drm/intel/issues/443
[i915#444]: https://gitlab.freedesktop.org/drm/intel/issues/444
[i915#472]: https://gitlab.freedesktop.org/drm/intel/issues/472
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#490]: https://gitlab.freedesktop.org/drm/intel/issues/490
[i915#530]: https://gitlab.freedesktop.org/drm/intel/issues/530
[i915#570]: https://gitlab.freedesktop.org/drm/intel/issues/570
[i915#61]: https://gitlab.freedesktop.org/drm/intel/issues/61
[i915#644]: https://gitlab.freedesktop.org/drm/intel/issues/644
[i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677
[i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69
[i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7786 -> Patchwork_16193
CI-20190529: 20190529
CI_DRM_7786: 72275204176397fc718218335edabb840f520024 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5376: 5cf58d947a02379d2885d6dd4f8bb487cfc3eed2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_16193: 50c85a55b8d5f6eda0b137d315561c8b949ed524 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16193/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2020-01-23 18:00 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-21 11:39 [Intel-gfx] [PATCH RESEND] drm/i915: add display engine uncore helpers Jani Nikula
2020-01-21 12:25 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2020-01-21 12:55 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2020-01-21 13:03 ` [Intel-gfx] [PATCH RESEND] " Chris Wilson
2020-01-21 13:58 ` Jani Nikula
2020-01-21 14:11 ` Chris Wilson
2020-01-23 9:36 ` Jani Nikula
2020-01-21 15:10 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: add display engine uncore helpers (rev2) Patchwork
2020-01-21 15:37 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2020-01-21 18:54 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: add display engine uncore helpers (rev3) Patchwork
2020-01-21 19:18 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-01-23 1:14 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-01-23 18:00 ` [Intel-gfx] ✓ Fi.CI.IGT: success " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.