From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E027C2D0CE for ; Tue, 21 Jan 2020 14:23:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 066592070C for ; Tue, 21 Jan 2020 14:23:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cxQABB9q" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 066592070C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55046 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ituRg-0003e6-TU for qemu-devel@archiver.kernel.org; Tue, 21 Jan 2020 09:23:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52997) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itsiU-0004Ba-Gz for qemu-devel@nongnu.org; Tue, 21 Jan 2020 07:33:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1itsiQ-00057G-KK for qemu-devel@nongnu.org; Tue, 21 Jan 2020 07:33:10 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:36482 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1itsiQ-000575-GS for qemu-devel@nongnu.org; Tue, 21 Jan 2020 07:33:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579609986; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8OxUQJ0n4TnYy5rAqGurLPWMkVWTfkYHO7FzsKlmGRU=; b=cxQABB9qg1CHJR7B+eY5zDNc91aLNAJyLkJRM7Uslcz8fdA23hS7BL4qFHkTncTT1u70EM wv4+WgKd+2L2+HCajKN0fS5duzVwqyqtpozg4L5HNCUcMM2oS7yDPDOz7OsxGsSLQsxsu0 TzMDCuHRfkPzjkcKxj5PeNU+rmdAwXk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-403-FLbjSsafOP2WCvLR_F44CQ-1; Tue, 21 Jan 2020 07:33:05 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D7AC0800D48; Tue, 21 Jan 2020 12:33:03 +0000 (UTC) Received: from dgilbert-t580.localhost (unknown [10.36.118.32]) by smtp.corp.redhat.com (Postfix) with ESMTP id 25F8F60BE0; Tue, 21 Jan 2020 12:33:01 +0000 (UTC) From: "Dr. David Alan Gilbert (git)" To: qemu-devel@nongnu.org, stefanha@redhat.com, vgoyal@redhat.com, berrange@redhat.com, slp@redhat.com, philmd@redhat.com Subject: [PATCH v2 108/109] virtiofsd: stop all queue threads on exit in virtio_loop() Date: Tue, 21 Jan 2020 12:24:32 +0000 Message-Id: <20200121122433.50803-109-dgilbert@redhat.com> In-Reply-To: <20200121122433.50803-1-dgilbert@redhat.com> References: <20200121122433.50803-1-dgilbert@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: FLbjSsafOP2WCvLR_F44CQ-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: m.mizuma@jp.fujitsu.com, misono.tomohiro@jp.fujitsu.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: Eryu Guan On guest graceful shutdown, virtiofsd receives VHOST_USER_GET_VRING_BASE request from VMM and shuts down virtqueues by calling fv_set_started(), which joins fv_queue_thread() threads. So when virtio_loop() returns, there should be no thread is still accessing data in fuse session and/or virtio dev. But on abnormal exit, e.g. guest got killed for whatever reason, vhost-user socket is closed and virtio_loop() breaks out the main loop and returns to main(). But it's possible fv_queue_worker()s are still working and accessing fuse session and virtio dev, which results in crash or use-after-free. Fix it by stopping fv_queue_thread()s before virtio_loop() returns, to make sure there's no-one could access fuse session and virtio dev. Reported-by: Qingming Su Signed-off-by: Eryu Guan Reviewed-by: Stefan Hajnoczi --- tools/virtiofsd/fuse_virtio.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/tools/virtiofsd/fuse_virtio.c b/tools/virtiofsd/fuse_virtio.c index 9f6582343c..aca28aafc1 100644 --- a/tools/virtiofsd/fuse_virtio.c +++ b/tools/virtiofsd/fuse_virtio.c @@ -815,6 +815,18 @@ int virtio_loop(struct fuse_session *se) } } =20 + /* + * Make sure all fv_queue_thread()s quit on exit, as we're about to + * free virtio dev and fuse session, no one should access them anymore= . + */ + for (int i =3D 0; i < se->virtio_dev->nqueues; i++) { + if (!se->virtio_dev->qi[i]) + continue; + + fuse_log(FUSE_LOG_INFO, "%s: Stopping queue %d thread\n", __func__= , i); + fv_queue_cleanup_thread(se->virtio_dev, i); + } + fuse_log(FUSE_LOG_INFO, "%s: Exit\n", __func__); =20 return 0; --=20 2.24.1