From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>,
netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
syzkaller-bugs@googlegroups.com,
syzbot+156a04714799b1d480bc@syzkaller.appspotmail.com
Subject: Re: [PATCH nf] netfilter: nf_tables: check for valid chain type pointer before dereference
Date: Tue, 21 Jan 2020 15:35:59 +0100 [thread overview]
Message-ID: <20200121143559.GP795@breakpoint.cc> (raw)
In-Reply-To: <20200121132618.aykyybudttbxiusx@salvia>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > Otherwise, if a helper function to check for the families that are
> > really supported could be another alternative. But not sure it is
> > worth?
>
> Not worth.
>
> Probably this patch instead? Just make sure that access to the chain
> type array is safe, no direct access to chain_type[][] anymore.
>
> This includes the check for the default type too, since it cannot be
> assume to always have a filter chain for unsupported families.
>
> Thanks for explaining.
LGTM, this will prbably also fix the other sytbot splat wrt.
nla_strcmp().
next prev parent reply other threads:[~2020-01-21 14:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 20:51 general protection fault in nft_chain_parse_hook syzbot
2020-01-16 18:03 ` syzbot
2020-01-16 21:11 ` [PATCH nf] netfilter: nf_tables: check for valid chain type pointer before dereference Florian Westphal
2020-01-18 20:30 ` Pablo Neira Ayuso
2020-01-18 23:28 ` Florian Westphal
2020-01-21 13:26 ` Pablo Neira Ayuso
2020-01-21 14:35 ` Florian Westphal [this message]
2020-01-17 18:57 ` general protection fault in nft_chain_parse_hook syzbot
2020-01-17 18:57 ` [Bridge] " syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200121143559.GP795@breakpoint.cc \
--to=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=syzbot+156a04714799b1d480bc@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.